diff --git a/webapp/test/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ObjectPropertyTemplateModel_PropertyListConfigTest.java b/webapp/test/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ObjectPropertyTemplateModel_PropertyListConfigTest.java index e5cf860d0..1ab3f53f2 100644 --- a/webapp/test/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ObjectPropertyTemplateModel_PropertyListConfigTest.java +++ b/webapp/test/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ObjectPropertyTemplateModel_PropertyListConfigTest.java @@ -82,22 +82,15 @@ public class ObjectPropertyTemplateModel_PropertyListConfigTest extends createConfigFile("constructQueryMissing"); createConfigFile("constructQueryMultiple"); createConfigFile("default"); - createConfigFile("notValidXml"); createConfigFile("postProcessorClassNotFound"); createConfigFile("postProcessorClassNotSuitable"); createConfigFile("postProcessorConstructorThrowsException"); createConfigFile("postProcessorNameEmpty"); createConfigFile("postProcessorOK"); createConfigFile("postProcessorWrongConstructor"); - createConfigFile("selectQueryNodeBlank"); - createConfigFile("selectQueryNodeNotFound"); - createConfigFile("selectQuerySubNodes"); - createConfigFile("selectQueryNoSubNodes"); createConfigFile("selectQueryCollatedValid"); createConfigFile("selectQueryCollatedNoSelect"); createConfigFile("selectQueryCollatedNoOrder"); - createConfigFile("templateNodeIsEmpty"); - createConfigFile("templateNodeNotFound"); createConfigFile("templateDoesNotExist"); } @@ -152,12 +145,13 @@ public class ObjectPropertyTemplateModel_PropertyListConfigTest extends // TODO - baseTemplateModel shouldn't require the servlet context to be set // statically!!! ServletContext shouldn't be a static field. - // ---------------------------------------------------------------------- - // The tests - // - // TODO - remove any tests that are covered by the newer - // CustomListViewConfigFileTest. - // ---------------------------------------------------------------------- + /* + * These tests were removed because the newer CustomListViewConfigTest + * covered them: configFileNotValidXml(), selectQueryNodeIsNotFound(), + * selectQueryNodeIsBlank(), selectSubNodesCollatedCritical(), + * selectSubNodesCollatedUncritical(), selectSubNodesUncollatedCritical(), + * selectSubNodesUncollatedUncritical(), selectNoSubNodesCollatedCritical() + */ // // Null arguments @@ -227,68 +221,9 @@ public class ObjectPropertyTemplateModel_PropertyListConfigTest extends assertLogMessagesContains("file not found", "Can't find config file"); } - @Test - public void configFileNotValidXml() throws InvalidConfigurationException { - suppressSyserr(); - captureLogsFromPropertyListConfig(); - - op = buildOperation("notValidXml"); - optm = new NonCollatingOPTM(op, subject, vreq, false); - - assertLogMessagesContains("not valid XML", "SAXParseException"); - } - - // - // Problems with the node - // - - @Test - public void selectQueryNodeIsNotFound() - throws InvalidConfigurationException { - captureLogsFromPropertyListConfig(); - - op = buildOperation("selectQueryNodeNotFound"); - optm = new NonCollatingOPTM(op, subject, vreq, false); - - assertLogMessagesContains("no select query", - "Missing select query specification"); - } - - @Test - public void selectQueryNodeIsBlank() throws InvalidConfigurationException { - captureLogsFromPropertyListConfig(); - - op = buildOperation("selectQueryNodeBlank"); - optm = new NonCollatingOPTM(op, subject, vreq, false); - - assertLogMessagesContains("blank select query", - "Missing select query specification"); - } - // // Problems with the