NIHVIVO-2267 Fix path to image on contact form confirmation page. Rename vivo-basic site_icons directory to align with images directory in wilma.

webapp/src/edu/cornell/mannlib/vitro/webapp/controller/freemarker/FreemarkerHttpServlet.java

@@ -263,7 +263,6 @@ public class FreemarkerHttpServlet extends VitroHttpServlet {
         urls.put("login", urlBuilder.getLoginUrl());          
         urls.put("logout", urlBuilder.getLogoutUrl());       
         urls.put("siteAdmin", urlBuilder.getPortalUrl(Route.SITE_ADMIN));  
-        urls.put("siteIcons", urlBuilder.getPortalUrl(themeDir + "/site_icons")); // deprecated
         urls.put("themeImages", urlBuilder.getPortalUrl(themeDir + "/images"));
         urls.put("images", UrlBuilder.getUrl("/images"));
         urls.put("theme", UrlBuilder.getUrl(themeDir));

webapp/web/templates/freemarker/body/contactForm/contactForm-confirmation.ftl

@@ -3,7 +3,7 @@
 <#-- Contact form submission confirmation page -->
 
 <h2>Thank you for your feedback</h2>
-<img src="${urls.siteIcons}/mail.gif" alt="mailbox"/>
+<img src="${urls.images}/mail.gif" alt="mailbox"/>
 
 <p>Thank you for contacting our curation and development team. We will respond to your inquiry as soon as possible.</p>
 <p>Return to the <a href="${urls.home}">home page</a>.</p>