diff --git a/api/src/main/java/edu/cornell/mannlib/semservices/util/XMLUtils.java b/api/src/main/java/edu/cornell/mannlib/semservices/util/XMLUtils.java index 4a2cb0ef3..86a043c9a 100644 --- a/api/src/main/java/edu/cornell/mannlib/semservices/util/XMLUtils.java +++ b/api/src/main/java/edu/cornell/mannlib/semservices/util/XMLUtils.java @@ -134,10 +134,7 @@ public class XMLUtils { Transformer transformer = null; try { transformer = TransformerFactory.newInstance().newTransformer(); - } catch (TransformerConfigurationException e) { - // TODO Auto-generated catch block - e.printStackTrace(); - } catch (TransformerFactoryConfigurationError e) { + } catch (TransformerConfigurationException | TransformerFactoryConfigurationError e) { // TODO Auto-generated catch block e.printStackTrace(); } @@ -164,10 +161,7 @@ public class XMLUtils { Transformer transformer = null; try { transformer = TransformerFactory.newInstance().newTransformer(); - } catch (TransformerConfigurationException e) { - // TODO Auto-generated catch block - e.printStackTrace(); - } catch (TransformerFactoryConfigurationError e) { + } catch (TransformerConfigurationException | TransformerFactoryConfigurationError e) { // TODO Auto-generated catch block e.printStackTrace(); } diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/beans/DynamicField.java b/api/src/main/java/edu/cornell/mannlib/vedit/beans/DynamicField.java index bf45c0103..ae2ebdb75 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/beans/DynamicField.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/beans/DynamicField.java @@ -3,7 +3,6 @@ package edu.cornell.mannlib.vedit.beans; import java.util.List; -import java.util.ArrayList; import java.util.HashMap; public class DynamicField { diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java b/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java index 10eb262bd..aa755021e 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java @@ -32,7 +32,6 @@ import edu.cornell.mannlib.vitro.webapp.controller.Controllers; import edu.cornell.mannlib.vitro.webapp.controller.VitroHttpServlet; import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest; import edu.cornell.mannlib.vitro.webapp.modelaccess.ModelAccess; -import edu.cornell.mannlib.vitro.webapp.modelaccess.ModelAccess.ReasoningOption; import edu.cornell.mannlib.vitro.webapp.dao.WebappDaoFactory; public class BaseEditController extends VitroHttpServlet { diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java b/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java index 6547be004..1d5b282f0 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java @@ -129,27 +129,31 @@ public class OperationController extends BaseEditController { notifyChangeListeners(epo, action); /* send the user somewhere */ - if (action.equals("insert")){ - // Object[] args = new Object[1]; - // args[0] = result; - // epo.setNewBean(epo.getGetMethod().invoke(facade,args)); - PageForwarder pipf = epo.getPostInsertPageForwarder(); - if (pipf != null){ - pipf.doForward(request,response,epo); - return; - } - } else if (action.equals("update")){ - PageForwarder pupf = epo.getPostUpdatePageForwarder(); - if (pupf != null) { - pupf.doForward(request,response,epo); - return; - } - } else if (action.equals("delete")){ - PageForwarder pdpf = epo.getPostDeletePageForwarder(); - if (pdpf != null) { - pdpf.doForward(request,response,epo); - return; - } + switch (action) { + case "insert": + // Object[] args = new Object[1]; + // args[0] = result; + // epo.setNewBean(epo.getGetMethod().invoke(facade,args)); + PageForwarder pipf = epo.getPostInsertPageForwarder(); + if (pipf != null) { + pipf.doForward(request, response, epo); + return; + } + break; + case "update": + PageForwarder pupf = epo.getPostUpdatePageForwarder(); + if (pupf != null) { + pupf.doForward(request, response, epo); + return; + } + break; + case "delete": + PageForwarder pdpf = epo.getPostDeletePageForwarder(); + if (pdpf != null) { + pdpf.doForward(request, response, epo); + return; + } + break; } //if no page forwarder was set, just go back to referring page: @@ -170,7 +174,6 @@ public class OperationController extends BaseEditController { try { retry(request, response, epo); - return; } catch (IOException ioe) { log.error(this.getClass().getName() + " IOError on redirect: ", ioe); } @@ -198,7 +201,6 @@ public class OperationController extends BaseEditController { } else { response.sendRedirect(getDefaultLandingPage(request)); } - return; } private void runPreprocessors(EditProcessObject epo, Object newObj) { @@ -256,14 +258,14 @@ public class OperationController extends BaseEditController { List validatorList = (List) epo.getValidatorMap().get(currParam); if (validatorList != null) { Iterator valIt = validatorList.iterator(); - String errMsg = ""; + StringBuilder errMsg = new StringBuilder(); while (valIt.hasNext()){ Validator val = (Validator)valIt.next(); ValidationObject vo = val.validate(currValue); if (!vo.getValid()){ valid = false; fieldValid = false; - errMsg += vo.getMessage() + " "; + errMsg.append(vo.getMessage()).append(" "); epo.getBadValueMap().put(currParam,currValue); } else { try { @@ -273,7 +275,7 @@ public class OperationController extends BaseEditController { } } if (errMsg.length()>0) { - epo.getErrMsgMap().put(currParam,errMsg); + epo.getErrMsgMap().put(currParam, errMsg.toString()); log.info("doPost() putting error message "+errMsg+" for "+currParam); } } @@ -330,12 +332,17 @@ public class OperationController extends BaseEditController { Iterator changeIt = changeListeners.iterator(); while (changeIt.hasNext()) { ChangeListener cl = changeIt.next(); - if (action.equals("insert")) - cl.doInserted(epo.getNewBean(),epo); - else if (action.equals("update")) - cl.doUpdated(epo.getOriginalBean(),epo.getNewBean(),epo); - else if (action.equals("delete")) - cl.doDeleted(epo.getOriginalBean(),epo); + switch (action) { + case "insert": + cl.doInserted(epo.getNewBean(), epo); + break; + case "update": + cl.doUpdated(epo.getOriginalBean(), epo.getNewBean(), epo); + break; + case "delete": + cl.doDeleted(epo.getOriginalBean(), epo); + break; + } } } } @@ -499,8 +506,6 @@ public class OperationController extends BaseEditController { } catch (InvocationTargetException f) { log.error(f.getTargetException().getMessage()); } - } catch (NoSuchMethodException e) { - //log.error("doPost() could not find setId() method for "+partialClassName); } catch (Exception f) { //log.error("doPost() could not set id of new bean."); } diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/forwarder/impl/UrlForwarder.java b/api/src/main/java/edu/cornell/mannlib/vedit/forwarder/impl/UrlForwarder.java index adcb3c10b..5104fbc9e 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/forwarder/impl/UrlForwarder.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/forwarder/impl/UrlForwarder.java @@ -4,11 +4,8 @@ package edu.cornell.mannlib.vedit.forwarder.impl; import java.io.IOException; -import java.net.URLEncoder; - import edu.cornell.mannlib.vedit.forwarder.PageForwarder; import edu.cornell.mannlib.vedit.beans.EditProcessObject; -import edu.cornell.mannlib.vitro.webapp.controller.VitroHttpServlet; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/tags/DynamicFieldsTag.java b/api/src/main/java/edu/cornell/mannlib/vedit/tags/DynamicFieldsTag.java index a7da820c4..927a4ba0d 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/tags/DynamicFieldsTag.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/tags/DynamicFieldsTag.java @@ -8,7 +8,6 @@ import java.util.List; import java.util.Iterator; import java.io.File; -import java.io.BufferedOutputStream; import java.io.InputStream; import java.io.FileInputStream; import java.io.BufferedInputStream; @@ -16,18 +15,14 @@ import java.io.InputStreamReader; import java.io.BufferedReader; import java.io.FileNotFoundException; import java.io.IOException; -import java.io.OutputStream; -import java.io.OutputStreamWriter; import javax.servlet.jsp.JspException; -import javax.servlet.jsp.tagext.TagSupport; import javax.servlet.jsp.JspWriter; -import javax.servlet.ServletException; + import edu.cornell.mannlib.vedit.beans.FormObject; import edu.cornell.mannlib.vedit.beans.DynamicField; import edu.cornell.mannlib.vedit.beans.DynamicFieldRow; import org.apache.commons.codec.binary.Base64; -import org.apache.commons.lang3.StringEscapeUtils; import edu.cornell.mannlib.vedit.tags.EditTag; public class DynamicFieldsTag extends EditTag { @@ -63,7 +58,7 @@ public class DynamicFieldsTag extends EditTag { int templateStart = -1; int postStart = -1; - InputStream fis = new FileInputStream (pageContext.getServletContext().getRealPath(new String())+PATH_SEP+MARKUP_FILE_PATH+usePage); + InputStream fis = new FileInputStream (pageContext.getServletContext().getRealPath("")+PATH_SEP+MARKUP_FILE_PATH+usePage); InputStream bis = new BufferedInputStream(fis); BufferedReader in = new BufferedReader(new InputStreamReader(bis)); List lines = new ArrayList(); @@ -83,9 +78,9 @@ public class DynamicFieldsTag extends EditTag { } in.close(); - StringBuffer preMarkupB = new StringBuffer(); - StringBuffer postMarkupB = new StringBuffer(); - StringBuffer templateMarkupB = new StringBuffer(); + StringBuilder preMarkupB = new StringBuilder(); + StringBuilder postMarkupB = new StringBuilder(); + StringBuilder templateMarkupB = new StringBuilder(); if (templateStart>preStart && preStart>0) { for (int i=preStart+1; i0) { - StringBuffer taName = new StringBuffer().append("_").append(dynf.getTable()).append("_"); + StringBuilder taName = new StringBuilder().append("_").append(dynf.getTable()).append("_"); taName.append(row.getId()).append("_"); Iterator paramIt = row.getParameterMap().keySet().iterator(); while(paramIt.hasNext()) { @@ -184,7 +179,7 @@ public class DynamicFieldsTag extends EditTag { taName.append(key).append(":").append(new String(valueInBase64)).append(";"); } if (row.getValue().length()>0) { - String templateWithVars = new String(templateMarkup); + String templateWithVars = templateMarkup; templateWithVars = strReplace(templateWithVars,type+"NN",Integer.toString(i)); templateWithVars = strReplace(templateWithVars,"\\$taName",taName.toString()); templateWithVars = strReplace(templateWithVars,"\\$\\$",row.getValue()); @@ -199,14 +194,14 @@ public class DynamicFieldsTag extends EditTag { // output the row template for the javascript to clone out.println(""); - String hiddenTemplatePreMarkup = new String(preMarkup); + String hiddenTemplatePreMarkup = preMarkup; // bit of a hack to hide the template from the user: hiddenTemplatePreMarkup = strReplace(hiddenTemplatePreMarkup,"display\\:none\\;",""); hiddenTemplatePreMarkup = strReplace(hiddenTemplatePreMarkup,"display\\:block\\;",""); hiddenTemplatePreMarkup = strReplace(hiddenTemplatePreMarkup,"display\\:inline\\;",""); hiddenTemplatePreMarkup = strReplace(hiddenTemplatePreMarkup,"style\\=\\\"","style=\"display:none;"); out.print(hiddenTemplatePreMarkup); - String hiddenTemplateTemplateMarkup = new String(templateMarkup); + String hiddenTemplateTemplateMarkup = templateMarkup; hiddenTemplateTemplateMarkup = strReplace(hiddenTemplateTemplateMarkup, "\\$\\$", ""); out.print(hiddenTemplateTemplateMarkup); out.print(postMarkup); diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/tags/EditTag.java b/api/src/main/java/edu/cornell/mannlib/vedit/tags/EditTag.java index 95b713dd9..e20a8de83 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/tags/EditTag.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/tags/EditTag.java @@ -5,13 +5,10 @@ package edu.cornell.mannlib.vedit.tags; import java.util.HashMap; import javax.servlet.jsp.JspException; -import javax.servlet.jsp.PageContext; import javax.servlet.jsp.tagext.TagSupport; -import javax.servlet.jsp.JspWriter; import edu.cornell.mannlib.vedit.beans.EditProcessObject; import edu.cornell.mannlib.vedit.beans.FormObject; -import org.apache.commons.lang3.StringEscapeUtils; public class EditTag extends TagSupport { private String name = null; diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/tags/ErrorTag.java b/api/src/main/java/edu/cornell/mannlib/vedit/tags/ErrorTag.java index 2242b044a..482504b79 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/tags/ErrorTag.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/tags/ErrorTag.java @@ -3,9 +3,8 @@ package edu.cornell.mannlib.vedit.tags; import javax.servlet.jsp.JspException; -import javax.servlet.jsp.tagext.TagSupport; import javax.servlet.jsp.JspWriter; -import edu.cornell.mannlib.vedit.beans.FormObject; + import edu.cornell.mannlib.vedit.tags.EditTag; import org.apache.commons.lang3.StringEscapeUtils; diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/tags/ValueTag.java b/api/src/main/java/edu/cornell/mannlib/vedit/tags/ValueTag.java index 9efbb8522..650bfbf35 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/tags/ValueTag.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/tags/ValueTag.java @@ -5,7 +5,6 @@ package edu.cornell.mannlib.vedit.tags; import java.util.HashMap; import javax.servlet.jsp.JspException; -import javax.servlet.jsp.tagext.TagSupport; import javax.servlet.jsp.JspWriter; import edu.cornell.mannlib.vedit.beans.FormObject; import org.apache.commons.lang3.StringEscapeUtils; diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java b/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java index 20ef40006..ba9f8fcce 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java @@ -226,7 +226,7 @@ public class FormUtils { Option sOpt = new Option(); sOpt.setValue(selectedValue); if (selectedBody == null || selectedBody.length() == 0) - sOpt.setBody(selectedValue.toString()); + sOpt.setBody(selectedValue); else sOpt.setBody(selectedBody); sOpt.setSelected(true); diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/util/Stemmer.java b/api/src/main/java/edu/cornell/mannlib/vedit/util/Stemmer.java index 753a0b791..5b84d7053 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/util/Stemmer.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/util/Stemmer.java @@ -71,7 +71,7 @@ class Stemmer public void add(char ch) { if (i == b.length) { char[] new_b = new char[i+INC]; - for (int c = 0; c < i; c++) new_b[c] = b[c]; + System.arraycopy(b, 0, new_b, 0, i); b = new_b; } b[i++] = ch; @@ -86,7 +86,7 @@ class Stemmer public void add(char[] w, int wLen) { if (i+wLen >= b.length) { char[] new_b = new char[i+wLen+INC]; - for (int c = 0; c < i; c++) new_b[c] = b[c]; + System.arraycopy(b, 0, new_b, 0, i); b = new_b; } for (int c = 0; c < wLen; c++) b[i++] = w[c]; @@ -116,7 +116,7 @@ class Stemmer private final boolean cons(int i) { switch (b[i]) { case 'a': case 'e': case 'i': case 'o': case 'u': return false; - case 'y': return (i==0) ? true : !cons(i-1); + case 'y': return (i == 0) || !cons(i - 1); default: return true; } } @@ -368,7 +368,7 @@ class Stemmer public static String StemString( String inputStr, int maxLength ) { - String outputStr=""; + StringBuilder outputStr= new StringBuilder(); int previousCh=0; char[] w = new char[maxLength]; @@ -396,19 +396,19 @@ class Stemmer { String u; u = s.toString(); - outputStr += u; + outputStr.append(u); if ( ch == '-' ) { // replace - with space - outputStr += " "; + outputStr.append(" "); } else if ( ch == '.' ) { if ( Character.isDigit( (char) previousCh )) { - outputStr += "."; + outputStr.append("."); } else { - outputStr += " "; + outputStr.append(" "); //previousCh = 32; // set to whitespace; extra spaces should be filtered out on next pass } } else { Character Ch = new Character((char) ch); - outputStr += Ch.toString(); + outputStr.append(Ch.toString()); } stemmerInputBufferIndex=0; // to avoid repeats after ) } @@ -422,7 +422,7 @@ class Stemmer if ( !Character.isWhitespace((char) previousCh ) ) { if ( previousCh != '.' ) { Character Ch = new Character((char) ch); - outputStr += Ch.toString(); + outputStr.append(Ch.toString()); } } } else if ( ch == '(' ) { // open paren; copy all characters until close paren @@ -449,21 +449,21 @@ class Stemmer stemmerInputBufferIndex=0; } else if ( ch == ')' ) { // when is last character of input string Character Ch = new Character((char) ch); - outputStr += Ch.toString(); + outputStr.append(Ch.toString()); log.trace( Ch.toString() ); log.trace("found close paren at position: " + inputArrayIndex + " of input term " + inputStr ); } else if ( ch == '-' ) { // replace - with space - outputStr += " "; + outputStr.append(" "); } else if ( ch == '.' ) { if ( Character.isDigit( (char) previousCh )) { - outputStr += "."; + outputStr.append("."); } else { - outputStr += " "; + outputStr.append(" "); //previousCh = 32; // set to whitespace; extra spaces should be filtered out on next pass } } else { Character Ch = new Character((char) ch); - outputStr += Ch.toString(); + outputStr.append(Ch.toString()); } previousCh = ch; if (ch < 0) break; @@ -477,10 +477,10 @@ class Stemmer String u; u = s.toString(); - outputStr += u; + outputStr.append(u); } - return outputStr == null ? ( outputStr.equals("") ? null : outputStr.trim() ) : outputStr.trim(); + return outputStr == null || outputStr.length() == 0 ? null : outputStr.toString().trim(); } /* diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/validator/impl/EnumValuesValidator.java b/api/src/main/java/edu/cornell/mannlib/vedit/validator/impl/EnumValuesValidator.java index 71e20112c..05b7ccacb 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/validator/impl/EnumValuesValidator.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/validator/impl/EnumValuesValidator.java @@ -3,6 +3,8 @@ package edu.cornell.mannlib.vedit.validator.impl; import edu.cornell.mannlib.vedit.validator.*; + +import java.util.Collections; import java.util.HashSet; import java.util.Iterator; @@ -17,17 +19,17 @@ public class EnumValuesValidator implements Validator { } else { vo.setValid(false); if (legalValues.size()<7){ - String msgString = "Please enter one of "; + StringBuilder msgString = new StringBuilder("Please enter one of "); Iterator valuesIt = legalValues.iterator(); while (valuesIt.hasNext()) { String legalValue = (String) valuesIt.next(); - msgString += "'"+legalValue+"'"; + msgString.append("'").append(legalValue).append("'"); if (valuesIt.hasNext()) - msgString += ", "; + msgString.append(", "); else - msgString += "."; + msgString.append("."); } - vo.setMessage(msgString); + vo.setMessage(msgString.toString()); } else { vo.setMessage("Please enter a legal value."); @@ -38,7 +40,6 @@ public class EnumValuesValidator implements Validator { } public EnumValuesValidator (String[] legalValues){ - for (int i=0; i violIt = iri.violations(false); while(violIt.hasNext()) { - errorStr += violIt.next().getShortMessage() + " "; + errorStr.append(violIt.next().getShortMessage()).append(" "); } vo.setValid(false); vo.setMessage("Please enter a valid URL. " + errorStr); diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/application/VitroHomeDirectory.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/application/VitroHomeDirectory.java index 7b1ad8788..06513cdfb 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/application/VitroHomeDirectory.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/application/VitroHomeDirectory.java @@ -159,8 +159,8 @@ public class VitroHomeDirectory { VHD_BUILD_PROPERTY); throw new IllegalStateException(message); } else if (foundLocations.size() > 1) { - String message = String.format("Found multiple values for the " - + "Vitro home directory: " + foundLocations); + String message = "Found multiple values for the " + + "Vitro home directory: " + foundLocations; log.warn(message); } } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/policy/bean/PropertyRestrictionBeanImpl.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/policy/bean/PropertyRestrictionBeanImpl.java index 5fed6daf3..0ddbb5ee7 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/policy/bean/PropertyRestrictionBeanImpl.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/policy/bean/PropertyRestrictionBeanImpl.java @@ -145,11 +145,8 @@ public class PropertyRestrictionBeanImpl extends PropertyRestrictionBean { if (resourceUri == null || userRole == null) { return false; } - if (prohibitedNamespaces.contains(namespace(resourceUri)) - && !permittedExceptions.contains(resourceUri)) { - return false; - } - return true; + return !prohibitedNamespaces.contains(namespace(resourceUri)) + || permittedExceptions.contains(resourceUri); } @Override @@ -241,9 +238,7 @@ public class PropertyRestrictionBeanImpl extends PropertyRestrictionBean { StringBuilder buffer = new StringBuilder(); for (FullPropertyKey key : keys) { - buffer.append(key + " " + thresholdMap.get(key).getLevel(DISPLAY) - + " " + thresholdMap.get(key).getLevel(MODIFY) + " " - + thresholdMap.get(key).getLevel(PUBLISH) + "\n"); + buffer.append(key).append(" ").append(thresholdMap.get(key).getLevel(DISPLAY)).append(" ").append(thresholdMap.get(key).getLevel(MODIFY)).append(" ").append(thresholdMap.get(key).getLevel(PUBLISH)).append("\n"); } return buffer.toString(); diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/requestedAction/publish/PublishObjectPropertyStatement.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/requestedAction/publish/PublishObjectPropertyStatement.java index bd5fcbbe0..cf593284f 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/requestedAction/publish/PublishObjectPropertyStatement.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/auth/requestedAction/publish/PublishObjectPropertyStatement.java @@ -6,7 +6,6 @@ import static edu.cornell.mannlib.vitro.webapp.auth.requestedAction.RequestedAct import org.apache.jena.ontology.OntModel; -import edu.cornell.mannlib.vitro.webapp.auth.requestedAction.RequestedAction; import edu.cornell.mannlib.vitro.webapp.auth.requestedAction.propstmt.AbstractObjectPropertyStatementAction; import edu.cornell.mannlib.vitro.webapp.beans.Property; diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ApplicationBean.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ApplicationBean.java index 5e6c100df..c3d51788c 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ApplicationBean.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ApplicationBean.java @@ -7,8 +7,6 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; -import javax.servlet.ServletContext; - import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyComparator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyComparator.java index fa285934c..642ee49d8 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyComparator.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyComparator.java @@ -51,7 +51,7 @@ public class DataPropertyComparator implements Comparator { if (XSD.xint.toString().equals(datatype)) { int i1 = Integer.valueOf(dps1.getData()); int i2 = Integer.valueOf(dps2.getData()); - result = ((Integer) i1).compareTo(i2); + result = Integer.compare(i1, i2); } else if (XSD.xstring.toString().equals(datatype)) { result = dps1.getData().compareTo(dps2.getData()); diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatement.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatement.java index c8fcb499b..4e1e95b70 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatement.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatement.java @@ -2,10 +2,6 @@ package edu.cornell.mannlib.vitro.webapp.beans; -import java.util.Date; - -import org.apache.jena.rdf.model.Property; - /** * a class representing a particular instance of a data property * diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatementImpl.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatementImpl.java index 2ede77d2b..98768ea56 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatementImpl.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/DataPropertyStatementImpl.java @@ -2,8 +2,6 @@ package edu.cornell.mannlib.vitro.webapp.beans; -import java.util.Date; - /** * a class representing an particular instance of a data property * diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ObjectProperty.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ObjectProperty.java index c1f1649d4..ffc42cf14 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ObjectProperty.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/ObjectProperty.java @@ -576,16 +576,16 @@ public class ObjectProperty extends Property implements Comparable getPermissionUris() { diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstance.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstance.java index 2b02301ce..61b0600e3 100755 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstance.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstance.java @@ -2,8 +2,6 @@ package edu.cornell.mannlib.vitro.webapp.beans; -import java.util.Date; - /** Represents a Vitro object property instance. It includes values from the entities, object property statements, properties, and ent2relationships tables diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstanceIface.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstanceIface.java index 603c2523c..19e53d2e8 100755 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstanceIface.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/beans/PropertyInstanceIface.java @@ -2,8 +2,6 @@ package edu.cornell.mannlib.vitro.webapp.beans; -import java.util.Date; - public interface PropertyInstanceIface { //needed for PropertyInstance //object property statements diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/config/ConfigurationPropertiesSmokeTests.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/config/ConfigurationPropertiesSmokeTests.java index dfaef633f..e5d92aeeb 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/config/ConfigurationPropertiesSmokeTests.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/config/ConfigurationPropertiesSmokeTests.java @@ -2,7 +2,6 @@ package edu.cornell.mannlib.vitro.webapp.config; -import java.io.File; import java.net.URI; import java.net.URISyntaxException; diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/MailUsersServlet.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/MailUsersServlet.java index 612dc6203..9163f571f 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/MailUsersServlet.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/MailUsersServlet.java @@ -104,30 +104,30 @@ public class MailUsersServlet extends VitroHttpServlet { comments=comments.trim(); //Removed spam filtering code - StringBuffer msgBuf = new StringBuffer(); // contains the intro copy for the body of the email message + StringBuilder msgBuf = new StringBuilder(); // contains the intro copy for the body of the email message String lineSeparator = System.getProperty("line.separator"); // \r\n on windows, \n on unix // from MyLibrary msgBuf.setLength(0); //msgBuf.append("Content-Type: text/html; charset='us-ascii'" + lineSeparator); - msgBuf.append("" + lineSeparator ); - msgBuf.append("" + lineSeparator ); - msgBuf.append("" + lineSeparator ); - msgBuf.append("" + deliveryfrom + "" + lineSeparator ); - msgBuf.append("" + lineSeparator ); - msgBuf.append("" + lineSeparator ); - msgBuf.append("

" + deliveryfrom + "

" + lineSeparator ); - msgBuf.append("

From: "+webusername +" (" + webuseremail + ")"+" at IP address "+request.getRemoteAddr()+"

"+lineSeparator); + msgBuf.append("").append(lineSeparator); + msgBuf.append("").append(lineSeparator); + msgBuf.append("").append(lineSeparator); + msgBuf.append("").append(deliveryfrom).append("").append(lineSeparator); + msgBuf.append("").append(lineSeparator); + msgBuf.append("").append(lineSeparator); + msgBuf.append("

").append(deliveryfrom).append("

").append(lineSeparator); + msgBuf.append("

From: ").append(webusername).append(" (").append(webuseremail).append(")").append(" at IP address ").append(request.getRemoteAddr()).append("

").append(lineSeparator); //Don't need any 'likely viewing page' portion to be emailed out to the others - msgBuf.append(lineSeparator + "

Comments:

" + lineSeparator ); + msgBuf.append(lineSeparator).append("

Comments:

").append(lineSeparator); if (comments==null || comments.equals("")) { msgBuf.append("

BLANK MESSAGE

"); } else { - msgBuf.append("

"+comments+"

"); + msgBuf.append("

").append(comments).append("

"); } - msgBuf.append("" + lineSeparator ); - msgBuf.append("" + lineSeparator ); + msgBuf.append("").append(lineSeparator); + msgBuf.append("").append(lineSeparator); String msgText = msgBuf.toString(); diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/OntologyController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/OntologyController.java index ce3cd1c64..58b859a77 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/OntologyController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/OntologyController.java @@ -58,8 +58,7 @@ public class OntologyController extends VitroHttpServlet{ if( rdfFormat != null ){ doRdf(req, res, rdfFormat ); - return; - } + } } private static Pattern RDF_REQUEST = Pattern.compile("^/ontology/([^/]*)/([^/]*).rdf$"); @@ -159,8 +158,7 @@ public class OntologyController extends VitroHttpServlet{ if( ! found ){ //respond to HTTP outside of critical section doNotFound(req,res); - return; - } else { + } else { JenaOutputUtils.setNameSpacePrefixes(newModel,vreq.getWebappDaoFactory()); res.setContentType(rdfFormat.getMediaType()); String format = ""; @@ -171,8 +169,7 @@ public class OntologyController extends VitroHttpServlet{ else if ( TTL_MIMETYPE.equals(rdfFormat.getMediaType())) format ="TTL"; - newModel.write( res.getOutputStream(), format ); - return; + newModel.write( res.getOutputStream(), format ); } } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/SparqlQueryBuilderServlet.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/SparqlQueryBuilderServlet.java index acf738b3d..89b60a12b 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/SparqlQueryBuilderServlet.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/SparqlQueryBuilderServlet.java @@ -87,7 +87,6 @@ public class SparqlQueryBuilderServlet extends BaseEditController { } doHelp(request,response); - return; } private void doNoModelInContext(HttpServletRequest request, HttpServletResponse res){ diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/admin/UserAccountsEditPage.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/admin/UserAccountsEditPage.java index 840e690ac..42dd4102d 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/admin/UserAccountsEditPage.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/admin/UserAccountsEditPage.java @@ -127,8 +127,7 @@ public class UserAccountsEditPage extends UserAccountsPage { + "but is not authorized to do so. Logged in as: " + LoginStatusBean.getCurrentUser(vreq)); bogusMessage = getBogusStandardMessage(vreq); - return; - } + } } } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsFirstTimeExternalPage.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsFirstTimeExternalPage.java index 4503947dc..55e860670 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsFirstTimeExternalPage.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsFirstTimeExternalPage.java @@ -126,8 +126,7 @@ public class UserAccountsFirstTimeExternalPage extends UserAccountsPage { } if (!Authenticator.getInstance(vreq).isUserPermittedToLogin(null)) { bogusMessage = i18n.text("logins_disabled_for_maintenance"); - return; - } + } } public boolean isBogus() { diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsPasswordBasePage.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsPasswordBasePage.java index 9a471b4bb..3923c17b2 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsPasswordBasePage.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/accounts/user/UserAccountsPasswordBasePage.java @@ -121,8 +121,7 @@ public abstract class UserAccountsPasswordBasePage extends UserAccountsPage { + "' when already logged in as '" + currentUserEmail + "'"); bogusMessage = alreadyLoggedInMessage(currentUserEmail); - return; - } + } } } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/ajax/SparqlQueryAjaxController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/ajax/SparqlQueryAjaxController.java index 03fbc4f5a..93a8ff861 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/ajax/SparqlQueryAjaxController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/ajax/SparqlQueryAjaxController.java @@ -61,8 +61,7 @@ public class SparqlQueryAjaxController extends VitroAjaxController { String queryParam = locateQueryParam(vreq); Query query = SparqlUtils.createQuery(queryParam); SparqlUtils.executeQuery(response, query, model); - return; - } catch (AjaxControllerException e) { + } catch (AjaxControllerException e) { log.error(e.getMessage()); response.sendError(e.getStatusCode()); } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/SparqlUpdateApiController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/SparqlUpdateApiController.java index 682d73281..528217e95 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/SparqlUpdateApiController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/SparqlUpdateApiController.java @@ -9,7 +9,6 @@ import static javax.servlet.http.HttpServletResponse.SC_OK; import java.io.IOException; -import javax.servlet.ServletContext; import javax.servlet.ServletException; import javax.servlet.annotation.WebServlet; import javax.servlet.http.HttpServletRequest; diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/sparqlquery/SparqlQueryApiRdfProducer.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/sparqlquery/SparqlQueryApiRdfProducer.java index 1a24e5020..0168294d8 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/sparqlquery/SparqlQueryApiRdfProducer.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/api/sparqlquery/SparqlQueryApiRdfProducer.java @@ -5,7 +5,6 @@ package edu.cornell.mannlib.vitro.webapp.controller.api.sparqlquery; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; -import java.io.OutputStreamWriter; import java.util.Collection; import org.apache.commons.io.IOUtils; diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/Authenticator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/Authenticator.java index bf5aae3e5..76bc3bc20 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/Authenticator.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/Authenticator.java @@ -197,11 +197,7 @@ public abstract class Authenticator { // InternetAddress permits a localname without hostname. // Guard against that. - if (emailAddress.indexOf('@') == -1) { - return false; - } - - return true; + return emailAddress.indexOf('@') != -1; } catch (AddressException e) { return false; } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/LoginExternalAuthReturn.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/LoginExternalAuthReturn.java index 1db8c4c16..153520974 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/LoginExternalAuthReturn.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/LoginExternalAuthReturn.java @@ -104,14 +104,12 @@ public class LoginExternalAuthReturn extends BaseLoginServlet { getAuthenticator(req).recordLoginAgainstUserAccount(userAccount, AuthenticationSource.EXTERNAL); new LoginRedirector(req, afterLoginUrl).redirectLoggedInUser(resp); - return; - } catch (LoginNotPermitted e) { + } catch (LoginNotPermitted e) { // should have been caught by isUserPermittedToLogin() log.debug("Logins disabled for " + userAccount); complainAndReturnToReferrer(req, resp, ATTRIBUTE_REFERRER, messageLoginDisabled(req)); - return; - } + } } @Override diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java index 1c775f1a0..d6f1c15d4 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java @@ -144,8 +144,7 @@ public class ProgramLogin extends HttpServlet { } recordLoginWithPasswordChange(); sendSuccess(MESSAGE_SUCCESS_FIRST_TIME); - return; - } + } } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/DumpRestoreController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/DumpRestoreController.java index 45fabe992..6b1ef67f6 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/DumpRestoreController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/DumpRestoreController.java @@ -3,7 +3,6 @@ package edu.cornell.mannlib.vitro.webapp.controller.datatools.dumprestore; import java.io.IOException; -import java.io.InputStream; import java.util.HashMap; import java.util.Map; @@ -22,7 +21,6 @@ import edu.cornell.mannlib.vitro.webapp.controller.freemarker.FreemarkerHttpServ import edu.cornell.mannlib.vitro.webapp.controller.freemarker.UrlBuilder; import edu.cornell.mannlib.vitro.webapp.controller.freemarker.responsevalues.ResponseValues; import edu.cornell.mannlib.vitro.webapp.controller.freemarker.responsevalues.TemplateResponseValues; -import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService.ResultFormat; import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFServiceException; /** diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/NQuadLineSplitter.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/NQuadLineSplitter.java index 580cd2635..7bff579c0 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/NQuadLineSplitter.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/datatools/dumprestore/NQuadLineSplitter.java @@ -95,11 +95,7 @@ class NQuadLineSplitter { while (!atEnd() && isWhiteSpace()) { i++; } - if (atEnd()) { - return; - } else if (line.charAt(i) == '#') { - return; - } else { + if (!atEnd() && line.charAt(i) != '#') { throw new BadNodeException( "Period was not followed by end of line: '" + line + "'"); } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java index da38df6a4..c1752f327 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java @@ -351,8 +351,7 @@ public class Authenticate extends VitroHttpServlet { // This should have been caught by isUserPermittedToLogin() bean.setMessage(request, ERROR, "logins_disabled_for_maintenance"); - return; - } + } } } @@ -413,8 +412,7 @@ public class Authenticate extends VitroHttpServlet { } catch (LoginNotPermitted e) { // This should have been caught by isUserPermittedToLogin() bean.setMessage(request, ERROR, "logins_disabled_for_maintenance"); - return; - } + } } /** @@ -497,8 +495,7 @@ public class Authenticate extends VitroHttpServlet { String loginProcessPage = LoginProcessBean.getBean(vreq) .getLoginPageUrl(); response.sendRedirect(loginProcessPage); - return; - } + } /** * Exit: user has completed the login. Redirect appropriately and clear the diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Classes2ClassesOperationController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Classes2ClassesOperationController.java index 7f8310d4e..026a55476 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Classes2ClassesOperationController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Classes2ClassesOperationController.java @@ -73,16 +73,20 @@ public class Classes2ClassesOperationController extends BaseEditController { String superclassURIstr = request.getParameter("SuperclassURI"); if (superclassURIstr != null) { for (int i=0; i classList = inferredEnt.getVClasses(false); sortForPickList(classList, vreq); if (classList != null) { @@ -109,13 +109,13 @@ public class EntityEditController extends BaseEditController { } catch (Exception e) { rClassName = vc.getLocalNameWithPrefix(); } - classStr += rClassName; + classStr.append(rClassName); if (classIt.hasNext()) { - classStr += ", "; + classStr.append(", "); } } } - results.add(classStr); + results.add(classStr.toString()); results.add(ent.getHiddenFromDisplayBelowRoleLevel() == null ? "unspecified" : ent.getHiddenFromDisplayBelowRoleLevel().getDisplayLabel()); @@ -147,7 +147,7 @@ public class EntityEditController extends BaseEditController { Iterator externalIdIt = ent.getExternalIds().iterator(); while (externalIdIt.hasNext()) { DataPropertyStatement eid = externalIdIt.next(); - String multiplexedString = new String ("DatapropURI:" + new String(Base64.encodeBase64(eid.getDatapropURI().getBytes())) + ";" + "Data:" + new String(Base64.encodeBase64(eid.getData().getBytes()))); + String multiplexedString = "DatapropURI:" + new String(Base64.encodeBase64(eid.getDatapropURI().getBytes())) + ";" + "Data:" + new String(Base64.encodeBase64(eid.getData().getBytes())); externalIdOptionList.add(new Option(multiplexedString, eid.getData())); } } @@ -172,7 +172,7 @@ public class EntityEditController extends BaseEditController { Iterator epiIt = epiColl.iterator(); while (epiIt.hasNext()) { PropertyInstance pi = epiIt.next(); - String multiplexedString = new String ("PropertyURI:" + new String(Base64.encodeBase64(pi.getPropertyURI().getBytes())) + ";" + "ObjectEntURI:" + new String(Base64.encodeBase64(pi.getObjectEntURI().getBytes()))); + String multiplexedString = "PropertyURI:" + new String(Base64.encodeBase64(pi.getPropertyURI().getBytes())) + ";" + "ObjectEntURI:" + new String(Base64.encodeBase64(pi.getObjectEntURI().getBytes())); epiOptionList.add(new Option(multiplexedString, pi.getDomainPublic()+" "+pi.getObjectName())); } OptionMap.put("ExistingPropertyInstances", epiOptionList); diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Properties2PropertiesOperationController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Properties2PropertiesOperationController.java index 166a89b4e..93fd5723a 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Properties2PropertiesOperationController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/Properties2PropertiesOperationController.java @@ -102,14 +102,11 @@ public class Properties2PropertiesOperationController extends } } - } catch (RuntimeException e) { + } catch (RuntimeException | Error e) { log.error("Unable to perform edit operation: ", e); throw e; - } catch (Error err) { - log.error("Unable to perform edit operation: ", err); - throw err; } - + } public void doGet(HttpServletRequest request, HttpServletResponse response) { diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyGroupRetryController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyGroupRetryController.java index bd89deab9..d12316fe5 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyGroupRetryController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyGroupRetryController.java @@ -67,7 +67,7 @@ public class PropertyGroupRetryController extends BaseEditController { } if (propertyGroupForEditing == null) { // UTF-8 expected due to URIEncoding on Connector element in server.xml - String uriToFind = new String(request.getParameter("uri")); + String uriToFind = request.getParameter("uri"); propertyGroupForEditing = (PropertyGroup)pgDao.getGroupByURI(uriToFind); } } else { diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorOperationController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorOperationController.java index c8b212faf..a4e1f97bb 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorOperationController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorOperationController.java @@ -492,14 +492,18 @@ public class RefactorOperationController extends BaseEditController { if (vreq.getParameter("_cancel") == null) { if (modeStr != null) { - - if (modeStr.equals("renameResource")) { - redirectStr = doRenameResource(vreq, response, epo); - } else if (modeStr.equals("movePropertyStatements")) { - doMovePropertyStatements(vreq, response, epo); - } else if (modeStr.equals("moveInstances")) { - doMoveInstances(vreq, response, epo); - } + + switch (modeStr) { + case "renameResource": + redirectStr = doRenameResource(vreq, response, epo); + break; + case "movePropertyStatements": + doMovePropertyStatements(vreq, response, epo); + break; + case "moveInstances": + doMoveInstances(vreq, response, epo); + break; + } } } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorRetryController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorRetryController.java index 391ba55f4..8fb612d77 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorRetryController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RefactorRetryController.java @@ -108,13 +108,17 @@ public class RefactorRetryController extends BaseEditController { String modeStr = request.getParameter("mode"); if (modeStr != null) { - if (modeStr.equals("renameResource")) { - doRenameResource(vreq, response, epo); - } else if (modeStr.equals("movePropertyStatements")) { - doMovePropertyStatements(vreq, response, epo); - } else if (modeStr.equals("moveInstances")) { - doMoveInstances(vreq, response, epo); - } + switch (modeStr) { + case "renameResource": + doRenameResource(vreq, response, epo); + break; + case "movePropertyStatements": + doMovePropertyStatements(vreq, response, epo); + break; + case "moveInstances": + doMoveInstances(vreq, response, epo); + break; + } } setRequestAttributes(request,epo); diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionOperationController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionOperationController.java index f9c51db71..1fbefad91 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionOperationController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionOperationController.java @@ -83,8 +83,7 @@ public class RestrictionOperationController extends BaseEditController { log.error(e, e); try { response.sendRedirect(defaultLandingPage); - return; - } catch (Exception f) { + } catch (Exception f) { log.error(f, f); throw new RuntimeException(f); } @@ -176,47 +175,54 @@ public class RestrictionOperationController extends BaseEditController { if (cardinalityStr != null) { cardinality = Integer.decode(cardinalityStr); } - - if (restrictionTypeStr.equals("allValuesFrom")) { - rest = ontModel.createAllValuesFromRestriction(null,onProperty,roleFiller); - } else if (restrictionTypeStr.equals("someValuesFrom")) { - rest = ontModel.createSomeValuesFromRestriction(null,onProperty,roleFiller); - } else if (restrictionTypeStr.equals("hasValue")) { - String valueURI = request.getParameter("ValueIndividual"); - if (valueURI != null) { - Resource valueRes = ontModel.getResource(valueURI); - if (valueRes != null) { - rest = ontModel.createHasValueRestriction(null, onProperty, valueRes); - } - } else { - String valueLexicalForm = request.getParameter("ValueLexicalForm"); - if (valueLexicalForm != null) { - String valueDatatype = request.getParameter("ValueDatatype"); - Literal value = null; - if (valueDatatype != null && valueDatatype.length() > 0) { - RDFDatatype dtype = null; - try { - dtype = TypeMapper.getInstance().getSafeTypeByName(valueDatatype); - } catch (Exception e) { - log.warn ("Unable to get safe type " + valueDatatype + " using TypeMapper"); - } - if (dtype != null) { - value = ontModel.createTypedLiteral(valueLexicalForm, dtype); + + switch (restrictionTypeStr) { + case "allValuesFrom": + rest = ontModel.createAllValuesFromRestriction(null, onProperty, roleFiller); + break; + case "someValuesFrom": + rest = ontModel.createSomeValuesFromRestriction(null, onProperty, roleFiller); + break; + case "hasValue": + String valueURI = request.getParameter("ValueIndividual"); + if (valueURI != null) { + Resource valueRes = ontModel.getResource(valueURI); + if (valueRes != null) { + rest = ontModel.createHasValueRestriction(null, onProperty, valueRes); + } + } else { + String valueLexicalForm = request.getParameter("ValueLexicalForm"); + if (valueLexicalForm != null) { + String valueDatatype = request.getParameter("ValueDatatype"); + Literal value = null; + if (valueDatatype != null && valueDatatype.length() > 0) { + RDFDatatype dtype = null; + try { + dtype = TypeMapper.getInstance().getSafeTypeByName(valueDatatype); + } catch (Exception e) { + log.warn("Unable to get safe type " + valueDatatype + " using TypeMapper"); + } + if (dtype != null) { + value = ontModel.createTypedLiteral(valueLexicalForm, dtype); + } else { + value = ontModel.createLiteral(valueLexicalForm); + } } else { value = ontModel.createLiteral(valueLexicalForm); } - } else { - value = ontModel.createLiteral(valueLexicalForm); + rest = ontModel.createHasValueRestriction(null, onProperty, value); } - rest = ontModel.createHasValueRestriction(null, onProperty, value); } - } - } else if (restrictionTypeStr.equals("minCardinality")) { - rest = ontModel.createMinCardinalityRestriction(null,onProperty,cardinality); - } else if (restrictionTypeStr.equals("maxCardinality")) { - rest = ontModel.createMaxCardinalityRestriction(null,onProperty,cardinality); - } else if (restrictionTypeStr.equals("cardinality")) { - rest = ontModel.createCardinalityRestriction(null,onProperty,cardinality); + break; + case "minCardinality": + rest = ontModel.createMinCardinalityRestriction(null, onProperty, cardinality); + break; + case "maxCardinality": + rest = ontModel.createMaxCardinalityRestriction(null, onProperty, cardinality); + break; + case "cardinality": + rest = ontModel.createCardinalityRestriction(null, onProperty, cardinality); + break; } if (conditionTypeStr.equals("necessary")) { diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionRetryController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionRetryController.java index 79438c49b..ec6d6e6ba 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionRetryController.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/edit/RestrictionRetryController.java @@ -66,29 +66,38 @@ public class RestrictionRetryController extends BaseEditController { epo.setFormObject(new FormObject()); epo.getFormObject().getOptionLists().put("onProperty", onPropertyList); - - if (restrictionTypeStr.equals("someValuesFrom")) { - request.setAttribute("specificRestrictionForm","someValuesFromRestriction_retry.jsp"); - List