)lvl2ClassPropertiesMap.get(vc);
for (DataProperty prop: vcProps) {
- String nameStr = prop.getPublicName()==null ? prop.getName()==null ? null : prop.getName() : prop.getPublicName();
+ String nameStr = prop.getPublicName()==null ? prop.getName() : prop.getPublicName();
// top level
ObjectNode propertiesItemJson = JsonNodeFactory.instance.objectNode();
@@ -222,7 +222,7 @@ public class GrefinePropertyListServlet extends VitroHttpServlet {
Collections.sort(props);
for (DataProperty prop: props) {
- String nameStr = prop.getPublicName()==null ? prop.getName()==null ? null : prop.getName() : prop.getPublicName();
+ String nameStr = prop.getPublicName()==null ? prop.getName() : prop.getPublicName();
if (nameStr != null) {
if (prop.getDomainClassURI() != null) {
VClass vc = vcDao.getVClassByURI(prop.getDomainClassURI());
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/grefine/JSONReconcileServlet.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/grefine/JSONReconcileServlet.java
index 5aeeb440f..ad175f1f2 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/grefine/JSONReconcileServlet.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/grefine/JSONReconcileServlet.java
@@ -198,10 +198,10 @@ public class JSONReconcileServlet extends VitroHttpServlet {
json.put("schemaSpace", defaultNamespace);
}
ObjectNode viewJson = JsonNodeFactory.instance.objectNode();
- StringBuffer urlBuf = new StringBuffer();
- urlBuf.append("http://" + serverName);
+ StringBuilder urlBuf = new StringBuilder();
+ urlBuf.append("http://").append(serverName);
if (serverPort == 8080) {
- urlBuf.append(":" + serverPort);
+ urlBuf.append(":").append(serverPort);
}
if (req.getContextPath() != null) {
urlBuf.append(req.getContextPath());
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualResponseBuilder.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualResponseBuilder.java
index 6cc9096fc..8133f6bb8 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualResponseBuilder.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individual/IndividualResponseBuilder.java
@@ -265,18 +265,18 @@ class IndividualResponseBuilder {
- Much simpler is to just create an anchor element. This has the added advantage that the
browser doesn't ask to resend the form data when reloading the page.
*/
- String url = vreq.getRequestURI() + "?verbose=" + !verboseValue;
+ StringBuilder url = new StringBuilder(vreq.getRequestURI() + "?verbose=" + !verboseValue);
// Append request query string, except for current verbose value, to url
String queryString = vreq.getQueryString();
if (queryString != null) {
String[] params = queryString.split("&");
for (String param : params) {
if (! param.startsWith("verbose=")) {
- url += "&" + param;
+ url.append("&").append(param);
}
}
}
- map.put("url", url);
+ map.put("url", url.toString());
} else {
vreq.getSession().setAttribute("verbosePropertyDisplay", false);
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualJsonWrapper.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualJsonWrapper.java
index 314506cb3..2b3d6eaec 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualJsonWrapper.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualJsonWrapper.java
@@ -5,7 +5,6 @@ package edu.cornell.mannlib.vitro.webapp.controller.individuallist;
import java.util.Collection;
import java.util.Map;
-import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.JsonNodeFactory;
import com.fasterxml.jackson.databind.node.ObjectNode;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualListResultsUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualListResultsUtils.java
index b25e95e66..35f52f35b 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualListResultsUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/individuallist/IndividualListResultsUtils.java
@@ -8,7 +8,6 @@ import java.util.ArrayList;
import java.util.List;
import java.util.Map;
-import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.JsonNodeFactory;
import com.fasterxml.jackson.databind.node.ObjectNode;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaAdminActions.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaAdminActions.java
index 3273ed93f..126ac767d 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaAdminActions.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaAdminActions.java
@@ -163,7 +163,7 @@ public class JenaAdminActions extends BaseEditController {
}
private String testWriteXML() {
- StringBuffer output = new StringBuffer();
+ StringBuilder output = new StringBuilder();
output.append("Test Write XML\n");
OntModel model = ModelAccess.on(getServletContext()).getOntModel();
Model tmp = ModelFactory.createDefaultModel();
@@ -177,10 +177,10 @@ public class JenaAdminActions extends BaseEditController {
valid = false;
output.append("-----\n");
output.append("Unable to write statement as RDF/XML:\n");
- output.append("Subject : \n"+stmt.getSubject().getURI());
- output.append("Subject : \n"+stmt.getPredicate().getURI());
+ output.append("Subject : \n").append(stmt.getSubject().getURI());
+ output.append("Subject : \n").append(stmt.getPredicate().getURI());
String objectStr = (stmt.getObject().isLiteral()) ? ((Literal)stmt.getObject()).getLexicalForm() : ((Resource)stmt.getObject()).getURI();
- output.append("Subject : \n"+objectStr);
+ output.append("Subject : \n").append(objectStr);
output.append("Exception: \n");
e.printStackTrace();
}
@@ -250,16 +250,20 @@ public class JenaAdminActions extends BaseEditController {
VitroRequest request = new VitroRequest(req);
String actionStr = request.getParameter("action");
- if (actionStr.equals("printRestrictions")) {
- printRestrictions();
- } else if (actionStr.equals("outputTbox")) {
- outputTbox(response);
- } else if (actionStr.equals("testWriteXML")) {
- try {
- response.getWriter().write(testWriteXML());
- } catch ( IOException ioe ) {
- throw new RuntimeException( ioe );
- }
+ switch (actionStr) {
+ case "printRestrictions":
+ printRestrictions();
+ break;
+ case "outputTbox":
+ outputTbox(response);
+ break;
+ case "testWriteXML":
+ try {
+ response.getWriter().write(testWriteXML());
+ } catch (IOException ioe) {
+ throw new RuntimeException(ioe);
+ }
+ break;
}
if (actionStr.equals("checkURIs")) {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaCsv2RdfController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaCsv2RdfController.java
index d8a1f9099..2b7a8b6d3 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaCsv2RdfController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaCsv2RdfController.java
@@ -139,7 +139,6 @@ public class JenaCsv2RdfController extends JenaIngestController {
log.error(e1);
throw new ServletException(e1);
}
- return;
}
public Model doExecuteCsv2Rdf(VitroRequest vreq, FileItem fileStream, String filePath) throws Exception {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaExportController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaExportController.java
index 0edc02bbd..d132585fe 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaExportController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaExportController.java
@@ -106,7 +106,7 @@ public class JenaExportController extends BaseEditController {
String formatParam = vreq.getParameter("format");
String subgraphParam = vreq.getParameter("subgraph");
String assertedOrInferredParam = vreq.getParameter("assertedOrInferred");
- String ontologyURI = vreq.getParameter("ontologyURI");
+ StringBuilder ontologyURI = new StringBuilder(vreq.getParameter("ontologyURI"));
Model model = null;
OntModel ontModel = ModelFactory.createOntologyModel();
@@ -114,12 +114,13 @@ public class JenaExportController extends BaseEditController {
if(!subgraphParam.equalsIgnoreCase("tbox")
&& !subgraphParam.equalsIgnoreCase("abox")
&& !subgraphParam.equalsIgnoreCase("full")){
- ontologyURI = subgraphParam;
+ ontologyURI = new StringBuilder(subgraphParam);
subgraphParam = "tbox";
- char[] uri = ontologyURI.toCharArray();
- ontologyURI="";
- for(int i =0; i < uri.length-1;i++)
- ontologyURI = ontologyURI + uri[i];
+ char[] uri = ontologyURI.toString().toCharArray();
+ ontologyURI = new StringBuilder();
+ for(int i =0; i < uri.length-1;i++) {
+ ontologyURI.append(uri[i]);
+ }
}
if( "abox".equals(subgraphParam)){
@@ -141,7 +142,7 @@ public class JenaExportController extends BaseEditController {
// only those statements that are in the inferred graph
Model tempModel = xutil.extractTBox(
ModelAccess.on(getServletContext()).getOntModel(TBOX_UNION),
- ontologyURI);
+ ontologyURI.toString());
Model inferenceModel = ModelAccess.on(getServletContext()).getOntModel(TBOX_INFERENCES);
inferenceModel.enterCriticalSection(Lock.READ);
try {
@@ -152,17 +153,17 @@ public class JenaExportController extends BaseEditController {
} else if ("full".equals(assertedOrInferredParam)) {
model = xutil.extractTBox(
ModelAccess.on(getServletContext()).getOntModel(TBOX_UNION),
- ontologyURI);
+ ontologyURI.toString());
} else {
model = xutil.extractTBox(
- ModelAccess.on(getServletContext()).getOntModel(TBOX_ASSERTIONS), ontologyURI);
+ ModelAccess.on(getServletContext()).getOntModel(TBOX_ASSERTIONS), ontologyURI.toString());
}
}
else if("full".equals(subgraphParam)){
if("inferred".equals(assertedOrInferredParam)){
ontModel = xutil.extractTBox(
- dataset, ontologyURI, ABOX_INFERENCES);
+ dataset, ontologyURI.toString(), ABOX_INFERENCES);
ontModel.addSubModel(ModelAccess.on(getServletContext()).getOntModel(ABOX_INFERENCES));
ontModel.addSubModel(ModelAccess.on(getServletContext()).getOntModel(TBOX_INFERENCES));
}
@@ -214,23 +215,31 @@ public class JenaExportController extends BaseEditController {
}
private void setHeaders(HttpServletResponse response, String formatParam) {
- if ( formatParam == null ) {
- formatParam = "RDF/XML-ABBREV"; // default
- }
- String mime = formatToMimetype.get( formatParam );
- if ( mime == null ) {
- throw new RuntimeException( "Unsupported RDF format " + formatParam);
- }
-
- response.setContentType( mime );
- if(mime.equals("application/rdf+xml"))
- response.setHeader("content-disposition", "attachment; filename=" + "export.rdf");
- else if(mime.equals("text/n3"))
- response.setHeader("content-disposition", "attachment; filename=" + "export.n3");
- else if(mime.equals("text/plain"))
- response.setHeader("content-disposition", "attachment; filename=" + "export.txt");
- else if(mime.equals("application/x-turtle"))
- response.setHeader("content-disposition", "attachment; filename=" + "export.ttl");
+ if ( formatParam == null ) {
+ formatParam = "RDF/XML-ABBREV"; // default
+ }
+
+ String mime = formatToMimetype.get( formatParam );
+ if ( mime == null ) {
+ throw new RuntimeException( "Unsupported RDF format " + formatParam);
+ }
+
+ response.setContentType( mime );
+
+ switch (mime) {
+ case "application/rdf+xml":
+ response.setHeader("content-disposition", "attachment; filename=" + "export.rdf");
+ break;
+ case "text/n3":
+ response.setHeader("content-disposition", "attachment; filename=" + "export.n3");
+ break;
+ case "text/plain":
+ response.setHeader("content-disposition", "attachment; filename=" + "export.txt");
+ break;
+ case "application/x-turtle":
+ response.setHeader("content-disposition", "attachment; filename=" + "export.ttl");
+ break;
+ }
}
private void outputSparqlConstruct(String queryStr, String formatParam,
@@ -248,10 +257,8 @@ public class JenaExportController extends BaseEditController {
IOUtils.copy(in, out);
out.flush();
out.close();
- } catch (RDFServiceException e) {
+ } catch (RDFServiceException | IOException e) {
throw new RuntimeException(e);
- } catch (IOException ioe) {
- throw new RuntimeException(ioe);
} finally {
rdfService.close();
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaIngestController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaIngestController.java
index e5dfac058..e615ba866 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaIngestController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/controller/jena/JenaIngestController.java
@@ -303,11 +303,11 @@ public class JenaIngestController extends BaseEditController {
} catch (org.apache.jena.shared.CannotEncodeCharacterException cece) {
// there's got to be a better way to do this
byte[] badCharBytes = String.valueOf(cece.getBadChar()).getBytes();
- String errorMsg = "Cannot encode character with byte values: (decimal) ";
+ StringBuilder errorMsg = new StringBuilder("Cannot encode character with byte values: (decimal) ");
for (int i=0; i outOProps = new ArrayList();
List oProps = _innerIndividual.getPopulatedObjectPropertyList();
for (ObjectProperty op: oProps) {
@@ -166,6 +168,7 @@ public class IndividualFiltering implements Individual {
}
}
return outOProps;
+*/
}
/* ********************* methods that need delegated filtering *************** */
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/ObjectPropertyStatementFiltering.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/ObjectPropertyStatementFiltering.java
index 57e1bc717..c1ddeb680 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/ObjectPropertyStatementFiltering.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/ObjectPropertyStatementFiltering.java
@@ -1,7 +1,6 @@
/* $This file is distributed under the terms of the license in LICENSE$ */
package edu.cornell.mannlib.vitro.webapp.dao.filtering;
-import java.util.Date;
import edu.cornell.mannlib.vitro.webapp.beans.Individual;
import edu.cornell.mannlib.vitro.webapp.beans.ObjectProperty;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/PropertyGroupDaoFiltering.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/PropertyGroupDaoFiltering.java
index 1cc60a71f..c01b1847a 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/PropertyGroupDaoFiltering.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/PropertyGroupDaoFiltering.java
@@ -2,17 +2,13 @@
package edu.cornell.mannlib.vitro.webapp.dao.filtering;
-import java.util.Collections;
import java.util.LinkedList;
import java.util.List;
-import net.sf.jga.algorithms.Filter;
-
import org.apache.jena.ontology.DatatypeProperty;
import edu.cornell.mannlib.vitro.webapp.beans.DataProperty;
import edu.cornell.mannlib.vitro.webapp.beans.ObjectProperty;
-import edu.cornell.mannlib.vitro.webapp.beans.ObjectPropertyStatement;
import edu.cornell.mannlib.vitro.webapp.beans.Property;
import edu.cornell.mannlib.vitro.webapp.beans.PropertyGroup;
import edu.cornell.mannlib.vitro.webapp.dao.PropertyGroupDao;
@@ -70,8 +66,7 @@ public class PropertyGroupDaoFiltering implements PropertyGroupDao {
}
grp.setPropertyList(filteredProps); //side effect
- return ;
- }
+ }
public List getPublicGroups(boolean withProperties) {
List groups = innerDao.getPublicGroups(withProperties);
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/VClassDaoFiltering.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/VClassDaoFiltering.java
index 3a1adeb9d..dfe50cf6d 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/VClassDaoFiltering.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/VClassDaoFiltering.java
@@ -223,7 +223,6 @@ public class VClassDaoFiltering extends BaseFiltering implements VClassDao{
if( out != null )
vclass.setEntityCount(out.size());
System.out.println(vclass.getURI() + " count: " + vclass.getEntityCount());
- return;
}
private List correctVClassCounts(List vclasses){
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/EntityPropertyListFilter.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/EntityPropertyListFilter.java
index 08d4e9fef..5c2193cc4 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/EntityPropertyListFilter.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/EntityPropertyListFilter.java
@@ -4,12 +4,10 @@ package edu.cornell.mannlib.vitro.webapp.dao.filtering.filters;
import java.util.Collection;
import java.util.HashMap;
-import java.util.HashSet;
import java.util.ArrayList;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
-import java.util.Set;
import net.sf.jga.fn.UnaryFunctor;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/VitroFiltersImpl.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/VitroFiltersImpl.java
index 4658086e6..376707416 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/VitroFiltersImpl.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/filtering/filters/VitroFiltersImpl.java
@@ -12,7 +12,6 @@ import edu.cornell.mannlib.vitro.webapp.beans.ObjectPropertyStatement;
import edu.cornell.mannlib.vitro.webapp.beans.PropertyGroup;
import edu.cornell.mannlib.vitro.webapp.beans.VClass;
import edu.cornell.mannlib.vitro.webapp.beans.VClassGroup;
-import edu.cornell.mannlib.vitro.webapp.web.templatemodels.User;
/**
* A object to hold all the filters commonly used by the vitro webapp.
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/DisplayModelDaoJena.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/DisplayModelDaoJena.java
index 7df2c09df..d9ecce8a1 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/DisplayModelDaoJena.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/DisplayModelDaoJena.java
@@ -104,7 +104,7 @@ public class DisplayModelDaoJena implements DisplayModelDao {
if( text == null ){
//text of file is not yet in model
File oldMenuFile = new File(context.getRealPath(MENU_N3_FILE));
- StringBuffer str = new StringBuffer(2000);
+ StringBuilder str = new StringBuilder(2000);
BufferedReader reader = new BufferedReader(new FileReader(oldMenuFile));
char[] buf = new char[1024];
int numRead=0;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoJena.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoJena.java
index 1c50aa665..c1acf746a 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoJena.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoJena.java
@@ -219,12 +219,12 @@ public class IndividualDaoJena extends JenaBaseDao implements IndividualDao {
ontModel.enterCriticalSection(Lock.WRITE);
try {
- entURI = new String(preferredURI);
+ entURI = preferredURI;
org.apache.jena.ontology.Individual test = ontModel.getIndividual(entURI);
int count = 0;
while (test != null) {
++count;
- entURI = new String(preferredURI) + count;
+ entURI = preferredURI + count;
test = ontModel.getIndividual(entURI);
}
@@ -677,7 +677,7 @@ public class IndividualDaoJena extends JenaBaseDao implements IndividualDao {
int attempts = 0;
- while( uriIsGood == false && attempts < 30 ){
+ while(!uriIsGood && attempts < 30 ){
log.debug("While loop: Uri is good false, attempt=" + attempts);
String localName = "n" + random.nextInt( Math.min(Integer.MAX_VALUE,(int)Math.pow(2,attempts + 13)) );
uri = namespace + localName;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoSDB.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoSDB.java
index 35c01ef77..cd186f019 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoSDB.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualDaoSDB.java
@@ -2,7 +2,6 @@
package edu.cornell.mannlib.vitro.webapp.dao.jena;
-import java.io.InputStream;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
@@ -28,7 +27,6 @@ import org.apache.jena.query.QueryExecutionFactory;
import org.apache.jena.query.QueryFactory;
import org.apache.jena.query.QuerySolution;
import org.apache.jena.query.ResultSet;
-import org.apache.jena.query.ResultSetFactory;
import org.apache.jena.rdf.model.AnonId;
import org.apache.jena.rdf.model.Literal;
import org.apache.jena.rdf.model.Property;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualSDB.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualSDB.java
index 18918ebd0..5cc27bd07 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualSDB.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/IndividualSDB.java
@@ -4,7 +4,6 @@ package edu.cornell.mannlib.vitro.webapp.dao.jena;
import static edu.cornell.mannlib.vitro.webapp.dao.jena.WebappDaoFactorySDB.SDBDatasetMode.ASSERTIONS_ONLY;
-import java.io.InputStream;
import java.sql.Timestamp;
import java.text.Collator;
import java.util.ArrayList;
@@ -17,7 +16,6 @@ import java.util.LinkedList;
import java.util.List;
import java.util.Map;
-import org.apache.jena.graph.NodeFactory;
import edu.cornell.mannlib.vitro.webapp.rdfservice.ResultSetConsumer;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -27,14 +25,11 @@ import org.apache.jena.ontology.OntModel;
import org.apache.jena.ontology.OntModelSpec;
import org.apache.jena.ontology.OntResource;
import org.apache.jena.query.Dataset;
-import org.apache.jena.query.Query;
import org.apache.jena.query.QueryExecution;
import org.apache.jena.query.QueryExecutionFactory;
import org.apache.jena.query.QueryFactory;
import org.apache.jena.query.QuerySolution;
import org.apache.jena.query.ResultSet;
-import org.apache.jena.query.ResultSetFactory;
-import org.apache.jena.query.Syntax;
import org.apache.jena.rdf.model.Literal;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelFactory;
@@ -62,9 +57,6 @@ import edu.cornell.mannlib.vitro.webapp.dao.jena.WebappDaoFactorySDB.SDBDatasetM
import edu.cornell.mannlib.vitro.webapp.filestorage.model.ImageInfo;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFServiceException;
-import edu.cornell.mannlib.vitro.webapp.rdfservice.impl.RDFServiceUtils;
-
-import javax.xml.soap.Node;
public class IndividualSDB extends IndividualImpl implements Individual {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaBaseDao.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaBaseDao.java
index 1e914b258..760eef349 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaBaseDao.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaBaseDao.java
@@ -32,7 +32,6 @@ import org.apache.jena.query.QueryExecution;
import org.apache.jena.query.QueryExecutionFactory;
import org.apache.jena.query.QueryFactory;
import org.apache.jena.query.Syntax;
-import org.apache.jena.rdf.model.AnonId;
import org.apache.jena.rdf.model.Literal;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelFactory;
@@ -217,12 +216,12 @@ public class JenaBaseDao extends JenaBaseDaoCon {
}
}
if ( (existingValue!=null && value == null) || (existingValue!=null && value != null && !(existingValue.equals(value)))
- || (existingValue!=null && existingValue == false && keepOnlyIfTrue)) {
+ || (existingValue!=null && !existingValue && keepOnlyIfTrue)) {
model.removeAll(res, dataprop, null);
}
if ( (existingValue==null && value != null) || (existingValue!=null && value != null && !(existingValue.equals(value)) ) ) {
if (keepOnlyIfTrue) {
- if (value==true) {
+ if (value) {
model.add(res, dataprop, model.createTypedLiteral(value));
}
} else {
@@ -970,7 +969,7 @@ public class JenaBaseDao extends JenaBaseDaoCon {
if (vitroURIStr.indexOf(PSEUDO_BNODE_NS)==0) {
String idStr = vitroURIStr.split("#")[1];
log.debug("Trying to get bnode " + idStr);
- RDFNode rdfNode = ontModel.getRDFNode(NodeFactory.createAnon(idStr));
+ RDFNode rdfNode = ontModel.getRDFNode(NodeFactory.createBlankNode(idStr));
if ( (rdfNode != null) && (rdfNode.canAs(OntClass.class)) ) {
log.debug("found it");
cls = rdfNode.as(OntClass.class);
@@ -998,7 +997,7 @@ public class JenaBaseDao extends JenaBaseDaoCon {
protected Node makeNodeForURI(String vitroURIStr) {
if (vitroURIStr.indexOf(PSEUDO_BNODE_NS)==0) {
- return NodeFactory.createAnon(vitroURIStr.split("#")[1]);
+ return NodeFactory.createBlankNode(vitroURIStr.split("#")[1]);
} else {
return NodeFactory.createURI(vitroURIStr);
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaModelUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaModelUtils.java
index 93df98244..d0f7bea6e 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaModelUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaModelUtils.java
@@ -261,14 +261,13 @@ public class JenaModelUtils {
Resource property) {
dataset.getLock().enterCriticalSection(Lock.READ);
try {
- StringBuffer buff = new StringBuffer();
+ StringBuilder buff = new StringBuilder();
buff.append("PREFIX afn: \n")
- .append("CONSTRUCT { \n")
- .append(" ?res <" + property.getURI() + "> ?o } WHERE { \n");
+ .append("CONSTRUCT { \n").append(" ?res <").append(property.getURI()).append("> ?o } WHERE { \n");
if (graphURI != null) {
- buff.append(" GRAPH " + graphURI + " { \n");
+ buff.append(" GRAPH ").append(graphURI).append(" { \n");
}
- buff.append(" ?res <" + property.getURI() + "> ?o \n");
+ buff.append(" ?res <").append(property.getURI()).append("> ?o \n");
buff.append(getNamespaceFilter(namespace));
if (graphURI != null) {
buff.append(" } \n");
@@ -292,13 +291,12 @@ public class JenaModelUtils {
private String makeDescribeQueryStr( String typeURI, String namespace, String graphURI ) {
- StringBuffer describeQueryStrBuff = new StringBuffer()
+ StringBuilder describeQueryStrBuff = new StringBuilder()
.append("PREFIX rdf: \n")
.append("PREFIX afn: \n")
.append("DESCRIBE ?res WHERE { \n");
if (graphURI != null) {
- describeQueryStrBuff
- .append("GRAPH " + graphURI + "{ \n");
+ describeQueryStrBuff.append("GRAPH ").append(graphURI).append("{ \n");
}
describeQueryStrBuff
.append(" ?res rdf:type <").append(typeURI).append("> . \n");
@@ -320,7 +318,7 @@ public class JenaModelUtils {
}
private String getNamespaceFilter(String namespace) {
- StringBuffer buff = new StringBuffer();
+ StringBuilder buff = new StringBuilder();
if (namespace == null) {
// exclude resources in the Vitro internal namespace or in the
// OWL namespace, but allow all others
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/ObjectPropertyStatementDaoJena.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/ObjectPropertyStatementDaoJena.java
index 48a96ada0..b9d06d028 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/ObjectPropertyStatementDaoJena.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/ObjectPropertyStatementDaoJena.java
@@ -7,7 +7,6 @@ import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.List;
-import java.util.Locale;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Objects;
@@ -19,7 +18,6 @@ import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.jena.ontology.OntModel;
-import org.apache.jena.ontology.OntResource;
import org.apache.jena.query.Dataset;
import org.apache.jena.query.Query;
import org.apache.jena.query.QueryExecution;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyDaoJena.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyDaoJena.java
index d965b5cf1..e322d1fc7 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyDaoJena.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyDaoJena.java
@@ -3,8 +3,6 @@
package edu.cornell.mannlib.vitro.webapp.dao.jena;
import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Comparator;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
@@ -28,7 +26,6 @@ import org.apache.jena.query.QueryExecutionFactory;
import org.apache.jena.query.QueryFactory;
import org.apache.jena.query.QuerySolution;
import org.apache.jena.query.ResultSet;
-import org.apache.jena.query.ResultSetFactory;
import org.apache.jena.query.Syntax;
import org.apache.jena.rdf.model.RDFNode;
import org.apache.jena.rdf.model.Resource;
@@ -68,11 +65,11 @@ public class PropertyDaoJena extends JenaBaseDao implements PropertyDao {
protected static final String PREFIXES;
static {
- String prefixes = "";
+ StringBuilder prefixes = new StringBuilder();
for (String key : NAMESPACES.keySet()) {
- prefixes += "PREFIX " + key + ": <" + NAMESPACES.get(key) + ">\n";
+ prefixes.append("PREFIX ").append(key).append(": <").append(NAMESPACES.get(key)).append(">\n");
}
- PREFIXES = prefixes;
+ PREFIXES = prefixes.toString();
log.debug("Query prefixes: " + PREFIXES);
}
@@ -322,8 +319,7 @@ public class PropertyDaoJena extends JenaBaseDao implements PropertyDao {
// DO NOT issue a removeAll() with a null (wildcard) in predicate position!
if (predicate == null) {
log.debug("Cannot remove ABox statements with a null predicate.");
- return;
- } else {
+ } else {
removeABoxStatementsWithPredicate(predicate.getURI());
}
}
@@ -902,32 +898,32 @@ public class PropertyDaoJena extends JenaBaseDao implements PropertyDao {
return opList;
}
ObjectPropertyDao opDao = getWebappDaoFactory().getObjectPropertyDao();
- String propQuery = "PREFIX rdfs: \n" +
- "PREFIX config: \n" +
- "PREFIX vitro: \n" +
- "SELECT ?property ?domain ?range WHERE { \n" +
- " ?context config:configContextFor ?property . \n" +
- " ?context config:qualifiedByDomain ?domain . \n" +
- " ?context config:qualifiedBy ?range . \n";
+ StringBuilder propQuery = new StringBuilder("PREFIX rdfs: \n" +
+ "PREFIX config: \n" +
+ "PREFIX vitro: \n" +
+ "SELECT ?property ?domain ?range WHERE { \n" +
+ " ?context config:configContextFor ?property . \n" +
+ " ?context config:qualifiedByDomain ?domain . \n" +
+ " ?context config:qualifiedBy ?range . \n");
for(PropertyInstance propInst : propInsts) {
- propQuery += " FILTER (?property != <" + propInst.getPropertyURI() + "> ) \n";
+ propQuery.append(" FILTER (?property != <").append(propInst.getPropertyURI()).append("> ) \n");
}
Iterator classIt = vclasses.iterator();
if(classIt.hasNext()) {
- propQuery += " FILTER ( \n";
- propQuery += " (?domain = <" + OWL.Thing.getURI() + "> )\n";
+ propQuery.append(" FILTER ( \n");
+ propQuery.append(" (?domain = <").append(OWL.Thing.getURI()).append("> )\n");
while (classIt.hasNext()) {
VClass vclass = classIt.next();
if(vclass.isAnonymous()) {
continue;
}
- propQuery += " || (?domain = <" + vclass.getURI() + "> ) \n";
+ propQuery.append(" || (?domain = <").append(vclass.getURI()).append("> ) \n");
}
- propQuery += ") \n";
+ propQuery.append(") \n");
}
- propQuery += "} \n";
- log.debug(propQuery);
- Query q = QueryFactory.create(propQuery);
+ propQuery.append("} \n");
+ log.debug(propQuery.toString());
+ Query q = QueryFactory.create(propQuery.toString());
QueryExecution qe = QueryExecutionFactory.create(
q, getOntModelSelector().getDisplayModel());
try {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyInstanceDaoJena.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyInstanceDaoJena.java
index 0c0f8fa4f..c9e425f03 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyInstanceDaoJena.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/PropertyInstanceDaoJena.java
@@ -3,7 +3,6 @@
package edu.cornell.mannlib.vitro.webapp.dao.jena;
import java.util.ArrayList;
-import java.util.Calendar;
import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/QueryUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/QueryUtils.java
index 1fac3ba84..1c964ad4a 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/QueryUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/QueryUtils.java
@@ -9,8 +9,6 @@ import java.util.Iterator;
import java.util.List;
import java.util.Map;
-import org.apache.commons.lang3.ObjectUtils;
-import org.apache.commons.lang3.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDataset.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDataset.java
index 5898d1ff4..f481c4c9c 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDataset.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDataset.java
@@ -11,7 +11,6 @@ import org.apache.commons.logging.LogFactory;
import org.apache.jena.graph.Graph;
import org.apache.jena.graph.Node;
import org.apache.jena.graph.NodeFactory;
-import org.apache.jena.graph.TransactionHandler;
import org.apache.jena.query.Dataset;
import org.apache.jena.query.LabelExistsException;
import org.apache.jena.query.ReadWrite;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDatasetGraph.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDatasetGraph.java
index 4c9892133..39008e572 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDatasetGraph.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceDatasetGraph.java
@@ -190,11 +190,11 @@ public class RDFServiceDatasetGraph implements DatasetGraph {
return WrappedIterator.create(Collections.emptyIterator());
}
}
- StringBuffer findQuery = new StringBuffer("SELECT * WHERE { \n");
+ StringBuilder findQuery = new StringBuilder("SELECT * WHERE { \n");
String graphURI = !isVar(graph) ? graph.getURI() : null;
findQuery.append(" GRAPH ");
if (graphURI != null) {
- findQuery.append(" <" + graphURI + ">");
+ findQuery.append(" <").append(graphURI).append(">");
} else {
findQuery.append("?g");
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceGraph.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceGraph.java
index 666cfcf23..74c22528e 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceGraph.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/RDFServiceGraph.java
@@ -87,12 +87,11 @@ public class RDFServiceGraph implements GraphWithPerform {
performAdd(arg0);
}
- private String serialize(Triple t) {
- StringBuffer sb = new StringBuffer();
- sb.append(sparqlNodeUpdate(t.getSubject(), "")).append(" ")
+ private StringBuilder serialize(StringBuilder sb, Triple t) {
+ sb.append(sparqlNodeUpdate(t.getSubject(), "")).append(" ")
.append(sparqlNodeUpdate(t.getPredicate(), "")).append(" ")
.append(sparqlNodeUpdate(t.getObject(), "")).append(" .");
- return sb.toString();
+ return sb;
}
private synchronized void flush() {
@@ -117,12 +116,12 @@ public class RDFServiceGraph implements GraphWithPerform {
}
private synchronized String serializeGraph(Graph graph) {
- String triples = "";
+ StringBuilder sb = new StringBuilder();
Iterator tripIt = graph.find(null, null, null);
while(tripIt.hasNext()) {
- triples += " \n" + serialize(tripIt.next());
+ serialize(sb.append(" \n"), tripIt.next());
}
- return triples;
+ return sb.toString();
}
@Override
@@ -132,7 +131,7 @@ public class RDFServiceGraph implements GraphWithPerform {
} else {
ChangeSet changeSet = rdfService.manufactureChangeSet();
try {
- changeSet.addAddition(RDFServiceUtils.toInputStream(serialize(t)),
+ changeSet.addAddition(RDFServiceUtils.toInputStream(serialize(new StringBuilder(), t).toString()),
RDFService.ModelSerializationFormat.N3, graphURI);
rdfService.changeSetUpdate(changeSet);
} catch (RDFServiceException rdfse) {
@@ -156,7 +155,7 @@ public class RDFServiceGraph implements GraphWithPerform {
} else {
ChangeSet changeSet = rdfService.manufactureChangeSet();
try {
- changeSet.addRemoval(RDFServiceUtils.toInputStream(serialize(t)),
+ changeSet.addRemoval(RDFServiceUtils.toInputStream(serialize(new StringBuilder(), t).toString()),
RDFService.ModelSerializationFormat.N3, graphURI);
rdfService.changeSetUpdate(changeSet);
} catch (RDFServiceException rdfse) {
@@ -221,9 +220,9 @@ public class RDFServiceGraph implements GraphWithPerform {
|| (object != null && object.isBlank())) {
return false;
}
- StringBuffer containsQuery = new StringBuffer("SELECT * WHERE { \n");
+ StringBuilder containsQuery = new StringBuilder("SELECT * WHERE { \n");
if (graphURI != null) {
- containsQuery.append(" GRAPH <" + graphURI + "> { ");
+ containsQuery.append(" GRAPH <").append(graphURI).append("> { ");
}
containsQuery.append(sparqlNode(subject, "?s"))
.append(" ")
@@ -283,7 +282,7 @@ public class RDFServiceGraph implements GraphWithPerform {
} else if (node.isBlank()) {
return ""; // or throw exception?
} else if (node.isURI()) {
- StringBuffer uriBuff = new StringBuffer();
+ StringBuilder uriBuff = new StringBuilder();
return uriBuff.append("<").append(node.getURI()).append(">").toString();
} else if (node.isLiteral()) {
StringBuffer literalBuff = new StringBuffer();
@@ -326,9 +325,9 @@ public class RDFServiceGraph implements GraphWithPerform {
return WrappedIterator.create(Collections.emptyIterator());
}
}
- StringBuffer findQuery = new StringBuffer("SELECT * WHERE { \n");
+ StringBuilder findQuery = new StringBuilder("SELECT * WHERE { \n");
if (graphURI != null) {
- findQuery.append(" GRAPH <" + graphURI + "> { ");
+ findQuery.append(" GRAPH <").append(graphURI).append("> { ");
}
findQuery.append(sparqlNode(subject, "?s"))
.append(" ")
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/SparqlGraph.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/SparqlGraph.java
index 1fa402632..16dfd10ec 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/SparqlGraph.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/SparqlGraph.java
@@ -14,8 +14,6 @@ import org.apache.http.HttpResponse;
import org.apache.http.client.HttpClient;
import org.apache.http.client.entity.UrlEncodedFormEntity;
import org.apache.http.client.methods.HttpPost;
-import org.apache.http.impl.client.DefaultHttpClient;
-import org.apache.http.impl.conn.PoolingClientConnectionManager;
import org.apache.http.message.BasicNameValuePair;
import org.apache.jena.graph.Capabilities;
@@ -175,9 +173,9 @@ public class SparqlGraph implements GraphWithPerform {
|| (object != null && object.isBlank())) {
return false;
}
- StringBuffer containsQuery = new StringBuffer("ASK { \n");
+ StringBuilder containsQuery = new StringBuilder("ASK { \n");
if (graphURI != null) {
- containsQuery.append(" GRAPH <" + graphURI + "> { ");
+ containsQuery.append(" GRAPH <").append(graphURI).append("> { ");
}
containsQuery.append(sparqlNode(subject, "?s"))
.append(" ")
@@ -226,7 +224,7 @@ public class SparqlGraph implements GraphWithPerform {
} else if (node.isBlank()) {
return ""; // or throw exception?
} else if (node.isURI()) {
- StringBuffer uriBuff = new StringBuffer();
+ StringBuilder uriBuff = new StringBuilder();
return uriBuff.append("<").append(node.getURI()).append(">").toString();
} else if (node.isLiteral()) {
StringBuffer literalBuff = new StringBuffer();
@@ -269,9 +267,9 @@ public class SparqlGraph implements GraphWithPerform {
return WrappedIterator.create(Collections.emptyIterator());
}
}
- StringBuffer findQuery = new StringBuffer("SELECT * WHERE { \n");
+ StringBuilder findQuery = new StringBuilder("SELECT * WHERE { \n");
if (graphURI != null) {
- findQuery.append(" GRAPH <" + graphURI + "> { ");
+ findQuery.append(" GRAPH <").append(graphURI).append("> { ");
}
findQuery.append(sparqlNode(subject, "?s"))
.append(" ")
@@ -415,11 +413,8 @@ public class SparqlGraph implements GraphWithPerform {
private boolean execAsk(String queryStr) {
Query askQuery = QueryFactory.create(queryStr);
- QueryExecution qe = QueryExecutionFactory.sparqlService(endpointURI, askQuery);
- try {
+ try (QueryExecution qe = QueryExecutionFactory.sparqlService(endpointURI, askQuery)) {
return qe.execAsk();
- } finally {
- qe.close();
}
}
@@ -444,11 +439,8 @@ public class SparqlGraph implements GraphWithPerform {
// log.info((System.currentTimeMillis() - startTime1) + " to execute via sesame");
Query askQuery = QueryFactory.create(queryStr);
- QueryExecution qe = QueryExecutionFactory.sparqlService(endpointURI, askQuery);
- try {
+ try (QueryExecution qe = QueryExecutionFactory.sparqlService(endpointURI, askQuery)) {
return new ResultSetMem(qe.execSelect());
- } finally {
- qe.close();
}
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoJena.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoJena.java
index ee2a644f0..bc8e927a8 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoJena.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoJena.java
@@ -90,69 +90,70 @@ public class VClassDaoJena extends JenaBaseDao implements VClassDao {
if (cls.isRestriction()) {
Restriction rest = cls.asRestriction();
OntProperty onProperty = rest.getOnProperty();
- String labelStr = "restriction on " + getLabelOrId(onProperty) + ": ";
+ StringBuilder labelStr = new StringBuilder();
+ labelStr.append("restriction on ").append(getLabelOrId(onProperty)).append(": ");
if (rest.isAllValuesFromRestriction() || rest.isSomeValuesFromRestriction()) {
Resource fillerRes = null;
if (rest.isAllValuesFromRestriction()) {
AllValuesFromRestriction avfRest = rest.asAllValuesFromRestriction();
fillerRes = avfRest.getAllValuesFrom();
- labelStr += "all values from ";
+ labelStr.append("all values from ");
} else {
SomeValuesFromRestriction svfRest = rest.asSomeValuesFromRestriction();
fillerRes = svfRest.getSomeValuesFrom();
- labelStr += "some values from ";
+ labelStr.append("some values from ");
}
if (fillerRes.canAs(OntClass.class)) {
OntClass avf = fillerRes.as(OntClass.class);
- labelStr += getLabelForClass(avf,withPrefix,forPickList);
+ labelStr.append(getLabelForClass(avf,withPrefix,forPickList));
} else {
try {
- labelStr += getLabelOrId(fillerRes.as(OntResource.class));
+ labelStr.append(getLabelOrId(fillerRes.as(OntResource.class)));
} catch (Exception e) {
- labelStr += "???";
+ labelStr.append("???");
}
}
} else if (rest.isHasValueRestriction()) {
HasValueRestriction hvRest = rest.asHasValueRestriction();
- labelStr += "has value ";
+ labelStr.append("has value ");
RDFNode fillerNode = hvRest.getHasValue();
try {
if (fillerNode.isResource()) {
- labelStr += getLabelOrId(fillerNode.as(OntResource.class));
+ labelStr.append(getLabelOrId(fillerNode.as(OntResource.class)));
} else {
- labelStr += fillerNode.as(Literal.class).getLexicalForm();
+ labelStr.append(fillerNode.as(Literal.class).getLexicalForm());
}
} catch (Exception e) {
- labelStr += "???";
+ labelStr.append("???");
}
} else if (rest.isMinCardinalityRestriction()) {
MinCardinalityRestriction mcRest = rest.asMinCardinalityRestriction();
- labelStr += "minimum cardinality ";
- labelStr += mcRest.getMinCardinality();
+ labelStr.append("minimum cardinality ");
+ labelStr.append(mcRest.getMinCardinality());
} else if (rest.isMaxCardinalityRestriction()) {
MaxCardinalityRestriction mcRest = rest.asMaxCardinalityRestriction();
- labelStr += "maximum cardinality ";
- labelStr += mcRest.getMaxCardinality();
+ labelStr.append("maximum cardinality ");
+ labelStr.append(mcRest.getMaxCardinality());
} else if (rest.isCardinalityRestriction()) {
CardinalityRestriction cRest = rest.asCardinalityRestriction();
- labelStr += "cardinality ";
- labelStr += cRest.getCardinality();
+ labelStr.append("cardinality ");
+ labelStr.append(cRest.getCardinality());
}
- return labelStr;
+ return labelStr.toString();
} else if (isBooleanClassExpression(cls)) {
- String labelStr = "(";
+ StringBuilder labelStr = new StringBuilder("(");
if (cls.isComplementClass()) {
- labelStr += "not ";
+ labelStr.append("not ");
ComplementClass ccls = cls.as(ComplementClass.class);
- labelStr += getLabelForClass(ccls.getOperand(),withPrefix,forPickList);
+ labelStr.append(getLabelForClass(ccls.getOperand(), withPrefix, forPickList));
} else if (cls.isIntersectionClass()) {
IntersectionClass icls = cls.as(IntersectionClass.class);
for (Iterator extends OntClass> operandIt =
icls.listOperands(); operandIt.hasNext();) {
OntClass operand = operandIt.next();
- labelStr += getLabelForClass(operand,withPrefix,forPickList);
+ labelStr.append(getLabelForClass(operand, withPrefix, forPickList));
if (operandIt.hasNext()) {
- labelStr += " and ";
+ labelStr.append(" and ");
}
}
} else if (cls.isUnionClass()) {
@@ -160,13 +161,13 @@ public class VClassDaoJena extends JenaBaseDao implements VClassDao {
for (Iterator extends OntClass> operandIt =
icls.listOperands(); operandIt.hasNext();) {
OntClass operand = operandIt.next();
- labelStr += getLabelForClass(operand,withPrefix,forPickList);
+ labelStr.append(getLabelForClass(operand, withPrefix, forPickList));
if (operandIt.hasNext()) {
- labelStr += " or ";
+ labelStr.append(" or ");
}
}
}
- return labelStr+")";
+ return labelStr.append(")").toString();
} else {
// BJL23 2009-02-19
// I'm putting the link markup in because I need it,
@@ -665,7 +666,7 @@ public class VClassDaoJena extends JenaBaseDao implements VClassDao {
if (getOntModel().getProfile().NAMESPACE().equals(RDFS.getURI())) {
top.setURI(RDF.getURI()+"Resource");
} else {
- top.setURI( (getOntModel().getProfile().THING().getURI()!=null) ? (getOntModel().getProfile().THING().getURI()): null);
+ top.setURI((getOntModel().getProfile().THING().getURI()));
}
if (top.getURI() != null) {
top.setName(top.getLocalName());
@@ -680,7 +681,7 @@ public class VClassDaoJena extends JenaBaseDao implements VClassDao {
if (getOntModel().getProfile().NAMESPACE().equals(RDFS.getURI())) {
return null;
} else {
- bottom.setURI( (getOntModel().getProfile().NOTHING().getURI()!=null) ? (getOntModel().getProfile().NOTHING().getURI()): null);
+ bottom.setURI((getOntModel().getProfile().NOTHING().getURI()));
}
if (bottom.getURI() != null) {
bottom.setName(bottom.getLocalName());
@@ -853,7 +854,7 @@ public class VClassDaoJena extends JenaBaseDao implements VClassDao {
}
vcw.setEntityCount(count);
classIsInstantiated = (count > 0);
- } else if (includeUninstantiatedClasses == false) {
+ } else if (!includeUninstantiatedClasses) {
// Note: to support SDB models, may want to do this with
// SPARQL and LIMIT 1 if SDB can take advantage of it
Model aboxModel = getOntModelSelector().getABoxModel();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoSDB.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoSDB.java
index d8917246e..317713b2a 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoSDB.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/VClassDaoSDB.java
@@ -3,8 +3,6 @@
package edu.cornell.mannlib.vitro.webapp.dao.jena;
-import org.apache.jena.ontology.AnnotationProperty;
-import org.apache.jena.ontology.OntClass;
import org.apache.jena.query.Dataset;
import org.apache.jena.query.Query;
import org.apache.jena.query.QueryExecution;
@@ -20,7 +18,6 @@ import org.apache.jena.rdf.model.ResourceFactory;
import org.apache.jena.rdf.model.Statement;
import org.apache.jena.rdf.model.StmtIterator;
import org.apache.jena.shared.Lock;
-import org.apache.jena.util.iterator.ClosableIterator;
import org.apache.jena.vocabulary.RDF;
import edu.cornell.mannlib.vitro.webapp.beans.VClass;
@@ -88,7 +85,7 @@ public class VClassDaoSDB extends VClassDaoJena {
}
vcw.setEntityCount(count);
classIsInstantiated = (count > 0);
- } else if (includeUninstantiatedClasses == false) {
+ } else if (!includeUninstantiatedClasses) {
// Note: to support SDB models, may want to do this with
// SPARQL and LIMIT 1 if SDB can take advantage of it
Model aboxModel = getOntModelSelector().getABoxModel();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/WebappDaoFactorySDB.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/WebappDaoFactorySDB.java
index a383b7c12..ca77a08fa 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/WebappDaoFactorySDB.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/WebappDaoFactorySDB.java
@@ -21,7 +21,6 @@ import edu.cornell.mannlib.vitro.webapp.dao.WebappDaoFactory;
import edu.cornell.mannlib.vitro.webapp.dao.WebappDaoFactoryConfig;
import edu.cornell.mannlib.vitro.webapp.modelaccess.ModelNames;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService;
-import edu.cornell.mannlib.vitro.webapp.servlet.setup.SimpleReasonerSetup;
public class WebappDaoFactorySDB extends WebappDaoFactoryJena {
@@ -115,7 +114,7 @@ public class WebappDaoFactorySDB extends WebappDaoFactoryJena {
public static String getFilterBlock(String[] graphVars,
SDBDatasetMode datasetMode) {
- StringBuffer filterBlock = new StringBuffer();
+ StringBuilder filterBlock = new StringBuilder();
for (int i = 0; i < graphVars.length; i++) {
switch (datasetMode) {
case ASSERTIONS_ONLY :
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BaseEditElementVTwo.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BaseEditElementVTwo.java
index bf333d002..d601fabed 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BaseEditElementVTwo.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BaseEditElementVTwo.java
@@ -41,9 +41,7 @@ public abstract class BaseEditElementVTwo implements EditElementVTwo {
StringWriter writer = new StringWriter();
try {
template.process(map, writer);
- } catch (TemplateException e) {
- log.error(e,e);
- } catch (IOException e) {
+ } catch (TemplateException | IOException e) {
log.error(e,e);
}
return writer.toString();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BasicValidationVTwo.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BasicValidationVTwo.java
index c3ef8ad3a..65338ca89 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BasicValidationVTwo.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/BasicValidationVTwo.java
@@ -57,18 +57,18 @@ public class BasicValidationVTwo {
if( validations!= null){
for( String validationType : validations){
//Appending validate message if same field has multiple values
- String validateMsg = null;
+ StringBuilder validateMsg = null;
for(String value: values){
String thisValidateMsg = validate(validationType,value);
if(validateMsg != null && thisValidateMsg != null) {
- validateMsg += ", " + thisValidateMsg;
+ validateMsg.append(", ").append(thisValidateMsg);
} else {
- validateMsg = thisValidateMsg;
+ validateMsg = new StringBuilder(thisValidateMsg);
}
}
if( validateMsg != null) {
- errors.put(name,validateMsg);
+ errors.put(name, validateMsg.toString());
}
}
}
@@ -89,7 +89,7 @@ public class BasicValidationVTwo {
for( String validationType : validations){
String value = null;
- String validateMsg = null;
+ StringBuilder validateMsg = null;
//If no literals and this field was required, this is an error message
//and can return
if((literals == null || literals.size() == 0) && isRequiredField) {
@@ -118,15 +118,15 @@ public class BasicValidationVTwo {
}
String thisValidateMsg = validate(validationType,value);
if(validateMsg != null && thisValidateMsg != null) {
- validateMsg += ", " + thisValidateMsg;
+ validateMsg.append(", ").append(thisValidateMsg);
} else {
- validateMsg = thisValidateMsg;
+ validateMsg = new StringBuilder(thisValidateMsg);
}
}
}
if( validateMsg != null) {
- errors.put(name,validateMsg);
+ errors.put(name, validateMsg.toString());
}
}
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/DateTimeWithPrecisionVTwo.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/DateTimeWithPrecisionVTwo.java
index b468c351b..8f525d2e1 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/DateTimeWithPrecisionVTwo.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/DateTimeWithPrecisionVTwo.java
@@ -576,13 +576,9 @@ public class DateTimeWithPrecisionVTwo extends BaseEditElementVTwo {
out = Integer.parseInt(vt[0]);
return true;
}
- }catch(IndexOutOfBoundsException iex){
+ }catch(IndexOutOfBoundsException | NullPointerException | NumberFormatException iex){
out = null;
- }catch(NumberFormatException nfe){
- out = null;
- }catch(NullPointerException npe){
- out = null;
- }
+ }
return false;
}
@@ -596,13 +592,9 @@ public class DateTimeWithPrecisionVTwo extends BaseEditElementVTwo {
out = null;
else
out = Integer.parseInt(vt[0]);
- }catch(IndexOutOfBoundsException iex){
+ }catch(IndexOutOfBoundsException | NullPointerException | NumberFormatException iex){
out = null;
- }catch(NumberFormatException nfe){
- out = null;
- }catch(NullPointerException npe){
- out = null;
- }
+ }
return out;
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationUtils.java
index a47f24013..cc85e5fdc 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationUtils.java
@@ -297,7 +297,7 @@ public class EditConfigurationUtils {
public static List copy(List list) {
List copyList = new ArrayList();
for(String l: list) {
- copyList.add( new String (l) );
+ copyList.add(l);
}
return copyList;
}
@@ -307,9 +307,9 @@ public class EditConfigurationUtils {
Set keys = map.keySet();
for(String key: keys) {
if( source.get(key) != null )
- map.put(new String(key), new String( source.get(key)) );
+ map.put(key, source.get(key));
else
- map.put(new String(key),null);
+ map.put(key,null);
}
return map;
}
@@ -319,7 +319,7 @@ public class EditConfigurationUtils {
Set keys = map.keySet();
for(String key: keys) {
List vals = map.get(key);
- map.put(new String(key), copy(vals));
+ map.put(key, copy(vals));
}
return map;
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationVTwo.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationVTwo.java
index c95c827ab..069294bee 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationVTwo.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditConfigurationVTwo.java
@@ -618,9 +618,9 @@ public class EditConfigurationVTwo {
Map dest = new HashMap();
for( String key : source.keySet()){
if( source.get(key) != null )
- dest.put(new String(key), source.get(key));
+ dest.put(key, source.get(key));
else
- dest.put(new String(key), null);
+ dest.put(key, null);
}
return dest;
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditN3GeneratorVTwo.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditN3GeneratorVTwo.java
index 41f5853f1..fef6b2712 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditN3GeneratorVTwo.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/EditN3GeneratorVTwo.java
@@ -4,8 +4,6 @@ package edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo;
import java.math.BigDecimal;
import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -16,7 +14,6 @@ import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.jena.rdf.model.Literal;
-import org.apache.jena.rdf.model.Model;
import org.apache.jena.vocabulary.XSD;
/**
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/N3EditUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/N3EditUtils.java
index 86438aed2..aa575b4cc 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/N3EditUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/N3EditUtils.java
@@ -253,7 +253,7 @@ public class N3EditUtils {
if (in == null) {
return null;
}
- StringBuffer out = new StringBuffer();
+ StringBuilder out = new StringBuilder();
for (int i = 0; i < in.length(); i++) {
char c = in.charAt(i);
if (!XMLChar.isInvalid(c)) {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/ProcessRdfForm.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/ProcessRdfForm.java
index 7e66585ee..1a857125a 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/ProcessRdfForm.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/ProcessRdfForm.java
@@ -5,12 +5,10 @@ package edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo;
import java.io.StringReader;
import java.util.ArrayList;
import java.util.Arrays;
-import java.util.Collections;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
-import java.util.Random;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -26,7 +24,6 @@ import edu.cornell.mannlib.vitro.webapp.dao.InsertException;
import edu.cornell.mannlib.vitro.webapp.dao.jena.DependentResourceDeleteJena;
import edu.cornell.mannlib.vitro.webapp.dao.jena.event.EditEvent;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.configuration.EditConfigurationConstants;
-import edu.cornell.mannlib.vitro.webapp.edit.n3editing.controller.ProcessRdfFormController.Utilities;
/**
* The goal of this class is to provide processing from
@@ -295,9 +292,9 @@ public class ProcessRdfForm {
}
}
- String errors = "";
+ StringBuilder errors = new StringBuilder();
for( String errorMsg : errorMessages){
- errors += errorMsg + '\n';
+ errors.append(errorMsg).append('\n');
}
if( !errorMessages.isEmpty() ){
@@ -311,7 +308,7 @@ public class ProcessRdfForm {
"remain unfilled out and then the optional N3 does not get values subsituted in from" +
"the form submission values. It may also be the case that there are unintentional " +
"syntax errors the optional N3." );
- log.debug( errors );
+ log.debug(errors.toString());
}
}
@@ -331,11 +328,11 @@ public class ProcessRdfForm {
private void logSubstitueN3(String msg, List n3, String label){
if( n3 == null || n3.size() == 0) return;
- String out = label + ":\n";
+ StringBuilder out = new StringBuilder(label + ":\n");
for( String str : n3 ){
- out += " " + str + "\n";
+ out.append(" ").append(str).append("\n");
}
- log.debug(out);
+ log.debug(out.toString());
}
private static Map getSubPedObjVarMap(
@@ -468,7 +465,7 @@ public class ProcessRdfForm {
//TODO: Check how to handle multiple new resource values
Iterator keyIterator = urisFromForm.keySet().iterator();
while(keyIterator.hasNext()) {
- String key = keyIterator.next().toString();
+ String key = keyIterator.next();
if(urisFromForm.get(key).contains(EditConfigurationConstants.NEW_URI_SENTINEL)) {
String newUri = urisForNewResources.get(key);
List newUrisForKey = new ArrayList();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropertyByRankOptions.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropertyByRankOptions.java
index 0ddad8a43..3287f945b 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropertyByRankOptions.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropertyByRankOptions.java
@@ -1,7 +1,6 @@
/* $This file is distributed under the terms of the license in LICENSE$ */
package edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.fields;
-import java.text.Collator;
import java.util.Comparator;
import org.apache.commons.logging.Log;
@@ -75,7 +74,7 @@ public class IndividualsViaObjectPropertyByRankOptions extends IndividualsViaObj
int displayRank1 = getDisplayRank(ind1);
int displayRank2 = getDisplayRank(ind2);
//Get display ranks
- return (displayRank1 > displayRank2 ? 1: (displayRank1 == displayRank2? 0: -1));
+ return (Integer.compare(displayRank1, displayRank2));
//TODO: Incorporate sparql query here to retrieve the ranks
//This qualifies as neither a data property or an object property so will need to access
//using sparql query
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropetyOptions.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropetyOptions.java
index 155abc291..acd46c217 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropetyOptions.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaObjectPropetyOptions.java
@@ -7,14 +7,10 @@ import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.List;
-import java.util.ListIterator;
import java.util.Map;
-import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-import org.apache.commons.lang3.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -153,7 +149,7 @@ public class IndividualsViaObjectPropetyOptions implements FieldOptions {
private HashSet getApplicableVClassURIs(Individual subject, WebappDaoFactory wDaoFact) {
HashSet vclassesURIs = new HashSet();
if (!rangeTypes.isEmpty()) {
- StringBuffer rangeBuff = new StringBuffer();
+ StringBuilder rangeBuff = new StringBuilder();
for (VClass rangeType : rangeTypes) {
vclassesURIs.add(rangeType.getURI());
rangeBuff.append(rangeType.getURI()).append(", ");
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaVClassOptions.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaVClassOptions.java
index fbf5ed395..aa5e0afdd 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaVClassOptions.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/IndividualsViaVClassOptions.java
@@ -76,11 +76,11 @@ public class IndividualsViaVClassOptions implements FieldOptions {
private Map extends String, ? extends String> notFoundMsg() {
- String msg = "No individuals found for "+ (vclassURIs.size() > 1?"types":"type");
+ StringBuilder msg = new StringBuilder("No individuals found for " + (vclassURIs.size() > 1 ? "types" : "type"));
for( String uri : vclassURIs ){
- msg += " " + uri;
+ msg.append(" ").append(uri);
}
- return Collections.singletonMap("", msg);
+ return Collections.singletonMap("", msg.toString());
}
protected Map getIndividualsForClass(String vclassURI, WebappDaoFactory wDaoFact ){
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/SelectListGeneratorVTwo.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/SelectListGeneratorVTwo.java
index 98c5b3649..1b7cf8cd4 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/SelectListGeneratorVTwo.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/VTwo/fields/SelectListGeneratorVTwo.java
@@ -14,7 +14,6 @@ import java.util.Map;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import edu.cornell.mannlib.vitro.webapp.controller.VitroHttpServlet;
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
import edu.cornell.mannlib.vitro.webapp.dao.WebappDaoFactory;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditConfigurationVTwo;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/EditConfigurationConstants.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/EditConfigurationConstants.java
index 33ebfd202..37100f6dc 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/EditConfigurationConstants.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/EditConfigurationConstants.java
@@ -8,8 +8,6 @@ import java.util.Map;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.ProcessRdfForm;
-
public class EditConfigurationConstants {
/** Constants used by edit configuration */
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeIntervalFormGenerator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeIntervalFormGenerator.java
index 5b642fef2..bfec0a78e 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeIntervalFormGenerator.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeIntervalFormGenerator.java
@@ -2,16 +2,10 @@
package edu.cornell.mannlib.vitro.webapp.edit.n3editing.configuration.generators;
-import java.util.ArrayList;
-import java.util.Arrays;
import java.util.HashMap;
-import java.util.List;
import javax.servlet.http.HttpSession;
-import org.apache.jena.rdf.model.Model;
-import org.apache.jena.vocabulary.XSD;
-
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.DateTimeIntervalValidationVTwo;
@@ -21,7 +15,6 @@ import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditConfigurationVTw
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.fields.FieldVTwo;
import edu.cornell.mannlib.vitro.webapp.utils.FrontEndEditingUtils;
import edu.cornell.mannlib.vitro.webapp.utils.FrontEndEditingUtils.EditMode;
-import edu.cornell.mannlib.vitro.webapp.utils.generators.EditModeUtils;
public class DateTimeIntervalFormGenerator extends
BaseEditConfigurationGenerator implements EditConfigurationGenerator {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimePropertyGenerator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimePropertyGenerator.java
index e7e56200c..25e448a30 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimePropertyGenerator.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimePropertyGenerator.java
@@ -3,25 +3,11 @@
package edu.cornell.mannlib.vitro.webapp.edit.n3editing.configuration.generators;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-
import javax.servlet.http.HttpSession;
-import org.apache.jena.rdf.model.Model;
-import org.apache.jena.vocabulary.XSD;
-
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
-import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
-import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.DateTimeWithPrecisionVTwo;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditConfigurationUtils;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditConfigurationVTwo;
-import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.fields.FieldVTwo;
-import edu.cornell.mannlib.vitro.webapp.utils.FrontEndEditingUtils;
-import edu.cornell.mannlib.vitro.webapp.utils.FrontEndEditingUtils.EditMode;
-import edu.cornell.mannlib.vitro.webapp.utils.generators.EditModeUtils;
/**
*
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeValueFormGenerator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeValueFormGenerator.java
index 970b2a3db..85e9cbcf2 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeValueFormGenerator.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DateTimeValueFormGenerator.java
@@ -2,16 +2,11 @@
package edu.cornell.mannlib.vitro.webapp.edit.n3editing.configuration.generators;
-import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
-import java.util.List;
import javax.servlet.http.HttpSession;
-import org.apache.jena.rdf.model.Model;
-import org.apache.jena.vocabulary.XSD;
-
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.DateTimeWithPrecisionVTwo;
@@ -20,7 +15,6 @@ import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditConfigurationVTw
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.fields.FieldVTwo;
import edu.cornell.mannlib.vitro.webapp.utils.FrontEndEditingUtils;
import edu.cornell.mannlib.vitro.webapp.utils.FrontEndEditingUtils.EditMode;
-import edu.cornell.mannlib.vitro.webapp.utils.generators.EditModeUtils;
public class DateTimeValueFormGenerator extends BaseEditConfigurationGenerator
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java
index 59655782c..3fb637143 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java
@@ -10,7 +10,6 @@ import java.util.Map;
import javax.servlet.http.HttpSession;
-import edu.cornell.mannlib.vitro.webapp.web.templatemodels.searchresult.IndividualSearchResult;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -63,8 +62,8 @@ public class DefaultAddMissingIndividualFormGenerator implements EditConfigurati
if(objProp != null) {
return(objProp.getOfferCreateNewOption() &&
(
- (command != null && command.equals(createCommand)) ||
- objProp.getSelectFromExisting() == false
+ (command != null && command.equals(createCommand)) ||
+ !objProp.getSelectFromExisting()
)
);
}
@@ -434,7 +433,7 @@ public class DefaultAddMissingIndividualFormGenerator implements EditConfigurati
return (isEditOfExistingStmt
&& "create".equals(command))
&& (objectProp != null)
- && (objectProp.getOfferCreateNewOption() == true);
+ && (objectProp.getOfferCreateNewOption());
}
private boolean isForwardToCreateButEdit(VitroRequest vreq) {
@@ -444,8 +443,8 @@ public class DefaultAddMissingIndividualFormGenerator implements EditConfigurati
return (isEditOfExistingStmt
&& (! "create".equals(command))
&& (objectProp != null)
- && (objectProp.getOfferCreateNewOption() == true)
- && (objectProp.getSelectFromExisting() == false)
+ && (objectProp.getOfferCreateNewOption())
+ && (!objectProp.getSelectFromExisting())
);
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultObjectPropertyFormGenerator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultObjectPropertyFormGenerator.java
index 0654d8ed7..1436d1934 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultObjectPropertyFormGenerator.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultObjectPropertyFormGenerator.java
@@ -340,8 +340,7 @@ public class DefaultObjectPropertyFormGenerator implements EditConfigurationGene
this.processObjectPropForm(vreq, editConfiguration);
} else {
log.debug("This is a data property: " + predicateUri);
- return;
- }
+ }
}
@@ -538,7 +537,7 @@ public class DefaultObjectPropertyFormGenerator implements EditConfigurationGene
types = new ArrayList();
}
- StringBuffer typesBuff = new StringBuffer();
+ StringBuilder typesBuff = new StringBuilder();
for (VClass type : types) {
if (type.getURI() != null) {
typesBuff.append(type.getURI()).append(",");
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/InstitutionalInternalClassForm.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/InstitutionalInternalClassForm.java
index 62c2a9550..b02e32609 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/InstitutionalInternalClassForm.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/InstitutionalInternalClassForm.java
@@ -3,6 +3,7 @@
package edu.cornell.mannlib.vitro.webapp.edit.n3editing.configuration.generators;
import java.util.ArrayList;
+import java.util.Collections;
import javax.servlet.http.HttpSession;
@@ -49,9 +50,7 @@ public class InstitutionalInternalClassForm extends BaseEditConfigurationGenerat
public class StringList extends ArrayList{
public StringList( String ... strings){
super();
- for( String str: strings){
- this.add(str);
- }
+ Collections.addAll(this, strings);
}
}
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/DefaultDataPropEmptyField.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/DefaultDataPropEmptyField.java
index 4ad3ad99f..6424111da 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/DefaultDataPropEmptyField.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/DefaultDataPropEmptyField.java
@@ -14,7 +14,6 @@ import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditConfigurationUti
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditConfigurationVTwo;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.EditSubmissionUtils;
import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.MultiValueEditSubmission;
-import edu.cornell.mannlib.vitro.webapp.edit.n3editing.controller.ProcessRdfFormController.Utilities;
/**
* Editors have gotten into the habit of clearing the text from the
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/FoafNameToRdfsLabelPreprocessor.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/FoafNameToRdfsLabelPreprocessor.java
index c4ead6fdf..04f4da2a7 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/FoafNameToRdfsLabelPreprocessor.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/FoafNameToRdfsLabelPreprocessor.java
@@ -12,17 +12,12 @@ import org.apache.jena.query.QueryExecution;
import org.apache.jena.query.QueryExecutionFactory;
import org.apache.jena.query.QueryFactory;
import org.apache.jena.query.QuerySolution;
-import org.apache.jena.query.QuerySolutionMap;
import org.apache.jena.query.ResultSet;
-import org.apache.jena.query.Syntax;
import org.apache.jena.rdf.model.Literal;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelFactory;
import org.apache.jena.rdf.model.Property;
-import org.apache.jena.rdf.model.ResIterator;
import org.apache.jena.rdf.model.Resource;
-import org.apache.jena.rdf.model.ResourceFactory;
-import org.apache.jena.rdf.model.Statement;
import org.apache.jena.shared.Lock;
import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/ManageLabelsForIndividualPreprocessor.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/ManageLabelsForIndividualPreprocessor.java
index 3ee2cb7e9..09c731b54 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/ManageLabelsForIndividualPreprocessor.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/preprocessors/ManageLabelsForIndividualPreprocessor.java
@@ -3,22 +3,12 @@
package edu.cornell.mannlib.vitro.webapp.edit.n3editing.configuration.preprocessors;
import java.util.ArrayList;
-import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import javax.servlet.http.HttpServletRequest;
-
-import org.apache.jena.ontology.OntModel;
import org.apache.jena.rdf.model.Literal;
-import org.apache.jena.rdf.model.Model;
-import org.apache.jena.rdf.model.Property;
-import org.apache.jena.rdf.model.ResIterator;
-import org.apache.jena.rdf.model.Resource;
-import org.apache.jena.rdf.model.Statement;
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
-import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
/*
* This preprocessor is used to set the language attribute on the label based on the user selection
* on the manage labels page when adding a new label.
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/AntiXssValidation.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/AntiXssValidation.java
index 5c929b670..7604abccc 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/AntiXssValidation.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/AntiXssValidation.java
@@ -92,9 +92,7 @@ public class AntiXssValidation implements N3ValidatorVTwo{
String error = null;
try {
error = literalHasXSS( editSub.getLiteralsFromForm().get(fieldName) );
- } catch (ScanException e) {
- error = e.getMessage();
- } catch (PolicyException e) {
+ } catch (ScanException | PolicyException e) {
error = e.getMessage();
}
if( error != null ){
@@ -109,9 +107,7 @@ public class AntiXssValidation implements N3ValidatorVTwo{
String error;
try {
error = uriHasXSS( editSub.getUrisFromForm().get(fieldName));
- } catch (ScanException e) {
- error = e.getMessage();
- } catch (PolicyException e) {
+ } catch (ScanException | PolicyException e) {
error = e.getMessage();
}
if( error != null ){
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/DefaultDataPropertyFormValidator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/DefaultDataPropertyFormValidator.java
index 8759a42ec..971adc343 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/DefaultDataPropertyFormValidator.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/validators/DefaultDataPropertyFormValidator.java
@@ -6,7 +6,6 @@ import java.util.List;
import java.util.Map;
import java.util.regex.Pattern;
-import org.apache.commons.lang3.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestAJAXController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestAJAXController.java
index d1708939b..6587e42b8 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestAJAXController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestAJAXController.java
@@ -84,14 +84,10 @@ public class EditRequestAJAXController extends VitroHttpServlet {
Class classDefinition = Class.forName(editConfGeneratorName);
object = classDefinition.newInstance();
EditConfigurationVTwoGenerator = (EditConfigurationAJAXGenerator) object;
- } catch (InstantiationException e) {
+ } catch (InstantiationException | ClassNotFoundException | IllegalAccessException e) {
System.out.println(e);
- } catch (IllegalAccessException e) {
- System.out.println(e);
- } catch (ClassNotFoundException e) {
- System.out.println(e);
- }
-
+ }
+
if(EditConfigurationVTwoGenerator == null){
throw new Error("Could not find EditConfigurationVTwoGenerator " + editConfGeneratorName);
} else {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestDispatchController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestDispatchController.java
index f3f98dbd1..69bfba49b 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestDispatchController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/EditRequestDispatchController.java
@@ -335,15 +335,11 @@ public class EditRequestDispatchController extends FreemarkerHttpServlet {
WebappDaoFactory wdf = vreq.getWebappDaoFactory();
//TODO: Check if any error conditions are not met here
//At this point, if there is a form paramter, we don't require a predicate uri
- if(formParam == null
- && predicateUri != null
- && !EditConfigurationUtils.isObjectProperty(predicateUri, vreq)
- && !isVitroLabel(predicateUri)
- && !EditConfigurationUtils.isDataProperty(predicateUri, vreq))
- {
- return true;
- }
- return false;
+ return formParam == null
+ && predicateUri != null
+ && !EditConfigurationUtils.isObjectProperty(predicateUri, vreq)
+ && !isVitroLabel(predicateUri)
+ && !EditConfigurationUtils.isDataProperty(predicateUri, vreq);
}
private String getErrorMessage(VitroRequest vreq) {
@@ -387,10 +383,7 @@ public class EditRequestDispatchController extends FreemarkerHttpServlet {
//TODO: Check how to integrate deletion
private boolean isDeleteForm(VitroRequest vreq) {
String command = vreq.getParameter("cmd");
- if ("delete".equals(command)) {
- return true;
- }
- return false;
+ return "delete".equals(command);
}
@@ -404,14 +397,10 @@ public class EditRequestDispatchController extends FreemarkerHttpServlet {
Class classDefinition = Class.forName(editConfGeneratorName);
object = classDefinition.newInstance();
EditConfigurationVTwoGenerator = (EditConfigurationGenerator) object;
- } catch (InstantiationException e) {
+ } catch (InstantiationException | ClassNotFoundException | IllegalAccessException e) {
System.out.println(e);
- } catch (IllegalAccessException e) {
- System.out.println(e);
- } catch (ClassNotFoundException e) {
- System.out.println(e);
- }
-
+ }
+
if(EditConfigurationVTwoGenerator == null){
throw new Error("Could not find EditConfigurationVTwoGenerator " + editConfGeneratorName);
} else {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/ProcessRdfFormController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/ProcessRdfFormController.java
index 6998738fa..0b21f0586 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/ProcessRdfFormController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/controller/ProcessRdfFormController.java
@@ -152,10 +152,7 @@ public class ProcessRdfFormController extends FreemarkerHttpServlet{
DataProperty dp = wdf.getDataPropertyDao().getDataPropertyByURI(
editConfig.getPredicateUri());
if (dp != null) {
- if (dp.getDisplayLimit() == 1 /* || dp.isFunctional() */)
- return false;
- else
- return true;
+ return dp.getDisplayLimit() != 1;
}
return false;
@@ -231,10 +228,7 @@ public class ProcessRdfFormController extends FreemarkerHttpServlet{
Collections.sort(newValue);
}
if (orgValue != null && newValue != null) {
- if (orgValue.equals(newValue))
- return false;
- else
- return true;
+ return !orgValue.equals(newValue);
}
List orgLit = editConfig.getLiteralsInScope().get(fieldName);
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailFactory.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailFactory.java
index 1c8499341..41c3404d3 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailFactory.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailFactory.java
@@ -256,9 +256,7 @@ public class FreemarkerEmailFactory {
+ factory.getSmtpHost() + "'.");
} catch (NotConfiguredException e) {
ss.info(this, e.getMessage());
- } catch (BadPropertyValueException e) {
- ss.warning(this, e.getMessage());
- } catch (InvalidSmtpHost e) {
+ } catch (BadPropertyValueException | InvalidSmtpHost e) {
ss.warning(this, e.getMessage());
} catch (Exception e) {
ss.warning(this,
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailMessage.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailMessage.java
index e96f08f4c..6462f58af 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailMessage.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/email/FreemarkerEmailMessage.java
@@ -87,8 +87,7 @@ public class FreemarkerEmailMessage {
} catch (AddressException e) {
log.warn("invalid recipient address: " + type + ", '"
+ emailAddress + "'");
- return;
- }
+ }
}
public void addRecipient(RecipientType type, String emailAddress,
@@ -110,8 +109,7 @@ public class FreemarkerEmailMessage {
} catch (UnsupportedEncodingException e) {
log.warn("invalid recipient address: " + type + ", '"
+ emailAddress + "', personal name '" + personalName + "'");
- return;
- }
+ }
}
public void setSubject(String subject) {
@@ -144,12 +142,10 @@ public class FreemarkerEmailMessage {
try {
config.getTemplate(templateName).process(bodyMap,
new StringWriter());
- } catch (TemplateException e) {
- log.error(e, e);
- } catch (IOException e) {
+ } catch (TemplateException | IOException e) {
log.error(e, e);
}
- }
+ }
public boolean send() {
try {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filestorage/model/FileInfo.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filestorage/model/FileInfo.java
index 494db041a..ae94abd90 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filestorage/model/FileInfo.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filestorage/model/FileInfo.java
@@ -62,9 +62,9 @@ public class FileInfo {
.getObjectPropertyStatements(opStmt);
if (stmts.size() > 1) {
- String uris = "";
+ StringBuilder uris = new StringBuilder();
for (ObjectPropertyStatement stmt : stmts) {
- uris += "'" + stmt.getSubjectURI() + "' ";
+ uris.append("'").append(stmt.getSubjectURI()).append("' ");
}
log.warn("Found " + stmts.size() + " Individuals that claim '"
+ entity.getURI() + "' as its bytestream:" + uris);
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/RequestLoggerFilter.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/RequestLoggerFilter.java
index 4caa47704..52dc76aa2 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/RequestLoggerFilter.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/RequestLoggerFilter.java
@@ -34,7 +34,7 @@ public class RequestLoggerFilter implements Filter {
try {
if (request instanceof HttpServletRequest) {
HttpServletRequest theRequest = (HttpServletRequest) request;
- StringBuffer requestedLocation = new StringBuffer();
+ StringBuilder requestedLocation = new StringBuilder();
requestedLocation.append(theRequest.getLocalName()).append(":");
requestedLocation.append(theRequest.getLocalPort());
requestedLocation.append(theRequest.getRequestURI());
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/VitroURL.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/VitroURL.java
index 718c06287..5621215ab 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/VitroURL.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/filters/VitroURL.java
@@ -7,6 +7,7 @@ import java.net.URL;
import java.net.URLDecoder;
import java.net.URLEncoder;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.regex.Pattern;
@@ -130,9 +131,7 @@ class VitroURL {
}
// TODO: rewrite the chunk above with lists in mind.
List strList = new ArrayList();
- for (int i=0; i nameSet, String[] nameArray) {
Set allNames = new HashSet<>(nameSet);
- for (String n : nameArray) {
- allNames.add(n);
- }
+ Collections.addAll(allNames, nameArray);
return (String[]) allNames.toArray();
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/imageio/IIOImageProcessor.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/imageio/IIOImageProcessor.java
index 5d47f62b6..5e0ea8ec3 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/imageio/IIOImageProcessor.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/imageio/IIOImageProcessor.java
@@ -15,7 +15,6 @@ import java.awt.geom.AffineTransform;
import java.awt.image.AffineTransformOp;
import java.awt.image.BufferedImage;
import java.awt.image.ColorConvertOp;
-import java.awt.image.ColorModel;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/jai/JaiImageProcessor.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/jai/JaiImageProcessor.java
index b6d55a718..6cbabd146 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/jai/JaiImageProcessor.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/imageprocessor/jai/JaiImageProcessor.java
@@ -5,7 +5,6 @@ package edu.cornell.mannlib.vitro.webapp.imageprocessor.jai;
import edu.cornell.mannlib.vitro.webapp.imageprocessor.imageio.IIOImageProcessor;
import edu.cornell.mannlib.vitro.webapp.modules.Application;
import edu.cornell.mannlib.vitro.webapp.modules.ComponentStartupStatus;
-import edu.cornell.mannlib.vitro.webapp.modules.imageProcessor.ImageProcessor;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/ABoxUpdater.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/ABoxUpdater.java
index 37024e1e8..c2b54656d 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/ABoxUpdater.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/ABoxUpdater.java
@@ -31,8 +31,6 @@ import org.apache.jena.vocabulary.RDF;
import edu.cornell.mannlib.vitro.webapp.dao.jena.RDFServiceDataset;
import edu.cornell.mannlib.vitro.webapp.ontology.update.AtomicOntologyChange.AtomicChangeType;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService;
-import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFServiceException;
-import edu.cornell.mannlib.vitro.webapp.rdfservice.impl.RDFServiceUtils;
/**
* Performs knowledge base updates to the abox to align with a new ontology version
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/KnowledgeBaseUpdater.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/KnowledgeBaseUpdater.java
index aa6240824..f975f1268 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/KnowledgeBaseUpdater.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/KnowledgeBaseUpdater.java
@@ -171,7 +171,7 @@ public class KnowledgeBaseUpdater {
if(sparqlFile.isDirectory()) {
continue;
}
- StringBuffer fileContents = new StringBuffer();
+ StringBuilder fileContents = new StringBuilder();
try {
BufferedReader reader = new BufferedReader(new FileReader(sparqlFile));
String ln;
@@ -371,7 +371,7 @@ public class KnowledgeBaseUpdater {
throw new RuntimeException("SPARQL file not found at " + filePath);
}
BufferedReader reader = new BufferedReader(new FileReader(file));
- StringBuffer fileContents = new StringBuffer();
+ StringBuilder fileContents = new StringBuilder();
String ln;
while ((ln = reader.readLine()) != null) {
fileContents.append(ln).append('\n');
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/OntologyChangeParser.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/OntologyChangeParser.java
index c23ae7998..7c5e48d52 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/OntologyChangeParser.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/OntologyChangeParser.java
@@ -7,7 +7,6 @@ import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.ArrayList;
-import java.util.List;
import java.util.StringTokenizer;
import org.apache.commons.csv.CSVFormat;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/TBoxUpdater.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/TBoxUpdater.java
index 045944281..93f445861 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/TBoxUpdater.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/ontology/update/TBoxUpdater.java
@@ -13,7 +13,6 @@ import org.apache.commons.logging.LogFactory;
import org.apache.jena.ontology.OntModel;
import org.apache.jena.ontology.OntModelSpec;
-import org.apache.jena.query.Dataset;
import org.apache.jena.query.Query;
import org.apache.jena.query.QueryExecution;
import org.apache.jena.query.QueryExecutionFactory;
@@ -33,8 +32,6 @@ import org.apache.jena.vocabulary.RDF;
import org.apache.jena.vocabulary.RDFS;
import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
-import edu.cornell.mannlib.vitro.webapp.dao.jena.RDFServiceDataset;
-import edu.cornell.mannlib.vitro.webapp.servlet.setup.JenaDataSourceSetupBase;
/**
* Performs knowledge base updates to the tbox to align with a new ontology version
@@ -398,7 +395,7 @@ public class TBoxUpdater {
model.enterCriticalSection(Lock.READ);
try {
- return (model.contains((Resource) null, inClassGroupProp, theClassGroup) ? true : false);
+ return (model.contains((Resource) null, inClassGroupProp, theClassGroup));
} finally {
model.leaveCriticalSection();
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingModel.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingModel.java
index e21b3e047..cce2808d4 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingModel.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingModel.java
@@ -4,25 +4,20 @@ package edu.cornell.mannlib.vitro.webapp.rdfservice.adapters;
import edu.cornell.mannlib.vitro.webapp.dao.jena.RDFServiceGraph;
import edu.cornell.mannlib.vitro.webapp.dao.jena.SparqlGraph;
-import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService;
import org.apache.jena.graph.Graph;
-import org.apache.jena.graph.Triple;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelFactory;
import org.apache.jena.rdf.model.RDFReaderF;
import org.apache.jena.rdf.model.Statement;
import org.apache.jena.rdf.model.StmtIterator;
import org.apache.jena.rdf.model.impl.RDFReaderFImpl;
-import org.apache.jena.rdf.model.impl.StatementImpl;
import org.apache.jena.shared.WrappedIOException;
import org.apache.jena.sparql.graph.GraphFactory;
-import org.apache.jena.util.iterator.Map1;
import java.io.IOException;
import java.io.InputStream;
import java.io.Reader;
import java.net.URL;
-import java.util.Iterator;
import java.util.List;
public class BulkUpdatingModel extends AbstractModelDecorator {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingOntModel.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingOntModel.java
index fae3259d4..9fb336c6d 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingOntModel.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/BulkUpdatingOntModel.java
@@ -12,7 +12,6 @@ import org.apache.jena.rdf.model.RDFReaderF;
import org.apache.jena.rdf.model.Statement;
import org.apache.jena.rdf.model.StmtIterator;
import org.apache.jena.rdf.model.impl.RDFReaderFImpl;
-import org.apache.jena.rdf.model.impl.StatementImpl;
import org.apache.jena.shared.WrappedIOException;
import org.apache.jena.sparql.graph.GraphFactory;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/MemoryMappedModel.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/MemoryMappedModel.java
index 86b77bda6..6d8aacd4d 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/MemoryMappedModel.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/MemoryMappedModel.java
@@ -5,14 +5,11 @@ package edu.cornell.mannlib.vitro.webapp.rdfservice.adapters;
import java.util.List;
import java.util.Set;
-import edu.cornell.mannlib.vitro.webapp.dao.jena.VitroModelSource;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelChangedListener;
-import org.apache.jena.rdf.model.Property;
-import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.Statement;
import org.apache.jena.rdf.model.StmtIterator;
import org.apache.jena.rdf.model.impl.StmtIteratorImpl;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/RDFServiceBulkUpdater.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/RDFServiceBulkUpdater.java
index 1c09ce6da..6a8a72703 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/RDFServiceBulkUpdater.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/RDFServiceBulkUpdater.java
@@ -8,7 +8,6 @@ import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFServiceException;
import edu.cornell.mannlib.vitro.webapp.rdfservice.impl.RDFServiceUtils;
import org.apache.jena.graph.GraphEvents;
-import org.apache.jena.graph.Node;
import org.apache.jena.rdf.model.Model;
import java.io.ByteArrayInputStream;
@@ -57,11 +56,11 @@ public class RDFServiceBulkUpdater extends AbstractBulkUpdater {
String findPattern = "?s ?p ?o";
- StringBuffer findQuery = new StringBuffer("CONSTRUCT { ")
+ StringBuilder findQuery = new StringBuilder("CONSTRUCT { ")
.append(findPattern)
.append(" } WHERE { \n");
if (graphURI != null) {
- findQuery.append(" GRAPH <" + graphURI + "> { ");
+ findQuery.append(" GRAPH <").append(graphURI).append("> { ");
}
findQuery.append(findPattern);
if (graphURI != null) {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/SparqlBulkUpdater.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/SparqlBulkUpdater.java
index 89f241f19..bdd7b9568 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/SparqlBulkUpdater.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/adapters/SparqlBulkUpdater.java
@@ -42,11 +42,11 @@ public class SparqlBulkUpdater extends AbstractBulkUpdater {
if (count % testLimit == 0 || !stmtIt.hasNext()) {
StringWriter sw = new StringWriter();
m.write(sw, "N-TRIPLE");
- StringBuffer updateStringBuff = new StringBuffer();
+ StringBuilder updateStringBuff = new StringBuilder();
String graphURI = graph.getGraphURI();
- updateStringBuff.append(verb + " DATA { " + ((graphURI != null) ? "GRAPH <" + graphURI + "> { " : "" ));
+ updateStringBuff.append(verb).append(" DATA { ").append((graphURI != null) ? "GRAPH <" + graphURI + "> { " : "");
updateStringBuff.append(sw);
- updateStringBuff.append(((graphURI != null) ? " } " : "") + " }");
+ updateStringBuff.append((graphURI != null) ? " } " : "").append(" }");
String updateString = updateStringBuff.toString();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/RDFServiceImpl.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/RDFServiceImpl.java
index f372b3926..85c5e6d34 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/RDFServiceImpl.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/RDFServiceImpl.java
@@ -40,7 +40,6 @@ import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFServiceException;
import edu.cornell.mannlib.vitro.webapp.rdfservice.ResultSetConsumer;
import edu.cornell.mannlib.vitro.webapp.utils.logging.ToString;
-import org.vivoweb.linkeddatafragments.datasource.rdfservice.RDFServiceBasedRequestProcessorForTPFs;
public abstract class RDFServiceImpl implements RDFService {
@@ -64,9 +63,9 @@ public abstract class RDFServiceImpl implements RDFService {
String individualTypeURI,
String graphURI) throws RDFServiceException {
- StringBuffer containsQuery = new StringBuffer("ASK { \n");
+ StringBuilder containsQuery = new StringBuilder("ASK { \n");
if (graphURI != null) {
- containsQuery.append(" GRAPH <" + graphURI + "> { ");
+ containsQuery.append(" GRAPH <").append(graphURI).append("> { ");
}
containsQuery.append("<");
containsQuery.append(individualURI);
@@ -229,7 +228,7 @@ public abstract class RDFServiceImpl implements RDFService {
}
protected static String sparqlTriple(Triple triple) {
- StringBuffer serializedTriple = new StringBuffer();
+ StringBuilder serializedTriple = new StringBuilder();
serializedTriple.append(sparqlNodeUpdate(triple.getSubject(), ""));
serializedTriple.append(" ");
serializedTriple.append(sparqlNodeUpdate(triple.getPredicate(), ""));
@@ -254,7 +253,7 @@ public abstract class RDFServiceImpl implements RDFService {
} else if (node.isBlank()) {
return ""; // or throw exception?
} else if (node.isURI()) {
- StringBuffer uriBuff = new StringBuffer();
+ StringBuilder uriBuff = new StringBuilder();
return uriBuff.append("<").append(node.getURI()).append(">").toString();
} else if (node.isLiteral()) {
StringBuffer literalBuff = new StringBuffer();
@@ -442,7 +441,7 @@ public abstract class RDFServiceImpl implements RDFService {
if (node.isLiteral()) {
builder.append(literalToString(node.asLiteral()));
} else if (node.isURIResource()) {
- builder.append('<' + node.asResource().getURI() + '>');
+ builder.append('<').append(node.asResource().getURI()).append('>');
}
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/RDFServiceJena.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/RDFServiceJena.java
index 5a37a42ab..634269099 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/RDFServiceJena.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/RDFServiceJena.java
@@ -258,9 +258,9 @@ public abstract class RDFServiceJena extends RDFServiceImpl implements RDFServic
}
private String makeDescribe(Resource s) {
- StringBuffer query = new StringBuffer("DESCRIBE <") ;
+ StringBuilder query = new StringBuilder("DESCRIBE <") ;
if (s.isAnon()) {
- query.append("_:" + s.getId().toString());
+ query.append("_:").append(s.getId().toString());
} else {
query.append(s.getURI());
}
@@ -283,7 +283,7 @@ public abstract class RDFServiceJena extends RDFServiceImpl implements RDFServic
addStatementPatterns(stmts, queryBuff, !WHERE_CLAUSE);
queryBuff.append("} WHERE { \n");
if (graphURI != null) {
- queryBuff.append(" GRAPH <" + graphURI + "> { \n");
+ queryBuff.append(" GRAPH <").append(graphURI).append("> { \n");
}
stmtIt = model.listStatements();
stmts = stmtIt.toList();
@@ -376,10 +376,10 @@ public abstract class RDFServiceJena extends RDFServiceImpl implements RDFServic
patternBuff.append(" .\n");
if (whereClause) {
if (t.getSubject().isBlank()) {
- patternBuff.append(" FILTER(isBlank(" + SparqlGraph.sparqlNodeDelete(t.getSubject(), null)).append(")) \n");
+ patternBuff.append(" FILTER(isBlank(").append(SparqlGraph.sparqlNodeDelete(t.getSubject(), null)).append(")) \n");
}
if (t.getObject().isBlank()) {
- patternBuff.append(" FILTER(isBlank(" + SparqlGraph.sparqlNodeDelete(t.getObject(), null)).append(")) \n");
+ patternBuff.append(" FILTER(isBlank(").append(SparqlGraph.sparqlNodeDelete(t.getObject(), null)).append(")) \n");
}
}
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/sdb/RDFServiceSDB.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/sdb/RDFServiceSDB.java
index 47cdd08f8..426c1ae34 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/sdb/RDFServiceSDB.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/jena/sdb/RDFServiceSDB.java
@@ -36,8 +36,6 @@ import org.apache.jena.sdb.sql.SDBConnection;
import edu.cornell.mannlib.vitro.webapp.dao.jena.DatasetWrapper;
import edu.cornell.mannlib.vitro.webapp.dao.jena.StaticDatasetFactory;
-import edu.cornell.mannlib.vitro.webapp.dao.jena.event.BulkUpdateEvent;
-import edu.cornell.mannlib.vitro.webapp.rdfservice.ChangeListener;
import edu.cornell.mannlib.vitro.webapp.rdfservice.ChangeSet;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFService;
import edu.cornell.mannlib.vitro.webapp.rdfservice.RDFServiceException;
@@ -175,7 +173,7 @@ public class RDFServiceSDB extends RDFServiceJena implements RDFService {
Statement stmt = sdbConn.getSqlConnection().createStatement();
ResultSet rs = stmt.executeQuery("SELECT count(DISTINCT s,p,o) AS tcount FROM Quads" + (StringUtils.isEmpty(whereClause) ? "" : " WHERE " + whereClause));
try {
- while (rs.next()) {
+ if (rs.next()) {
return rs.getLong("tcount");
}
} finally {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparql.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparql.java
index dbd2b673e..4db1ea7e7 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparql.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparql.java
@@ -331,10 +331,8 @@ public class RDFServiceSparql extends RDFServiceImpl implements RDFService {
} finally {
EntityUtils.consume(response.getEntity());
}
- } catch (IOException ioe) {
+ } catch (IOException | URISyntaxException ioe) {
throw new RuntimeException(ioe);
- } catch (URISyntaxException e) {
- throw new RuntimeException(e);
}
}
@@ -361,10 +359,8 @@ public class RDFServiceSparql extends RDFServiceImpl implements RDFService {
} finally {
EntityUtils.consume(response.getEntity());
}
- } catch (IOException ioe) {
+ } catch (IOException | URISyntaxException ioe) {
throw new RuntimeException(ioe);
- } catch (URISyntaxException e) {
- throw new RuntimeException(e);
}
}
@@ -549,10 +545,10 @@ public class RDFServiceSparql extends RDFServiceImpl implements RDFService {
if (count % CHUNK_SIZE == 0 || !stmtIt.hasNext()) {
StringWriter sw = new StringWriter();
m.write(sw, "N-TRIPLE");
- StringBuffer updateStringBuff = new StringBuffer();
- updateStringBuff.append(verb + " DATA { " + ((graphURI != null) ? "GRAPH <" + graphURI + "> { " : "" ));
+ StringBuilder updateStringBuff = new StringBuilder();
+ updateStringBuff.append(verb).append(" DATA { ").append((graphURI != null) ? "GRAPH <" + graphURI + "> { " : "");
updateStringBuff.append(sw);
- updateStringBuff.append(((graphURI != null) ? " } " : "") + " }");
+ updateStringBuff.append((graphURI != null) ? " } " : "").append(" }");
String updateString = updateStringBuff.toString();
@@ -762,7 +758,7 @@ public class RDFServiceSparql extends RDFServiceImpl implements RDFService {
StringBuffer queryBuff = new StringBuffer();
if (graphURI != null) {
- queryBuff.append("WITH <" + graphURI + "> \n");
+ queryBuff.append("WITH <").append(graphURI).append("> \n");
}
queryBuff.append("DELETE { \n");
List stmts = stmtIt.toList();
@@ -838,19 +834,19 @@ public class RDFServiceSparql extends RDFServiceImpl implements RDFService {
patternBuff.append(" .\n");
if (whereClause) {
if (t.getSubject().isBlank()) {
- patternBuff.append(" FILTER(isBlank(" + SparqlGraph.sparqlNodeDelete(t.getSubject(), null)).append(")) \n");
+ patternBuff.append(" FILTER(isBlank(").append(SparqlGraph.sparqlNodeDelete(t.getSubject(), null)).append(")) \n");
}
if (t.getObject().isBlank()) {
- patternBuff.append(" FILTER(isBlank(" + SparqlGraph.sparqlNodeDelete(t.getObject(), null)).append(")) \n");
+ patternBuff.append(" FILTER(isBlank(").append(SparqlGraph.sparqlNodeDelete(t.getObject(), null)).append(")) \n");
}
}
}
}
private String makeDescribe(org.apache.jena.rdf.model.Resource s) {
- StringBuffer query = new StringBuffer("DESCRIBE <") ;
+ StringBuilder query = new StringBuilder("DESCRIBE <") ;
if (s.isAnon()) {
- query.append("_:" + s.getId().toString());
+ query.append("_:").append(s.getId().toString());
} else {
query.append(s.getURI());
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparqlHttp.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparqlHttp.java
index 627136669..8db031c24 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparqlHttp.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/sparql/RDFServiceSparqlHttp.java
@@ -6,8 +6,6 @@ import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.InputStream;
-import org.apache.jena.query.QueryExecution;
-import org.apache.jena.query.QueryExecutionFactory;
import org.apache.jena.query.ResultSet;
import org.apache.jena.query.ResultSetFormatter;
import org.apache.jena.rdf.model.Model;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/virtuoso/RDFServiceVirtuoso.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/virtuoso/RDFServiceVirtuoso.java
index d502ace88..1a0eaa4ed 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/virtuoso/RDFServiceVirtuoso.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/rdfservice/impl/virtuoso/RDFServiceVirtuoso.java
@@ -6,7 +6,6 @@ import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;
-import java.io.UnsupportedEncodingException;
import java.util.ArrayList;
import java.util.List;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/ABoxRecomputer.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/ABoxRecomputer.java
index 45e96c745..9fd4cca96 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/ABoxRecomputer.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/ABoxRecomputer.java
@@ -498,14 +498,12 @@ public class ABoxRecomputer {
protected void addInferenceStatementsFor(String individualUri, Model addTo) throws RDFServiceException {
StringBuilder builder = new StringBuilder();
builder.append("CONSTRUCT\n")
- .append("{\n")
- .append(" <" + individualUri + "> ?p ?o .\n")
+ .append("{\n").append(" <").append(individualUri).append("> ?p ?o .\n")
.append("}\n")
.append("WHERE\n")
.append("{\n")
.append(" GRAPH <").append(ModelNames.ABOX_INFERENCES).append(">\n")
- .append(" {\n")
- .append(" <" + individualUri + "> ?p ?o .\n")
+ .append(" {\n").append(" <").append(individualUri).append("> ?p ?o .\n")
.append(" }\n")
.append("}\n");
@@ -563,10 +561,8 @@ public class ABoxRecomputer {
.append(" ?object\n")
.append("WHERE {\n")
.append(" GRAPH ?g { \n")
- .append(" {\n")
- .append(" <" + individualUri + "> <" + OWL.sameAs + "> ?object .\n")
- .append(" } UNION {\n")
- .append(" ?object <" + OWL.sameAs + "> <" + individualUri + "> .\n")
+ .append(" {\n").append(" <").append(individualUri).append("> <").append(OWL.sameAs).append("> ?object .\n")
+ .append(" } UNION {\n").append(" ?object <").append(OWL.sameAs).append("> <").append(individualUri).append("> .\n")
.append(" }\n")
.append(" } \n")
.append(" FILTER (?g != <" + ModelNames.ABOX_INFERENCES + ">)\n")
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/SimpleReasoner.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/SimpleReasoner.java
index 67df12735..4c60103bb 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/SimpleReasoner.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/SimpleReasoner.java
@@ -24,10 +24,8 @@ import org.apache.jena.rdf.model.Literal;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelChangedListener;
import org.apache.jena.rdf.model.ModelFactory;
-import org.apache.jena.rdf.model.NodeIterator;
import org.apache.jena.rdf.model.Property;
import org.apache.jena.rdf.model.RDFNode;
-import org.apache.jena.rdf.model.ResIterator;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.ResourceFactory;
import org.apache.jena.rdf.model.Statement;
@@ -989,8 +987,7 @@ public class SimpleReasoner extends StatementListener
}
setMostSpecificTypes(individual, typeURIs, inferenceModel);
- return;
- }
+ }
protected void setMostSpecificTypes(Resource individual, HashSet typeURIs, Model inferenceModel) {
@@ -1027,10 +1024,9 @@ public class SimpleReasoner extends StatementListener
String typeURI = typeIter.next();
Statement mstStmt = ResourceFactory.createStatement(individual,mostSpecificType,ResourceFactory.createResource(typeURI));
addInference(mstStmt,inferenceModel,true);
- }
-
- return;
- }
+ }
+
+ }
protected List getParents(Resource cls, OntModel tboxModel) {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/DisableSameAs.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/DisableSameAs.java
index e86a5f964..07c69a6ba 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/DisableSameAs.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/DisableSameAs.java
@@ -47,15 +47,13 @@ public class DisableSameAs implements ReasonerPlugin {
Model aboxAssertionsModel,
Model aboxInferencesModel,
OntModel TBoxInferencesModel) {
- return;
- }
+ }
public void removedABoxStatement(Statement stmt,
Model aboxAssertionsModel,
Model aboxInferencesModel,
OntModel TBoxInferencesModel) {
- return;
}
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/SimpleBridgingRule.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/SimpleBridgingRule.java
index 8f8f23ccd..b822ccdb5 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/SimpleBridgingRule.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/reasoner/plugin/SimpleBridgingRule.java
@@ -100,7 +100,7 @@ public abstract class SimpleBridgingRule implements ReasonerPlugin {
}
private Query createQuery(String queryString, Statement stmt, Statement statement2) {
- String queryStr = new String(queryString);
+ String queryStr = queryString;
if (stmt.getPredicate().equals(assertedProp1)) {
queryStr = queryStr.replace(
"?x", "<" + stmt.getSubject().getURI() + ">");
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/AutocompleteController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/AutocompleteController.java
index 5d3a48c1f..1b253da15 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/AutocompleteController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/AutocompleteController.java
@@ -7,9 +7,7 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
import javax.servlet.ServletException;
import javax.servlet.annotation.WebServlet;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/DataAutocompleteController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/DataAutocompleteController.java
index b6596e7bf..bfb7c16d6 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/DataAutocompleteController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/DataAutocompleteController.java
@@ -83,7 +83,6 @@ public class DataAutocompleteController extends VitroAjaxController {
Model model = getModel(vreq);
Query query = SparqlUtils.createQuery(sparqlQuery);
outputResults(response, query, model);
- return;
} catch(AjaxControllerException ex) {
log.error(ex, ex);
response.sendError(ex.getStatusCode());
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
index 2edd8599c..1ee28176e 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/PagedSearchController.java
@@ -452,12 +452,12 @@ public class PagedSearchController extends FreemarkerHttpServlet {
private String getSnippet(SearchResultDocument doc, SearchResponse response) {
String docId = doc.getStringValue(VitroSearchTermNames.DOCID);
- StringBuffer text = new StringBuffer();
+ StringBuilder text = new StringBuilder();
Map>> highlights = response.getHighlighting();
if (highlights != null && highlights.get(docId) != null) {
List snippets = highlights.get(docId).get(VitroSearchTermNames.ALLTEXT);
if (snippets != null && snippets.size() > 0) {
- text.append("... " + snippets.get(0) + " ...");
+ text.append("... ").append(snippets.get(0)).append(" ...");
}
}
return text.toString();
@@ -649,11 +649,7 @@ public class PagedSearchController extends FreemarkerHttpServlet {
protected boolean isRequestedFormatXml(VitroRequest req){
if( req != null ){
String param = req.getParameter(PARAM_XML_REQUEST);
- if( param != null && "1".equals(param)){
- return true;
- }else{
- return false;
- }
+ return param != null && "1".equals(param);
}else{
return false;
}
@@ -662,11 +658,7 @@ public class PagedSearchController extends FreemarkerHttpServlet {
protected boolean isRequestedFormatCSV(VitroRequest req){
if( req != null ){
String param = req.getParameter(PARAM_CSV_REQUEST);
- if( param != null && "1".equals(param)){
- return true;
- }else{
- return false;
- }
+ return param != null && "1".equals(param);
}else{
return false;
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchHelpController.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchHelpController.java
index 2cfceb28e..54396b76c 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchHelpController.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/search/controller/SearchHelpController.java
@@ -1,34 +1,18 @@
/* $This file is distributed under the terms of the license in LICENSE$ */
package edu.cornell.mannlib.vitro.webapp.search.controller;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
import java.util.HashMap;
import java.util.Map;
-import java.util.Enumeration;
-import javax.servlet.RequestDispatcher;
import javax.servlet.annotation.WebServlet;
-import javax.servlet.http.HttpServletResponse;
-import javax.servlet.http.HttpSession;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.jena.query.QuerySolution;
-import org.apache.jena.query.ResultSet;
-import org.apache.jena.rdf.model.Literal;
-import org.apache.jena.rdf.model.RDFNode;
-import org.apache.jena.datatypes.RDFDatatype ;
-
-import edu.cornell.mannlib.vitro.webapp.beans.Individual;
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
import edu.cornell.mannlib.vitro.webapp.controller.freemarker.FreemarkerHttpServlet;
import edu.cornell.mannlib.vitro.webapp.controller.freemarker.responsevalues.ResponseValues;
import edu.cornell.mannlib.vitro.webapp.controller.freemarker.responsevalues.TemplateResponseValues;
-import edu.cornell.mannlib.vitro.webapp.dao.jena.QueryUtils;
-import edu.cornell.mannlib.vitro.webapp.dao.WebappDaoFactory;
@WebServlet(name = "SearchHelpController", urlPatterns = {"/searchHelp"} )
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/solr/SolrConversionUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/solr/SolrConversionUtils.java
index a721d6ce3..0099bc44e 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/solr/SolrConversionUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchengine/solr/SolrConversionUtils.java
@@ -24,7 +24,6 @@ import edu.cornell.mannlib.vitro.webapp.modules.searchEngine.SearchInputField;
import edu.cornell.mannlib.vitro.webapp.modules.searchEngine.SearchQuery;
import edu.cornell.mannlib.vitro.webapp.modules.searchEngine.SearchQuery.Order;
import edu.cornell.mannlib.vitro.webapp.modules.searchEngine.SearchResponse;
-import edu.cornell.mannlib.vitro.webapp.search.VitroSearchTermNames;
import edu.cornell.mannlib.vitro.webapp.searchengine.base.BaseSearchFacetField;
import edu.cornell.mannlib.vitro.webapp.searchengine.base.BaseSearchFacetField.BaseCount;
import edu.cornell.mannlib.vitro.webapp.searchengine.base.BaseSearchResponse;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/IndexingChangeListener.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/IndexingChangeListener.java
index 6781c8762..0cd389526 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/IndexingChangeListener.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/IndexingChangeListener.java
@@ -6,7 +6,6 @@ import static edu.cornell.mannlib.vitro.webapp.modules.searchIndexer.SearchIndex
import static edu.cornell.mannlib.vitro.webapp.modules.searchIndexer.SearchIndexer.Event.Type.START_REBUILD;
import java.util.ArrayList;
-import java.util.Iterator;
import java.util.List;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
@@ -14,10 +13,7 @@ import java.util.concurrent.TimeUnit;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.jena.riot.tokens.Tokenizer;
-import org.apache.jena.riot.tokens.TokenizerFactory;
-import org.apache.jena.graph.Triple;
import org.apache.jena.rdf.listeners.StatementListener;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelChangedListener;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/DocumentModifierListDeveloper.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/DocumentModifierListDeveloper.java
index 562dc9d15..093e88ade 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/DocumentModifierListDeveloper.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/DocumentModifierListDeveloper.java
@@ -61,19 +61,19 @@ public class DocumentModifierListDeveloper implements DocumentModifierList {
*/
@Override
public void stopIndexing() {
- String message = String.format(
+ StringBuilder message = new StringBuilder(String.format(
"Timings for %d modifiers after %d calls:", timings.size(),
- count.get());
+ count.get()));
for (ModifierTiming timing : timings) {
int totalMillis = timing.getTotal();
float totalSeconds = totalMillis / 1000.0F;
int average = (count.get() == 0) ? 0 : totalMillis / count.get();
- message += String
+ message.append(String
.format("\n count: %7d, total: %9.3fsec, average: %4dms-- %1.200s",
count.get(), totalSeconds, average,
- timing.getModifier());
+ timing.getModifier()));
}
- log.info(message);
+ log.info(message.toString());
}
private static class ModifierTiming {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/ThumbnailImageURL.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/ThumbnailImageURL.java
index cfabec6a1..f2f2e1f3f 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/ThumbnailImageURL.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/documentBuilding/ThumbnailImageURL.java
@@ -67,7 +67,7 @@ public class ThumbnailImageURL implements DocumentModifier, ContextModelsUser {
}
protected String runQueryForThumbnailLocation(Individual individual) {
- StringBuffer result = new StringBuffer();
+ StringBuilder result = new StringBuilder();
String uri = "<" + individual.getURI() + "> ";
String query = QUERY_TEMPLATE.replaceAll("\\?uri", uri);
@@ -81,7 +81,7 @@ public class ThumbnailImageURL implements DocumentModifier, ContextModelsUser {
String name = iter.next();
RDFNode node = soln.get( name );
if( node != null ){
- result.append("" + node.toString());
+ result.append("").append(node.toString());
}else{
log.info(name + " is null");
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/exclusions/ExcludeBasedOnTypeNamespace.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/exclusions/ExcludeBasedOnTypeNamespace.java
index 3817bad72..f5c765830 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/exclusions/ExcludeBasedOnTypeNamespace.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/searchindex/exclusions/ExcludeBasedOnTypeNamespace.java
@@ -27,12 +27,12 @@ public class ExcludeBasedOnTypeNamespace implements SearchIndexExcluder {
@Validation
public void compileRegexPattern() {
- String nsOrPattern = "";
+ StringBuilder nsOrPattern = new StringBuilder();
for( int i=0; i";
- respo += "";
+ StringBuilder respo = new StringBuilder("");
+ respo.append("");
while (classGroupIt.hasNext()) {
VClassGroup group = (VClassGroup) classGroupIt.next();
@@ -81,12 +81,10 @@ public class GetAllClasses extends BaseEditController {
Iterator classIt = classes.iterator();
while (classIt.hasNext()) {
VClass clazz = (VClass) classIt.next();
- respo += "";
+ respo.append("");
}
}
- respo += "";
+ respo.append("");
out.println(respo);
out.flush();
out.close();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetAllPrefix.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetAllPrefix.java
index 6e3998b54..97d35abdb 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetAllPrefix.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetAllPrefix.java
@@ -69,15 +69,15 @@ public class GetAllPrefix extends BaseEditController {
response.setContentType("text/xml");
response.setCharacterEncoding("UTF-8");
PrintWriter out = response.getWriter();
- String respo = "";
- respo += "";
+ StringBuilder respo = new StringBuilder("");
+ respo.append("");
List prefixList = new ArrayList();
prefixList.addAll(prefixMap.keySet());
Collections.sort(prefixList, vreq.getCollator());
for (String prefix : prefixList) {
- respo += makeOption(prefix, prefixMap.get(prefix));
+ respo.append(makeOption(prefix, prefixMap.get(prefix)));
}
- respo += "";
+ respo.append("");
out.println(respo);
out.flush();
out.close();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzAllProperties.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzAllProperties.java
index ba27c6136..6019853a0 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzAllProperties.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzAllProperties.java
@@ -143,20 +143,17 @@ public class GetClazzAllProperties extends BaseEditController {
}
}
}
- String respo = "";
- respo += "";
+ StringBuilder respo = new StringBuilder("");
+ respo.append("");
Object[] keys = hm.keySet().toArray();
Arrays.sort(keys);
for (int i = 0; i < keys.length; i++) {
String key = (String) keys[i];
String value = hm.get(key);
- respo += "";
+ respo.append("");
}
- respo += "";
+ respo.append("");
response.setContentType("text/xml");
response.setCharacterEncoding("UTF-8");
PrintWriter out = response.getWriter();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzDataProperties.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzDataProperties.java
index fdd7a0458..00922ffd9 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzDataProperties.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzDataProperties.java
@@ -44,13 +44,11 @@ public class GetClazzDataProperties extends BaseEditController {
return;
}
- String respo = "";
- respo += "";
+ StringBuilder respo = new StringBuilder("");
+ respo.append("");
// Add rdfs:label to the list
- respo += "";
+ respo.append("");
DataPropertyDao ddao = vreq.getUnfilteredWebappDaoFactory()
.getDataPropertyDao();
@@ -66,13 +64,11 @@ public class GetClazzDataProperties extends BaseEditController {
DataProperty dprop = (DataProperty) ddao
.getDataPropertyByURI(dp.getURI());
if (dprop != null) {
- respo += "";
+ respo.append("");
}
}
}
- respo += "";
+ respo.append("");
response.setContentType("text/xml");
response.setCharacterEncoding("UTF-8");
PrintWriter out = response.getWriter();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzObjectProperties.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzObjectProperties.java
index 9a8fa1497..75011f9ae 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzObjectProperties.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetClazzObjectProperties.java
@@ -51,8 +51,8 @@ public class GetClazzObjectProperties extends BaseEditController {
return;
}
- String respo = "";
- respo += "";
+ StringBuilder respo = new StringBuilder("");
+ respo.append("");
ObjectPropertyDao odao = vreq.getUnfilteredWebappDaoFactory()
.getObjectPropertyDao();
@@ -90,13 +90,11 @@ public class GetClazzObjectProperties extends BaseEditController {
ObjectProperty oprop = (ObjectProperty) odao
.getObjectPropertyByURI(pi.getPropertyURI());
if (oprop != null) {
- respo += "";
+ respo.append("");
}
}
}
- respo += "";
+ respo.append("");
response.setContentType("text/xml");
response.setCharacterEncoding("UTF-8");
PrintWriter out = response.getWriter();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetObjectClasses.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetObjectClasses.java
index db83a2f0a..19fb1dc15 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetObjectClasses.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/sparql/GetObjectClasses.java
@@ -72,11 +72,10 @@ public class GetObjectClasses extends BaseEditController {
response.setContentType("text/xml");
response.setCharacterEncoding("UTF-8");
PrintWriter out = response.getWriter();
- String respo = "";
- respo += "";
+ StringBuilder respo = new StringBuilder("");
+ respo.append("");
if (vClass != null) {
- respo += "";
+ respo.append("");
} else {
List classGroups = vreq.getUnfilteredWebappDaoFactory()
.getVClassGroupDao().getPublicGroupsWithVClasses(true,
@@ -91,9 +90,7 @@ public class GetObjectClasses extends BaseEditController {
Iterator classIt = classes.iterator();
while (classIt.hasNext()) {
VClass clazz = (VClass) classIt.next();
- respo += "";
+ respo.append("");
}
}
}
@@ -122,7 +119,7 @@ public class GetObjectClasses extends BaseEditController {
*
* }
*/
- respo += "";
+ respo.append("");
out.println(respo);
out.flush();
out.close();
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/startup/StartupManager.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/startup/StartupManager.java
index 0d5307d31..494bc49dc 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/startup/StartupManager.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/startup/StartupManager.java
@@ -156,16 +156,12 @@ public class StartupManager implements ServletContextListener {
ss.fatal(this, "Instance of '" + className
+ "' is not a ServletContextListener", e);
return null;
- } catch (Exception e) {
- ss.fatal(this, "Failed to instantiate listener: '" + className
- + "'", e);
- return null;
- } catch (ExceptionInInitializerError e) {
+ } catch (Exception | ExceptionInInitializerError e) {
ss.fatal(this, "Failed to instantiate listener: '" + className
+ "'", e);
return null;
}
- }
+ }
/**
* Call contextInitialized() on the listener.
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/ConfiguredReasonerListener.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/ConfiguredReasonerListener.java
index d9d88651b..3dde721f9 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/ConfiguredReasonerListener.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/ConfiguredReasonerListener.java
@@ -221,8 +221,7 @@ public class ConfiguredReasonerListener implements ModelChangedListener {
if (thereAreNoDrivingPatterns() || statementMatchesDrivingPattern(stmt)) {
addIt(stmt);
- return;
- }
+ }
}
public void tryRemove(Statement stmt) {
@@ -259,8 +258,7 @@ public class ConfiguredReasonerListener implements ModelChangedListener {
if (thereAreNoDrivingPatterns() || statementMatchesDrivingPattern(stmt)) {
removeIt(stmt);
- return;
- }
+ }
}
private boolean isDataProperty(Statement stmt) {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/impl/jfact/JFactTBoxReasoner.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/impl/jfact/JFactTBoxReasoner.java
index 85035ac36..c53e81ad7 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/impl/jfact/JFactTBoxReasoner.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/tboxreasoner/impl/jfact/JFactTBoxReasoner.java
@@ -29,7 +29,6 @@ import org.apache.jena.ontology.Restriction;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.rdf.model.ModelFactory;
import org.apache.jena.rdf.model.RDFNode;
-import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.ResourceFactory;
import org.apache.jena.rdf.model.Statement;
import org.apache.jena.rdf.model.StmtIterator;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Csv2Rdf.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Csv2Rdf.java
index 04d75bed6..159d78bbc 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Csv2Rdf.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Csv2Rdf.java
@@ -5,15 +5,11 @@ package edu.cornell.mannlib.vitro.webapp.utils;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
-import java.util.List;
import java.util.Random;
-import javax.servlet.http.HttpServletRequest;
-
import org.apache.commons.csv.CSVFormat;
import org.apache.commons.csv.CSVParser;
import org.apache.commons.csv.CSVRecord;
-import org.apache.jena.datatypes.xsd.XSDDatatype;
import org.apache.jena.ontology.DatatypeProperty;
import org.apache.jena.ontology.Individual;
import org.apache.jena.ontology.OntClass;
@@ -24,7 +20,6 @@ import org.apache.jena.rdf.model.ModelFactory;
import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.ResourceFactory;
-import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
import edu.cornell.mannlib.vitro.webapp.dao.WebappDaoFactory;
public class Csv2Rdf {
@@ -132,7 +127,7 @@ public class Csv2Rdf {
String uri = null;
int attempts = 0;
if(namespace!=null && !namespace.isEmpty()){
- while( uriIsGood == false && attempts < 30 ){
+ while(!uriIsGood && attempts < 30 ){
uri = namespace+individualNameBase+random.nextInt( Math.min(Integer.MAX_VALUE,(int)Math.pow(2,attempts + 13)) );
String errMsg = wadf.checkURI(uri);
Resource res = ResourceFactory.createResource(uri);
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/FrontEndEditingUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/FrontEndEditingUtils.java
index 5c3314431..4d79f7775 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/FrontEndEditingUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/FrontEndEditingUtils.java
@@ -2,7 +2,6 @@
package edu.cornell.mannlib.vitro.webapp.utils;
-import java.util.Arrays;
import java.util.List;
import javax.servlet.http.HttpServletRequest;
@@ -10,17 +9,8 @@ import javax.servlet.http.HttpServletRequest;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.jena.rdf.model.Literal;
-import org.apache.jena.rdf.model.Model;
-import org.apache.jena.rdf.model.RDFNode;
-import org.apache.jena.rdf.model.Statement;
-import org.apache.jena.rdf.model.StmtIterator;
-import org.apache.jena.vocabulary.XSD;
-
import edu.cornell.mannlib.vitro.webapp.beans.Individual;
import edu.cornell.mannlib.vitro.webapp.beans.ObjectPropertyStatement;
-import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
-import edu.cornell.mannlib.vitro.webapp.dao.jena.ObjectPropertyDaoJena;
public class FrontEndEditingUtils {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/JsonToFmModel.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/JsonToFmModel.java
index caccca279..d2449a3ca 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/JsonToFmModel.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/JsonToFmModel.java
@@ -126,7 +126,7 @@ public final class JsonToFmModel
@SuppressWarnings("unchecked")
private static StringBuffer toStringBuffer(Map unsortedMap, int indent)
{
- StringBuffer tabs = new StringBuffer();
+ StringBuilder tabs = new StringBuilder();
for (int i = 0; i < indent; i++)
{
tabs.append("\t");
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Stemmer.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Stemmer.java
index 131a74f26..315feefd4 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Stemmer.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/Stemmer.java
@@ -70,7 +70,7 @@ public class Stemmer
public void add(char ch)
{ if (i == b.length)
{ char[] new_b = new char[i+INC];
- for (int c = 0; c < i; c++) new_b[c] = b[c];
+ System.arraycopy(b, 0, new_b, 0, i);
b = new_b;
}
b[i++] = ch;
@@ -85,7 +85,7 @@ public class Stemmer
public void add(char[] w, int wLen)
{ if (i+wLen >= b.length)
{ char[] new_b = new char[i+wLen+INC];
- for (int c = 0; c < i; c++) new_b[c] = b[c];
+ System.arraycopy(b, 0, new_b, 0, i);
b = new_b;
}
for (int c = 0; c < wLen; c++) b[i++] = w[c];
@@ -115,7 +115,7 @@ public class Stemmer
private final boolean cons(int i)
{ switch (b[i])
{ case 'a': case 'e': case 'i': case 'o': case 'u': return false;
- case 'y': return (i==0) ? true : !cons(i-1);
+ case 'y': return (i == 0) || !cons(i - 1);
default: return true;
}
}
@@ -367,7 +367,7 @@ public class Stemmer
public static String StemString( String inputStr, int maxLength )
{
- String outputStr="";
+ StringBuilder outputStr= new StringBuilder();
int previousCh=0;
char[] w = new char[maxLength];
@@ -395,19 +395,19 @@ public class Stemmer
{
String u;
u = s.toString();
- outputStr += u;
+ outputStr.append(u);
if ( ch == '-' ) { // replace - with space
- outputStr += " ";
+ outputStr.append(" ");
} else if ( ch == '.' ) {
if ( Character.isDigit( (char) previousCh )) {
- outputStr += ".";
+ outputStr.append(".");
} else {
- outputStr += " ";
+ outputStr.append(" ");
//previousCh = 32; // set to whitespace; extra spaces should be filtered out on next pass
}
} else {
Character Ch = new Character((char) ch);
- outputStr += Ch.toString();
+ outputStr.append(Ch.toString());
}
stemmerInputBufferIndex=0; // to avoid repeats after )
}
@@ -421,7 +421,7 @@ public class Stemmer
if ( !Character.isWhitespace((char) previousCh ) ) {
if ( previousCh != '.' ) {
Character Ch = new Character((char) ch);
- outputStr += Ch.toString();
+ outputStr.append(Ch.toString());
}
}
} else if ( ch == '(' ) { // open paren; copy all characters until close paren
@@ -448,21 +448,21 @@ public class Stemmer
stemmerInputBufferIndex=0;
} else if ( ch == ')' ) { // when is last character of input string
Character Ch = new Character((char) ch);
- outputStr += Ch.toString();
+ outputStr.append(Ch.toString());
log.trace( Ch.toString() );
log.trace("found close paren at position: " + inputArrayIndex + " of input term " + inputStr );
} else if ( ch == '-' ) { // replace - with space
- outputStr += " ";
+ outputStr.append(" ");
} else if ( ch == '.' ) {
if ( Character.isDigit( (char) previousCh )) {
- outputStr += ".";
+ outputStr.append(".");
} else {
- outputStr += " ";
+ outputStr.append(" ");
//previousCh = 32; // set to whitespace; extra spaces should be filtered out on next pass
}
} else {
Character Ch = new Character((char) ch);
- outputStr += Ch.toString();
+ outputStr.append(Ch.toString());
}
previousCh = ch;
if (ch < 0) break;
@@ -476,10 +476,10 @@ public class Stemmer
String u;
u = s.toString();
- outputStr += u;
+ outputStr.append(u);
}
- return outputStr == null ? ( outputStr.equals("") ? null : outputStr.trim() ) : outputStr.trim();
+ return outputStr == null || outputStr.length() == 0? null : outputStr.toString().trim();
}
/*
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/DataGetterUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/DataGetterUtils.java
index b290d3122..85d1ca55c 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/DataGetterUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/DataGetterUtils.java
@@ -35,12 +35,10 @@ import org.apache.jena.vocabulary.OWL;
import edu.cornell.mannlib.vitro.webapp.beans.VClass;
import edu.cornell.mannlib.vitro.webapp.beans.VClassGroup;
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
-import edu.cornell.mannlib.vitro.webapp.controller.freemarker.IndividualListController;
import edu.cornell.mannlib.vitro.webapp.dao.DisplayVocabulary;
import edu.cornell.mannlib.vitro.webapp.dao.VClassGroupsForRequest;
import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary;
import edu.cornell.mannlib.vitro.webapp.dao.jena.VClassGroupCache;
-import edu.cornell.mannlib.vitro.webapp.utils.searchengine.SearchQueryUtils;
public class DataGetterUtils {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/FixedHTMLDataGetter.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/FixedHTMLDataGetter.java
index c5b119508..6723beb19 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/FixedHTMLDataGetter.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/dataGetter/FixedHTMLDataGetter.java
@@ -1,11 +1,7 @@
/* $This file is distributed under the terms of the license in LICENSE$ */
package edu.cornell.mannlib.vitro.webapp.utils.dataGetter;
-import java.util.ArrayList;
-import java.util.Collections;
import java.util.HashMap;
-import java.util.Iterator;
-import java.util.List;
import java.util.Map;
import javax.servlet.ServletContext;
@@ -22,8 +18,6 @@ import org.apache.jena.query.QuerySolutionMap;
import org.apache.jena.query.ResultSet;
import org.apache.jena.rdf.model.Literal;
import org.apache.jena.rdf.model.Model;
-import org.apache.jena.rdf.model.RDFNode;
-import org.apache.jena.rdf.model.Resource;
import org.apache.jena.rdf.model.ResourceFactory;
import org.apache.jena.shared.Lock;
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/ExtendedLinkedDataUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/ExtendedLinkedDataUtils.java
index 7f717724b..b22b00ed1 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/ExtendedLinkedDataUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/ExtendedLinkedDataUtils.java
@@ -68,7 +68,7 @@ public class ExtendedLinkedDataUtils {
try {
try {
reader = new BufferedReader(new FileReader(sparqlFile));
- StringBuffer fileContents = new StringBuffer();
+ StringBuilder fileContents = new StringBuilder();
String ln;
while ( (ln = reader.readLine()) != null) {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaIngestUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaIngestUtils.java
index 361c012a3..39184b998 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaIngestUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaIngestUtils.java
@@ -18,7 +18,6 @@ import java.util.regex.Pattern;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.jena.ontology.FunctionalProperty;
import org.apache.jena.ontology.OntModel;
import org.apache.jena.ontology.OntModelSpec;
import org.apache.jena.rdf.model.Literal;
@@ -40,7 +39,6 @@ import org.apache.jena.vocabulary.RDF;
import org.apache.jena.vocabulary.RDFS;
import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest;
-import edu.cornell.mannlib.vitro.webapp.dao.InsertException;
import edu.cornell.mannlib.vitro.webapp.dao.WebappDaoFactory;
public class JenaIngestUtils {
@@ -262,7 +260,7 @@ public class JenaIngestUtils {
} finally {
closeIt.close();
}
- if (duplicate == false) {
+ if (!duplicate) {
closeIt = model.listStatements((Resource)null, (Property)null, res);
try {
if (closeIt.hasNext()) {
@@ -808,7 +806,7 @@ public class JenaIngestUtils {
boolean uriIsGood = false;
int attempts = 0;
- while( uriIsGood == false && attempts < 30 ){
+ while(!uriIsGood && attempts < 30 ){
uri = newNamespace + "n" + random.nextInt( Math.min(Integer.MAX_VALUE,(int)Math.pow(2,attempts + 13)) );
errMsg = wdf.checkURI(uri);
if( errMsg != null)
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaOutputUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaOutputUtils.java
index 8f00a29a7..ba682a604 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaOutputUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/JenaOutputUtils.java
@@ -56,6 +56,5 @@ public class JenaOutputUtils {
}
model.setNsPrefixes(prefixes);
- return;
- }
+ }
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/criticalsection/LockedModel.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/criticalsection/LockedModel.java
index a6fce02e4..896b85494 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/criticalsection/LockedModel.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/jena/criticalsection/LockedModel.java
@@ -5,9 +5,6 @@ package edu.cornell.mannlib.vitro.webapp.utils.jena.criticalsection;
import org.apache.jena.rdf.model.Model;
import edu.cornell.mannlib.vitro.webapp.rdfservice.adapters.AbstractModelDecorator;
-import org.apache.jena.rdf.model.Property;
-import org.apache.jena.rdf.model.Resource;
-import org.apache.jena.rdf.model.StmtIterator;
/**
* A model that is easy to use in a try-with-resources code block. It can only
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/log/LogUtils.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/log/LogUtils.java
index 67e6b33f9..37703ac75 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/log/LogUtils.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/log/LogUtils.java
@@ -45,11 +45,11 @@ public class LogUtils {
@SuppressWarnings("unchecked")
Map map = req.getParameterMap();
- String s = req.getRequestURL().append('\n').toString();
+ StringBuilder s = new StringBuilder(req.getRequestURL().append('\n').toString());
for (String name : new TreeSet(map.keySet())) {
- s += " " + name + " = " + Arrays.toString(map.get(name)) + '\n';
+ s.append(" ").append(name).append(" = ").append(Arrays.toString(map.get(name))).append('\n');
}
- return s.trim();
+ return s.toString().trim();
}
private static boolean isLevelEnabled(Log log, String level) {
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/logging/ToString.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/logging/ToString.java
index 17b5356fc..d34be92b5 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/logging/ToString.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/logging/ToString.java
@@ -127,7 +127,7 @@ public class ToString {
}
public static boolean isVitroClass(Object o) {
- return (o == null) ? false : o.getClass().getName()
+ return (o != null) && o.getClass().getName()
.startsWith("edu.cornell");
}
diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/searchengine/Formatter.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/searchengine/Formatter.java
index 05f90c20f..34b633580 100644
--- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/searchengine/Formatter.java
+++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/utils/searchengine/Formatter.java
@@ -21,11 +21,7 @@ import edu.cornell.mannlib.vitro.webapp.modules.searchEngine.SearchResultDocumen
public class Formatter {
public static String format(SearchInputDocument doc) {
StringBuilder sb = new StringBuilder();
- sb.append("SearchInputDocument: Name='"
- + getValueFromField(doc, "nameRaw") + "', URI='"
- + getValueFromField(doc, "URI") + "', boost='"
- + doc.getDocumentBoost() + "', " + doc.getFieldMap().size()
- + " fields \n");
+ sb.append("SearchInputDocument: Name='").append(getValueFromField(doc, "nameRaw")).append("', URI='").append(getValueFromField(doc, "URI")).append("', boost='").append(doc.getDocumentBoost()).append("', ").append(doc.getFieldMap().size()).append(" fields \n");
for (SearchInputField field : new TreeMap<>(doc.getFieldMap()).values()) {
sb.append(format(field, " ").append('\n'));
@@ -51,10 +47,7 @@ public class Formatter {
private static StringBuilder format(SearchInputField field, String padding) {
StringBuilder sb = new StringBuilder();
- sb.append(padding).append(
- "SearchInputField: Name='" + field.getName() + "', boost='"
- + field.getBoost() + "', " + field.getValues().size()
- + " values \n");
+ sb.append(padding).append("SearchInputField: Name='").append(field.getName()).append("', boost='").append(field.getBoost()).append("', ").append(field.getValues().size()).append(" values \n");
for (Object value : field.getValues()) {
sb.append(padding).append(" '").append(String.valueOf(value))
@@ -88,10 +81,7 @@ public class Formatter {
public static String format(SearchResponse response) {
StringBuilder sb = new StringBuilder();
- sb.append("SearchResponse: " + response.getResults().size()
- + " results, " + response.getFacetFields().size()
- + " facet fields, " + response.getHighlighting().size()
- + " highlights\n");
+ sb.append("SearchResponse: ").append(response.getResults().size()).append(" results, ").append(response.getFacetFields().size()).append(" facet fields, ").append(response.getHighlighting().size()).append(" highlights\n");
for (SearchFacetField facet : response.getFacetFields()) {
sb.append(format(facet, " "));
}
@@ -115,17 +105,10 @@ public class Formatter {
for (Collection