diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java
index d1b61c9b7..6bb6abbbd 100644
--- a/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java
+++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java
@@ -354,14 +354,24 @@ public class VisualizationCodeGenerator {
int totalUniqueCoAuthors, int renderedFullSparks,
String sparklineDisplayOptions) {
- String csvDownloadURL = "";
+ String csvDownloadURLHref = "";
try {
- csvDownloadURL = getCSVDownloadURL();
+ if (getCSVDownloadURL() != null) {
+
+ csvDownloadURLHref = "(.CSV File)";
+
+ } else {
+
+ csvDownloadURLHref = "";
+
+ }
+
} catch (UnsupportedEncodingException e) {
- csvDownloadURL = "#";
+ csvDownloadURLHref = "";
}
+
visualizationCode.append("var fullSparklineView = new google.visualization.DataView(data);\n" +
"fullSparklineView.setColumns([1]);\n");
@@ -378,7 +388,7 @@ public class VisualizationCodeGenerator {
"+ ' " +
"(" + minPubYearConsidered + " - " + currentYear + ")" +
" '" +
- "+ ' (.CSV File)';" +
+ "+ ' " + csvDownloadURLHref + " ';" +
"$('#" + visDivNames.get("FULL_SPARK") + " td.sparkline_text').html(allSparksText);");
visualizationCode.append("}\n ");
@@ -467,32 +477,38 @@ public class VisualizationCodeGenerator {
StringBuilder divContextCode = new StringBuilder();
- try {
+ String csvDownloadURLHref = "";
+
+ if (yearToUniqueCoauthorsCount.size() > 0) {
- String downloadFileCode;
- if (yearToUniqueCoauthorsCount.size() > 0) {
-
-
- String downloadURL = getCSVDownloadURL();
-
- downloadFileCode = "Download data as .csv file.
";
-
- valueObjectContainer.setDownloadDataLink(downloadURL);
- } else {
- downloadFileCode = "No data available to export.
";
+ try {
+ if (getCSVDownloadURL() != null) {
+
+ csvDownloadURLHref = "Download data as .csv file.
";
+ valueObjectContainer.setDownloadDataLink(getCSVDownloadURL());
+
+ } else {
+
+ csvDownloadURLHref = "";
+
+ }
+
+ } catch (UnsupportedEncodingException e) {
+ csvDownloadURLHref = "";
}
- String tableCode = generateDataTable();
- divContextCode.append("
" + tableCode + - downloadFileCode + "
"); - - valueObjectContainer.setTable(tableCode); - - } catch (UnsupportedEncodingException e) { - e.printStackTrace(); + } else { + csvDownloadURLHref = "No data available to export." + tableCode + + csvDownloadURLHref + "
"); + + valueObjectContainer.setTable(tableCode); + return divContextCode.toString(); } @@ -523,7 +539,7 @@ public class VisualizationCodeGenerator { return downloadURL; } else { - return "#"; + return null; } } @@ -537,20 +553,6 @@ public class VisualizationCodeGenerator { String fullTimelineLink; if (yearToUniqueCoauthorsCount.size() > 0) { -// String fullTimelineNetworkURL = uri.toString() + "?" + -// VisualizationFrameworkConstants.INDIVIDUAL_URI_URL_HANDLE + -// "=" + URLEncoder.encode(individualURI, -// VisualizationController.URL_ENCODING_SCHEME).toString() + -// "&" + -// "vis" + -// "=" + URLEncoder.encode(VisualizationController -// .PERSON_PUBLICATION_COUNT_VIS_URL_VALUE, -// VisualizationController.URL_ENCODING_SCHEME).toString() + -// "&" + -// VisualizationFrameworkConstants.RENDER_MODE_URL_HANDLE + -// "=" + URLEncoder.encode(VisualizationFrameworkConstants.STANDALONE_RENDER_MODE_URL_VALUE, -// VisualizationController.URL_ENCODING_SCHEME).toString(); - String fullTimelineNetworkURL = contextPath + "/admin/visQuery" diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/personpubcount/VisualizationCodeGenerator.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/personpubcount/VisualizationCodeGenerator.java index 9d4d8666b..51f0e1464 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/personpubcount/VisualizationCodeGenerator.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/personpubcount/VisualizationCodeGenerator.java @@ -361,14 +361,24 @@ public class VisualizationCodeGenerator { int totalPublications, int renderedFullSparks, String sparklineDisplayOptions) { - String csvDownloadURL = ""; + String csvDownloadURLHref = ""; try { - csvDownloadURL = getCSVDownloadURL(); + if (getCSVDownloadURL() != null) { + + csvDownloadURLHref = "(.CSV File)"; + + } else { + + csvDownloadURLHref = ""; + + } + } catch (UnsupportedEncodingException e) { - csvDownloadURL = "#"; + csvDownloadURLHref = ""; } + visualizationCode.append("var fullSparklineView = new google.visualization.DataView(data);\n" + "fullSparklineView.setColumns([1]);\n"); @@ -387,7 +397,7 @@ public class VisualizationCodeGenerator { "" + "(" + minPubYearConsidered + " - " + currentYear + ")" + " '" + - "+ ' (.CSV File)';" + + "+ ' " + csvDownloadURLHref + " ';" + "$('#" + visDivNames.get("FULL_SPARK") + " td.sparkline_text').html(allSparksText);"); visualizationCode.append("}\n "); @@ -476,32 +486,38 @@ public class VisualizationCodeGenerator { StringBuilder divContextCode = new StringBuilder(); - try { + String csvDownloadURLHref = ""; + + if (yearToPublicationCount.size() > 0) { - String downloadFileCode; - if (yearToPublicationCount.size() > 0) { - - - String downloadURL = getCSVDownloadURL(); - - downloadFileCode = "Download data as .csv file." + tableCode + - downloadFileCode + "
"); - - valueObjectContainer.setTable(tableCode); - - } catch (UnsupportedEncodingException e) { - e.printStackTrace(); + } else { + csvDownloadURLHref = "No data available to export." + tableCode + + csvDownloadURLHref + "
"); + + valueObjectContainer.setTable(tableCode); + return divContextCode.toString(); } @@ -527,7 +543,7 @@ public class VisualizationCodeGenerator { System.out.println(" ----- >>>> " + contextPath + " XX " + individualURIParam + " XX " + downloadURL); return downloadURL; } else { - return "#"; + return null; } } @@ -566,10 +582,6 @@ public class VisualizationCodeGenerator { + VisualizationFrameworkConstants.VIS_TYPE_URL_HANDLE + "=" + URLEncoder.encode("person_level", VisualizationController.URL_ENCODING_SCHEME).toString() - + "&" - + VisualizationFrameworkConstants.VIS_CONTAINER_URL_HANDLE - + "=" + URLEncoder.encode("ego_sparkline", - VisualizationController.URL_ENCODING_SCHEME).toString() + "&" + VisualizationFrameworkConstants.RENDER_MODE_URL_HANDLE + "=" + URLEncoder.encode(VisualizationFrameworkConstants.STANDALONE_RENDER_MODE_URL_VALUE, @@ -600,18 +612,27 @@ public class VisualizationCodeGenerator { private String generateDataTable() { - String csvDownloadURL = ""; + String csvDownloadURLHref = ""; try { - csvDownloadURL = getCSVDownloadURL(); + if (getCSVDownloadURL() != null) { + + csvDownloadURLHref = "(.CSV File)"; + + } else { + + csvDownloadURLHref = ""; + + } + } catch (UnsupportedEncodingException e) { - csvDownloadURL = "#"; + csvDownloadURLHref = ""; } StringBuilder dataTable = new StringBuilder(); dataTable.append("Year | " + diff --git a/webapp/web/templates/visualization/person_level.jsp b/webapp/web/templates/visualization/person_level.jsp index ede5e0ae4..13ff543ec 100644 --- a/webapp/web/templates/visualization/person_level.jsp +++ b/webapp/web/templates/visualization/person_level.jsp @@ -167,7 +167,7 @@
---|