From d3f6af6981320850b91f77871df11b94b07b4bf7 Mon Sep 17 00:00:00 2001 From: j2blake Date: Thu, 14 Nov 2013 17:05:04 -0500 Subject: [PATCH 1/9] VIVO-523 Change the way the example language files are presented. --- .../i18n/all_es.properties => es_GO/i18n/all_es_GO.properties} | 0 .../templates/freemarker/search-help_es_GO.ftl} | 0 .../templates/freemarker/termsOfUse_es_GO.ftl} | 0 .../freemarker/userAccounts-acctCreatedEmail_es_GO.ftl} | 0 .../userAccounts-acctCreatedExternalOnlyEmail_es_GO.ftl} | 0 .../userAccounts-confirmEmailChangedEmail_es_GO.ftl} | 0 .../freemarker/userAccounts-firstTimeExternalEmail_es_GO.ftl} | 0 .../freemarker/userAccounts-passwordCreatedEmail_es_GO.ftl} | 0 .../userAccounts-passwordResetCompleteEmail_es_GO.ftl} | 0 .../userAccounts-passwordResetPendingEmail_es_GO.ftl} | 0 .../vitro/webapp/i18n/selection/LocaleSelectionSetup.java | 3 ++- 11 files changed, 2 insertions(+), 1 deletion(-) rename webapp/languages/{example/i18n/all_es.properties => es_GO/i18n/all_es_GO.properties} (100%) rename webapp/languages/{example/templates/freemarker/search-help_es.ftl => es_GO/templates/freemarker/search-help_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/termsOfUse_es.ftl => es_GO/templates/freemarker/termsOfUse_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/userAccounts-acctCreatedEmail.ftl => es_GO/templates/freemarker/userAccounts-acctCreatedEmail_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/userAccounts-acctCreatedExternalOnlyEmail.ftl => es_GO/templates/freemarker/userAccounts-acctCreatedExternalOnlyEmail_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/userAccounts-confirmEmailChangedEmail.ftl => es_GO/templates/freemarker/userAccounts-confirmEmailChangedEmail_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/userAccounts-firstTimeExternalEmail.ftl => es_GO/templates/freemarker/userAccounts-firstTimeExternalEmail_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/userAccounts-passwordCreatedEmail.ftl => es_GO/templates/freemarker/userAccounts-passwordCreatedEmail_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/userAccounts-passwordResetCompleteEmail.ftl => es_GO/templates/freemarker/userAccounts-passwordResetCompleteEmail_es_GO.ftl} (100%) rename webapp/languages/{example/templates/freemarker/userAccounts-passwordResetPendingEmail.ftl => es_GO/templates/freemarker/userAccounts-passwordResetPendingEmail_es_GO.ftl} (100%) diff --git a/webapp/languages/example/i18n/all_es.properties b/webapp/languages/es_GO/i18n/all_es_GO.properties similarity index 100% rename from webapp/languages/example/i18n/all_es.properties rename to webapp/languages/es_GO/i18n/all_es_GO.properties diff --git a/webapp/languages/example/templates/freemarker/search-help_es.ftl b/webapp/languages/es_GO/templates/freemarker/search-help_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/search-help_es.ftl rename to webapp/languages/es_GO/templates/freemarker/search-help_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/termsOfUse_es.ftl b/webapp/languages/es_GO/templates/freemarker/termsOfUse_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/termsOfUse_es.ftl rename to webapp/languages/es_GO/templates/freemarker/termsOfUse_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/userAccounts-acctCreatedEmail.ftl b/webapp/languages/es_GO/templates/freemarker/userAccounts-acctCreatedEmail_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/userAccounts-acctCreatedEmail.ftl rename to webapp/languages/es_GO/templates/freemarker/userAccounts-acctCreatedEmail_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/userAccounts-acctCreatedExternalOnlyEmail.ftl b/webapp/languages/es_GO/templates/freemarker/userAccounts-acctCreatedExternalOnlyEmail_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/userAccounts-acctCreatedExternalOnlyEmail.ftl rename to webapp/languages/es_GO/templates/freemarker/userAccounts-acctCreatedExternalOnlyEmail_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/userAccounts-confirmEmailChangedEmail.ftl b/webapp/languages/es_GO/templates/freemarker/userAccounts-confirmEmailChangedEmail_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/userAccounts-confirmEmailChangedEmail.ftl rename to webapp/languages/es_GO/templates/freemarker/userAccounts-confirmEmailChangedEmail_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/userAccounts-firstTimeExternalEmail.ftl b/webapp/languages/es_GO/templates/freemarker/userAccounts-firstTimeExternalEmail_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/userAccounts-firstTimeExternalEmail.ftl rename to webapp/languages/es_GO/templates/freemarker/userAccounts-firstTimeExternalEmail_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/userAccounts-passwordCreatedEmail.ftl b/webapp/languages/es_GO/templates/freemarker/userAccounts-passwordCreatedEmail_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/userAccounts-passwordCreatedEmail.ftl rename to webapp/languages/es_GO/templates/freemarker/userAccounts-passwordCreatedEmail_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/userAccounts-passwordResetCompleteEmail.ftl b/webapp/languages/es_GO/templates/freemarker/userAccounts-passwordResetCompleteEmail_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/userAccounts-passwordResetCompleteEmail.ftl rename to webapp/languages/es_GO/templates/freemarker/userAccounts-passwordResetCompleteEmail_es_GO.ftl diff --git a/webapp/languages/example/templates/freemarker/userAccounts-passwordResetPendingEmail.ftl b/webapp/languages/es_GO/templates/freemarker/userAccounts-passwordResetPendingEmail_es_GO.ftl similarity index 100% rename from webapp/languages/example/templates/freemarker/userAccounts-passwordResetPendingEmail.ftl rename to webapp/languages/es_GO/templates/freemarker/userAccounts-passwordResetPendingEmail_es_GO.ftl diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/i18n/selection/LocaleSelectionSetup.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/i18n/selection/LocaleSelectionSetup.java index c89819421..081019a04 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/i18n/selection/LocaleSelectionSetup.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/i18n/selection/LocaleSelectionSetup.java @@ -134,7 +134,8 @@ public class LocaleSelectionSetup implements ServletContextListener { throws IllegalArgumentException { Locale locale = LocaleUtils.toLocale(localeString); - if (!LocaleUtils.isAvailableLocale(locale)) { + if (!"es_GO".equals(localeString) && // No complaint about bogus locale + !LocaleUtils.isAvailableLocale(locale)) { ssWarning("'" + locale + "' is not a recognized locale."); } return locale; From 35251e89f43a6992fd1ec3f5af6528f3ea56f8ba Mon Sep 17 00:00:00 2001 From: hudajkhan Date: Fri, 15 Nov 2013 12:33:47 -0500 Subject: [PATCH 2/9] enable check for creating new individual to get faux property information correctly --- .../generators/DefaultAddMissingIndividualFormGenerator.java | 5 ++++- .../edit/forms/defaultOfferCreateNewOptionForm.ftl | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java index 2f53d3619..0a8a866a3 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/DefaultAddMissingIndividualFormGenerator.java @@ -56,7 +56,10 @@ public class DefaultAddMissingIndividualFormGenerator implements EditConfigurati public static boolean isCreateNewIndividual(VitroRequest vreq, HttpSession session) { String command = vreq.getParameter("cmd"); String predicateUri = EditConfigurationUtils.getPredicateUri(vreq); - ObjectProperty objProp = vreq.getWebappDaoFactory().getObjectPropertyDao().getObjectPropertyByURI(predicateUri); + //This method also looks at domain and range uris and so is different than just getting the + //object property based on predicate uri alone + ObjectProperty objProp = EditConfigurationUtils.getObjectPropertyForPredicate(vreq, + predicateUri); if(objProp != null) { return(objProp.getOfferCreateNewOption() && ( diff --git a/webapp/web/templates/freemarker/edit/forms/defaultOfferCreateNewOptionForm.ftl b/webapp/web/templates/freemarker/edit/forms/defaultOfferCreateNewOptionForm.ftl index 578f017c6..1f6279ba5 100644 --- a/webapp/web/templates/freemarker/edit/forms/defaultOfferCreateNewOptionForm.ftl +++ b/webapp/web/templates/freemarker/edit/forms/defaultOfferCreateNewOptionForm.ftl @@ -17,6 +17,8 @@ + + checked> + + +<#macro showTextbox key> + + + + + + +<#if !settings["developer.enabled"]> +<#elseif !settings["mayControl"]> +
+

${siteName} is running in developer mode.

+
+<#else> +
+

${siteName} is running in developer mode. + (click for Options) +

+
+
+ + +
+ Freemarker templates + + +
+ +
+ SPARQL Queries + + + +
+ +
+ Language support + + +
+ + +
+
+
+ \ No newline at end of file diff --git a/webapp/web/templates/freemarker/page/partials/menu.ftl b/webapp/web/templates/freemarker/page/partials/menu.ftl index e0543117e..e193960fd 100644 --- a/webapp/web/templates/freemarker/page/partials/menu.ftl +++ b/webapp/web/templates/freemarker/page/partials/menu.ftl @@ -1,5 +1,7 @@ <#-- $This file is distributed under the terms of the license in /doc/license.txt$ --> +<#include "developer.ftl"> +