litvinovg/vitro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NIHVIVO-1207 If deploy.properties does not contain a value for externalAuth.serverUrl, default to /loginExternalAuthReturn -- that way the users need only configure that as a protected page.

Browse source
This commit is contained in:
jeb228 2010-11-23 21:05:52 +00:00
parent 0418489ec1
commit 6fe5ac59a9
2 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ExternalAuthHelper.java
View file

@ -13,7 +13,6 @@ import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import edu.cornell.mannlib.vitro.webapp.ConfigurationProperties; import edu.cornell.mannlib.vitro.webapp.ConfigurationProperties;
import edu.cornell.mannlib.vitro.webapp.dao.IndividualDao;
/** /**
* Capture the properties used by the External Authorization system, and use * Capture the properties used by the External Authorization system, and use
@ -109,10 +108,10 @@ public class ExternalAuthHelper {
} }
if (externalAuthServerUrl == null) { if (externalAuthServerUrl == null) {
log.error("User asked for external authentication, " log.debug("deploy.properties doesn't contain a value for '"
+ "but deploy.properties doesn't contain a value for '" + PROPERTY_EXTERNAL_AUTH_SERVER_URL
+ PROPERTY_EXTERNAL_AUTH_SERVER_URL + "'"); + "' -- sending directly to '" + returnUrl + "'");
return null; return returnUrl;
} }
try { try {

6
webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/LoginExternalAuthSetup.java
View file

@ -48,14 +48,14 @@ public class LoginExternalAuthSetup extends BaseLoginServlet {
LoginProcessBean.State.LOGGING_IN); LoginProcessBean.State.LOGGING_IN);
String returnUrl = buildReturnUrl(req); String returnUrl = buildReturnUrl(req);
ExternalAuthHelper helper = ExternalAuthHelper.getHelper(req); String redirectUrl = ExternalAuthHelper.getHelper(req)
String redirectUrl = helper.buildExternalAuthRedirectUrl(returnUrl); .buildExternalAuthRedirectUrl(returnUrl);
if (redirectUrl == null) { if (redirectUrl == null) {
complainAndReturnToReferrer(req, resp, ATTRIBUTE_REFERRER, complainAndReturnToReferrer(req, resp, ATTRIBUTE_REFERRER,
MESSAGE_LOGIN_FAILED); MESSAGE_LOGIN_FAILED);
} }
resp.sendRedirect(redirectUrl); resp.sendRedirect(redirectUrl);
} }