NIHVIVO-2694 Make sure that the BasicAuthenticator and the AuthenticatorStub comply to the contract on throwing LoginNotPermitted exceptions.

webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/Authenticator.java

@@ -92,6 +92,9 @@ public abstract class Authenticator {
 	 * Behavior when userAccount is null depends on the particular
 	 * Authenticator. An answer of "true" presumably means that the user will be
 	 * permitted to login and create an account on the fly.
+	 * 
+	 * Note that this method may rely on the HttpServletRequest object that was
+	 * provided to the factory when this instance was created.
 	 */
 	public abstract boolean isUserPermittedToLogin(UserAccount userAccount);
 

webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/BasicAuthenticator.java

@@ -142,7 +142,10 @@ public class BasicAuthenticator extends Authenticator {
 
 	@Override
 	public void recordLoginAgainstUserAccount(UserAccount userAccount,
-			AuthenticationSource authSource) {
+			AuthenticationSource authSource) throws LoginNotPermitted {
+		if (!isUserPermittedToLogin(userAccount)) {
+			throw new LoginNotPermitted();
+		}
 		if (userAccount == null) {
 			log.error("Trying to record the login of a null user. ");
 			return;

webapp/test/edu/cornell/mannlib/vitro/webapp/controller/authenticate/AuthenticatorStub.java

@@ -137,7 +137,11 @@ public class AuthenticatorStub extends Authenticator {
 
 	@Override
 	public void recordLoginAgainstUserAccount(UserAccount userAccount,
-			AuthenticationSource authSource) {
+			AuthenticationSource authSource) throws LoginNotPermitted {
+		if (!isUserPermittedToLogin(userAccount)) {
+			throw new LoginNotPermitted();
+		}
+
 		recordedLogins.add(userAccount.getEmailAddress());
 
 		LoginStatusBean lsb = new LoginStatusBean(userAccount.getUri(),