diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java b/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java index cdcf65cdb..53ef1ba96 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java @@ -136,10 +136,8 @@ public class BaseEditController extends VitroHttpServlet { String value = ""; if (key.equals(MULTIPLEXED_PARAMETER_NAME)) { String multiplexedStr = request.getParameterValues(key)[0]; - Map paramMap = FormUtils.beanParamMapFromString(multiplexedStr); - Iterator paramIt = paramMap.keySet().iterator(); - while (paramIt.hasNext()) { - String param = (String) paramIt.next(); + Map paramMap = FormUtils.beanParamMapFromString(multiplexedStr); + for (String param : paramMap.keySet()) { String demultiplexedValue = (String) paramMap.get(param); FormUtils.beanSet(bean, param, demultiplexedValue); } diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java b/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java index 1d5b282f0..b9b78b384 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java @@ -205,12 +205,8 @@ public class OperationController extends BaseEditController { private void runPreprocessors(EditProcessObject epo, Object newObj) { if (epo.getPreProcessorList() != null && epo.getPreProcessorList().size()>0) { - Iterator preIt = epo.getPreProcessorList().iterator(); - while (preIt.hasNext()) { - try { - EditPreProcessor epp = (EditPreProcessor) preIt.next(); - epp.process(newObj, epo); - } catch (ClassCastException e) {} + for (EditPreProcessor epp : epo.getPreProcessorList()) { + epp.process(newObj, epo); } } } @@ -329,9 +325,7 @@ public class OperationController extends BaseEditController { private void notifyChangeListeners(EditProcessObject epo, String action) { List changeListeners = epo.getChangeListenerList(); if (changeListeners != null){ - Iterator changeIt = changeListeners.iterator(); - while (changeIt.hasNext()) { - ChangeListener cl = changeIt.next(); + for (ChangeListener cl : changeListeners) { switch (action) { case "insert": cl.doInserted(epo.getNewBean(), epo); diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java b/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java index da30a34b8..f7148ccd1 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/util/FormUtils.java @@ -267,11 +267,7 @@ public class FormUtils { } } - Collections.sort(options, new Comparator