From a2451984c27f318379d1b6c531e68337c203d6ed Mon Sep 17 00:00:00 2001
From: brianjlowe <bjl23@cornell.edu>
Date: Wed, 16 Oct 2013 16:16:34 -0400
Subject: [PATCH] VIVO-376 picklist sorting

---
 .../edit/DatapropEditController.java          |  2 +-
 .../controller/edit/EntityEditController.java |  7 +++--
 .../edit/IndividualTypeRetryController.java   | 30 +++++++++----------
 .../edit/PropertyEditController.java          |  2 +-
 .../controller/edit/VclassEditController.java |  2 +-
 .../web/templates/edit/specific/ents_edit.jsp |  2 +-
 6 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/DatapropEditController.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/DatapropEditController.java
index 732b62be8..a86532174 100644
--- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/DatapropEditController.java
+++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/DatapropEditController.java
@@ -70,7 +70,7 @@ public class DatapropEditController extends BaseEditController {
 
         RequestDispatcher rd = request.getRequestDispatcher(Controllers.BASIC_JSP);
 
-        results.add(dp.getLocalNameWithPrefix()); // column 1
+        results.add(dp.getPickListName()); // column 1
         results.add(dp.getPublicName() == null ? "(no public label)" : dp.getPublicName()); // column 2
         
         if (dp.getGroupURI() != null) {
diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/EntityEditController.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/EntityEditController.java
index 41d42f77e..ac1728648 100644
--- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/EntityEditController.java
+++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/EntityEditController.java
@@ -96,6 +96,7 @@ public class EntityEditController extends BaseEditController {
         
         String classStr = "";
         List<VClass> classList = inferredEnt.getVClasses(false);
+        sortForPickList(classList, vreq);
         if (classList != null) {
 	        for (Iterator<VClass> classIt = classList.iterator(); classIt.hasNext();) {
 	        	VClass vc = classIt.next();
@@ -103,7 +104,7 @@ public class EntityEditController extends BaseEditController {
 	            try {
 	                rClassName = "<a href=\"vclassEdit?uri=" +
 	                		URLEncoder.encode(vc.getURI(),"UTF-8")+"\">" + 
-	                		vc.getLocalNameWithPrefix()+"</a>";
+	                		vc.getPickListName()+"</a>";
 	            } catch (Exception e) {
 	                rClassName = vc.getLocalNameWithPrefix();
 	            }
@@ -131,7 +132,9 @@ public class EntityEditController extends BaseEditController {
         FormObject foo = new FormObject();
         HashMap<String, List<Option>> OptionMap = new HashMap<String, List<Option>>();
         
-        request.setAttribute("types",ent.getVClasses(false)); // we're displaying all assertions, including indirect types
+        List<VClass> types = ent.getVClasses(false);
+        sortForPickList(types, vreq);
+        request.setAttribute("types", types); // we're displaying all assertions, including indirect types
         
         try {
             List<Option> externalIdOptionList = new LinkedList<Option>();
diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/IndividualTypeRetryController.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/IndividualTypeRetryController.java
index 87871336e..a22a94440 100644
--- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/IndividualTypeRetryController.java
+++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/IndividualTypeRetryController.java
@@ -65,27 +65,26 @@ public class IndividualTypeRetryController extends BaseEditController {
         
 		List<VClass> allVClasses = vcDao.getAllVclasses();
 	    sortForPickList(allVClasses, vreq);
-		Set<String> allClassURISet = new HashSet<String>();
-		Map<String,String> classNameMap = new HashMap<String,String>();
-		for (Iterator allClassIt = allVClasses.iterator(); allClassIt.hasNext(); ) {
-			VClass vc = (VClass) allClassIt.next();
-			classNameMap.put(vc.getURI(),vc.getPickListName());
-			allClassURISet.add(vc.getURI());
-		}
-
-		allVClasses = null;
 			
+		Set<String> prohibitedURIset = new HashSet<String>();
 		for (Iterator<VClass> indClassIt = ind.getVClasses(false).iterator(); indClassIt.hasNext(); ) {
 			VClass vc = indClassIt.next();
-			allClassURISet.remove(vc.getURI());
+			if(vc.isAnonymous()) {
+			    continue;
+			}
+			prohibitedURIset.add(vc.getURI());
 			for (Iterator<String> djURIIt = vcDao.getDisjointWithClassURIs(vc.getURI()).iterator(); djURIIt.hasNext(); ) {
 				String djURI = djURIIt.next();
-				allClassURISet.remove(djURI);
+	            prohibitedURIset.add(djURI);
 			}
 		}
 		
-		List<String> classURIList = new LinkedList<String>();
-		classURIList.addAll(allClassURISet);
+		List<VClass> eligibleVClasses = new ArrayList<VClass>();
+		for (VClass vc : allVClasses) {
+		    if(vc.getURI() != null && !(prohibitedURIset.contains(vc.getURI()))) {
+		        eligibleVClasses.add(vc);
+		    }
+		}
 		
 		FormObject foo = new FormObject();
 		epo.setFormObject(foo);
@@ -93,9 +92,8 @@ public class IndividualTypeRetryController extends BaseEditController {
 		foo.setOptionLists(optionMap);
 
 		List<Option> typeOptionList = new ArrayList<Option>(); 
-		for (Iterator<String> classURIIt = classURIList.iterator(); classURIIt.hasNext();) {
-			String classURI = classURIIt.next();
-			Option opt = new Option(classURI,classNameMap.get(classURI));
+		for (VClass vc : eligibleVClasses) {
+			Option opt = new Option(vc.getURI(), vc.getPickListName());
 			typeOptionList.add(opt);
 		}
 		
diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyEditController.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyEditController.java
index accb66cb7..4e4ca840e 100644
--- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyEditController.java
+++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/PropertyEditController.java
@@ -79,7 +79,7 @@ public class PropertyEditController extends BaseEditController {
         results.add("sort direction");        // column 23
         results.add("URI");                   // column 24
 
-        results.add(p.getLocalNameWithPrefix()); // column 1
+        results.add(p.getPickListName()); // column 1
         
         String parentPropertyStr = "";
         if (p.getParentURI() != null) {
diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/VclassEditController.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/VclassEditController.java
index f5c5ec047..83ac3b051 100644
--- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/VclassEditController.java
+++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/VclassEditController.java
@@ -116,7 +116,7 @@ public class VclassEditController extends BaseEditController {
         
         String uri = (vcl.getURI() == null) ? "" : vcl.getURI();
         
-        results.add(vcl.getLocalNameWithPrefix());                                // 1
+        results.add(vcl.getPickListName());                                // 1
         results.add(vcl.getName() == null ? "(no public label)" : vcl.getName()); // 2
         results.add(groupName);                                                   // 3
         results.add(ontologyName==null ? "(not identified)" : ontologyName);      // 4
diff --git a/webapp/web/templates/edit/specific/ents_edit.jsp b/webapp/web/templates/edit/specific/ents_edit.jsp
index 7dabfd0e8..10e1764cb 100644
--- a/webapp/web/templates/edit/specific/ents_edit.jsp
+++ b/webapp/web/templates/edit/specific/ents_edit.jsp
@@ -127,7 +127,7 @@
 				<c:url var="typeURL" value="/vclassEdit">
 					<c:param name="uri" value="${type.URI}"/>
 				</c:url>
-				<li><input type="checkbox" name="TypeURI" value="${type.URI}" class="form-item"/><a href="${typeURL}"> ${type.localNameWithPrefix} </a></li>
+				<li><input type="checkbox" name="TypeURI" value="${type.URI}" class="form-item"/><a href="${typeURL}"> ${type.pickListName} </a></li>
 			</c:forEach>	
 			</ul>
 			<input type="hidden" name="individualURI" value="${individual.URI}"/>