diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/AdminLoginController.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/AdminLoginController.java index c44d73f25..fd16d03db 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/AdminLoginController.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/AdminLoginController.java @@ -3,6 +3,8 @@ package edu.cornell.mannlib.vitro.webapp.controller.authenticate; import static edu.cornell.mannlib.vedit.beans.LoginStatusBean.AuthenticationSource.INTERNAL; +import static edu.cornell.mannlib.vitro.webapp.beans.UserAccount.MAX_PASSWORD_LENGTH; +import static edu.cornell.mannlib.vitro.webapp.beans.UserAccount.MIN_PASSWORD_LENGTH; import java.util.HashMap; import java.util.Map; @@ -11,7 +13,6 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import edu.cornell.mannlib.vitro.webapp.auth.requestedAction.Actions; -import edu.cornell.mannlib.vitro.webapp.beans.User; import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest; import edu.cornell.mannlib.vitro.webapp.controller.freemarker.FreemarkerHttpServlet; import edu.cornell.mannlib.vitro.webapp.controller.freemarker.UrlBuilder; @@ -126,8 +127,8 @@ public class AdminLoginController extends FreemarkerHttpServlet { } private boolean isPasswordValidLength(String pw) { - return (pw.length() >= User.MIN_PASSWORD_LENGTH) - && (pw.length() <= User.MAX_PASSWORD_LENGTH); + return (pw.length() >= MIN_PASSWORD_LENGTH) + && (pw.length() <= MAX_PASSWORD_LENGTH); } private boolean tryToLogin() { diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java index a7cadb1f4..af6368315 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/authenticate/ProgramLogin.java @@ -3,8 +3,8 @@ package edu.cornell.mannlib.vitro.webapp.controller.authenticate; import static edu.cornell.mannlib.vedit.beans.LoginStatusBean.AuthenticationSource.INTERNAL; -import static edu.cornell.mannlib.vitro.webapp.beans.User.MAX_PASSWORD_LENGTH; -import static edu.cornell.mannlib.vitro.webapp.beans.User.MIN_PASSWORD_LENGTH; +import static edu.cornell.mannlib.vitro.webapp.beans.UserAccount.MAX_PASSWORD_LENGTH; +import static edu.cornell.mannlib.vitro.webapp.beans.UserAccount.MIN_PASSWORD_LENGTH; import java.io.IOException; import java.io.PrintWriter; diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java index f91d3be49..3e1fe3ab0 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/controller/edit/Authenticate.java @@ -2,6 +2,8 @@ package edu.cornell.mannlib.vitro.webapp.controller.edit; +import static edu.cornell.mannlib.vitro.webapp.beans.UserAccount.MAX_PASSWORD_LENGTH; +import static edu.cornell.mannlib.vitro.webapp.beans.UserAccount.MIN_PASSWORD_LENGTH; import static edu.cornell.mannlib.vitro.webapp.controller.login.LoginProcessBean.State.FORCED_PASSWORD_CHANGE; import static edu.cornell.mannlib.vitro.webapp.controller.login.LoginProcessBean.State.LOGGED_IN; import static edu.cornell.mannlib.vitro.webapp.controller.login.LoginProcessBean.State.LOGGING_IN; @@ -10,8 +12,6 @@ import static edu.cornell.mannlib.vitro.webapp.controller.login.LoginProcessBean import java.io.IOException; import java.io.UnsupportedEncodingException; import java.net.URLDecoder; -import java.security.MessageDigest; -import java.security.NoSuchAlgorithmException; import java.util.HashMap; import java.util.Map; @@ -21,7 +21,6 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; -import org.apache.commons.codec.binary.Hex; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -85,6 +84,7 @@ public class Authenticate extends VitroHttpServlet { * Find out where they are in the login process, process any input, record * the new state, and show the next page. */ + @Override public void doPost(HttpServletRequest request, HttpServletResponse response) { VitroRequest vreq = new VitroRequest(request); @@ -374,10 +374,10 @@ public class Authenticate extends VitroHttpServlet { return; } - if ((newPassword.length() < User.MIN_PASSWORD_LENGTH) - || (newPassword.length() > User.MAX_PASSWORD_LENGTH)) { - bean.setMessage(Message.PASSWORD_LENGTH, User.MIN_PASSWORD_LENGTH, - User.MAX_PASSWORD_LENGTH); + if ((newPassword.length() < MIN_PASSWORD_LENGTH) + || (newPassword.length() > MAX_PASSWORD_LENGTH)) { + bean.setMessage(Message.PASSWORD_LENGTH, MIN_PASSWORD_LENGTH, + MAX_PASSWORD_LENGTH); return; } @@ -393,10 +393,11 @@ public class Authenticate extends VitroHttpServlet { } /** - * They are already logged in. There's nothing to do; no transition. + * They are already logged in. */ @SuppressWarnings("unused") private void processInputLoggedIn(HttpServletRequest request) { + // Nothing to do. No transition. } /**