diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ListedIndividualTemplateModel.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ListedIndividualTemplateModel.java index f65cdaedf..54a73868d 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ListedIndividualTemplateModel.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/ListedIndividualTemplateModel.java @@ -5,6 +5,7 @@ package edu.cornell.mannlib.vitro.webapp.web.templatemodels.individual; import java.util.ArrayList; import java.util.List; +import org.apache.commons.lang.StringUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -70,25 +71,30 @@ public class ListedIndividualTemplateModel extends BaseTemplateModel { String url = individual.getUrl(); if (anchor != null && url != null) { primaryLink = new Link(); - primaryLink.setAnchor(individual.getAnchor()); - primaryLink.setUrl(individual.getUrl()); + primaryLink.setAnchor(anchor); + primaryLink.setUrl(url); } return primaryLink; } public List getAdditionalLinks() { - return individual.getLinksList(); + return individual.getLinksList(); // returns an empty list, but not null } public List getLinks() { - List additionalLinks = getAdditionalLinks(); + List additionalLinks = getAdditionalLinks(); // returns an empty list, but not null List links = new ArrayList(additionalLinks.size()+1); Link primaryLink = getPrimaryLink(); if (primaryLink != null) { links.add(primaryLink); } - links.addAll(additionalLinks); - return links; + for (Link link : additionalLinks) { + // Hide malformed links from the template to make things easier + if ( !(StringUtils.isEmpty(link.getAnchor())) && !(StringUtils.isEmpty(link.getUrl())) ) { + links.add(link); + } + } + return links; // returns an empty list, but not null } public String getName() { diff --git a/webapp/web/templates/freemarker/body/individualList.ftl b/webapp/web/templates/freemarker/body/individualList.ftl index 1603c7656..ad8fe3f1d 100644 --- a/webapp/web/templates/freemarker/body/individualList.ftl +++ b/webapp/web/templates/freemarker/body/individualList.ftl @@ -35,15 +35,14 @@ ${stylesheets.add("/css/browseIndex.css")}