litvinovg/vitro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

1. Made fix to the non-show of short sparklines due to a javascript error.

Browse source 
2. Also provided style placeholders for various exception cases
This commit is contained in:
cdtank 2010-07-15 20:46:57 +00:00
parent 91df110fc3
commit d7727efecd
2 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java
View file

@ -143,6 +143,9 @@ public class VisualizationCodeGenerator {
" border-spacing: 0;" +
" vertical-align: inherit;" +
"}" +
".incomplete-data-holder {" +
"" +
"}" +
/*".sparkline_wrapper_table table{" +
" vertical-align: bottom;" +
"}" +*/
@ -334,14 +337,20 @@ public class VisualizationCodeGenerator {
/*
* Generate the text introducing the vis.
* */
String imcompleteDataText = "This information is based solely on publications which have been loaded into the VIVO system. " +
"This may only be a small sample of the person\\'s total work.";
visualizationCode.append("$('#" + visDivNames.get("SHORT_SPARK") + " td.sparkline_number').text(parseInt(renderedShortSparks) + parseInt(" + unknownYearCoauthors + "));");
visualizationCode.append("var shortSparksText = ''" +
"+ ' Unique co-author(s) with year from '" +
"+ ' " + totalUniqueCoAuthors + " '" +
"+ ' Unique co-author(s) within the last 10 years '" +
"<span class=\"incomplete-data-holder\" title=\"" + imcompleteDataText + "\">(incomplete data)</span>'" +
/*"+ ' " + totalUniqueCoAuthors + " '" +
"+ ' total " +
"<span class=\"sparkline_range\">" +
"(" + shortSparkMinYear + " - " + currentYear + ")" +
"</span>'" +
"</span>'" +*/
"+ '';" +
"$('#" + visDivNames.get("SHORT_SPARK") + " td.sparkline_text').html(shortSparksText);");

9
webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/personpubcount/VisualizationCodeGenerator.java
View file

@ -158,6 +158,9 @@ public class VisualizationCodeGenerator {
"}" +
"td.sparkline_number { text-align:right; padding-right:5px; }" +
"td.sparkline_text {text-align:left;}" +
".incomplete-data-holder {" +
"" +
"}" +
/*"#sparkline_data_table {" +
"width: auto;" +
"}" +
@ -346,12 +349,12 @@ public class VisualizationCodeGenerator {
String imcompleteDataText = "This information is based solely on publications which have been loaded into the VIVO system. " +
"This may only be a small sample of the person's total work.";
"This may only be a small sample of the person\\'s total work.";
visualizationCode.append("$('#" + visDivNames.get("SHORT_SPARK") + " td.sparkline_number').text(parseInt(renderedShortSparks) + parseInt(" + unknownYearPublications + "));");
visualizationCode.append("var shortSparksText = ''" +
"+ ' publications within the last 10 years " +
"<span title=\"" + imcompleteDataText + "\">(incomplete data)</span>'" +
"+ ' publication(s) within the last 10 years " +
"<span class=\"incomplete-data-holder\" title=\"" + imcompleteDataText + "\">(incomplete data)</span>'" +
/*"+ ' " + totalPublications + " '" +
"+ ' total " +
"<span class=\"sparkline_range\">" +