litvinovg/vitro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Minor code improvements

Browse source
This commit is contained in:
Graham Triggs 2017-09-18 11:49:47 +01:00
parent d87bb782eb
commit d97544b991
50 changed files with 344 additions and 405 deletions
Download patch file Download diff file Expand all files Collapse all files

4
api/src/test/java/edu/cornell/mannlib/vitro/webapp/startup/StartupManagerTest.java
View file

@ -301,8 +301,8 @@ public class StartupManagerTest extends AbstractTestClass {
return "";
}
StringBuilder result = new StringBuilder();
for (int i = 0; i < classes.length; i++) {
result.append(classes[i].getName()).append('\n');
for (Class<?> aClass : classes) {
result.append(aClass.getName()).append('\n');
}
return result.toString();
}

4
api/src/test/java/stubs/edu/cornell/mannlib/vitro/webapp/dao/VClassGroupDaoStub.java
View file

@ -39,11 +39,11 @@ public class VClassGroupDaoStub implements VClassGroupDao {
public List<VClassGroup> getPublicGroupsWithVClasses() {
List<VClassGroup> list = new ArrayList<>();
for (VClassGroup group: groups) {
if (!group.isEmpty()) {
if (group != null) {
list.add(group);
}
}
return groups;
return list;
}
// ----------------------------------------------------------------------

2
api/src/test/resources/edu/cornell/mannlib/vitro/webapp/test_config_default.properties
View file

@ -4,4 +4,4 @@
whichfile = test_config_default
# This ends with a blank, in order to test the removal of whitespace
trimmed = whitespace_test\u0020
trimmed = whitespace_test

8
api/src/test/resources/log4j.properties
View file

@ -4,7 +4,7 @@
# It's not very important, because the tests themselves will override this
# configuration in AbstractTestClass.initializeLogging().
#
log4j.rootLogger=WARN, AllAppender
log4j.appender.AllAppender=org.apache.log4j.ConsoleAppender
log4j.appender.AllAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.AllAppender.layout.ConversionPattern=%p %t %c - %m%n
log4j.rootLogger=WARN, AllAppender
log4j.appender.AllAppender=org.apache.log4j.ConsoleAppender
log4j.appender.AllAppender.layout=org.apache.log4j.PatternLayout
log4j.appender.AllAppender.layout.ConversionPattern=%p %t %c - %m%n