From ddae9bb31170575c8ecc774b0b287230e843563a Mon Sep 17 00:00:00 2001 From: cdtank Date: Mon, 19 Jul 2010 21:15:46 +0000 Subject: [PATCH] 1. Fixed a bug for an edge case in coauthorsip vis --- .../VisualizationCodeGenerator.java | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java b/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java index 717bc463d..6490dec0e 100644 --- a/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java +++ b/webapp/src/edu/cornell/mannlib/vitro/webapp/visualization/coauthorship/VisualizationCodeGenerator.java @@ -193,14 +193,17 @@ public class VisualizationCodeGenerator { for (int publicationYear = minPubYearConsidered; publicationYear <= currentYear; publicationYear++) { String stringPublishedYear = String.valueOf(publicationYear); - Integer currentUniqueCoAuthors = yearToUniqueCoauthors.get(stringPublishedYear).size(); - - if (currentUniqueCoAuthors == null) { - currentUniqueCoAuthors = 0; + Set currentCoAuthors = yearToUniqueCoauthors.get(stringPublishedYear); + + Integer currentUniqueCoAuthors = null; + + if (currentCoAuthors != null) { + currentUniqueCoAuthors = currentCoAuthors.size(); + allCoAuthorsWithKnownAuthorshipYears.addAll(currentCoAuthors); } else { - allCoAuthorsWithKnownAuthorshipYears.addAll(yearToUniqueCoauthors.get(stringPublishedYear)); + currentUniqueCoAuthors = 0; } - + visualizationCode.append("data.setValue(" + uniqueCoAuthorCounter + ", 0, '" @@ -212,8 +215,6 @@ public class VisualizationCodeGenerator { + ", 1, " + currentUniqueCoAuthors + ");\n"); - - uniqueCoAuthorCounter++; }