litvinovg/vitro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NIHVIVO-3404 Rename accessor methods on AbstractObjectPropertyStatementAction to be consistent with those on AbstractDataPropertyStatementAction.

Browse source
This commit is contained in:
j2blake 2012-03-30 21:44:46 +00:00
parent 5ecf031bae
commit e8fafcc10c
5 changed files with 27 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
webapp/src/edu/cornell/mannlib/vitro/webapp/auth/permissions/EditByRolePermission.java
View file

@ -88,9 +88,9 @@ public class EditByRolePermission extends Permission {
* to modify its subject, its predicate, and its object. * to modify its subject, its predicate, and its object.
*/ */
private boolean isAuthorized(AbstractObjectPropertyStatementAction action) { private boolean isAuthorized(AbstractObjectPropertyStatementAction action) {
String subjectUri = action.getUriOfSubject(); String subjectUri = action.getSubjectUri();
String predicateUri = action.getUriOfPredicate(); String predicateUri = action.getPredicateUri();
String objectUri = action.getUriOfObject(); String objectUri = action.getObjectUri();
return canModifyResource(subjectUri) return canModifyResource(subjectUri)
&& canModifyPredicate(predicateUri) && canModifyPredicate(predicateUri)
&& canModifyResource(objectUri); && canModifyResource(objectUri);

4
webapp/src/edu/cornell/mannlib/vitro/webapp/auth/policy/RestrictHomeMenuItemEditingPolicy.java
View file

@ -34,9 +34,9 @@ public class RestrictHomeMenuItemEditingPolicy implements PolicyIface {
private PolicyDecision isAuthorized( private PolicyDecision isAuthorized(
AbstractObjectPropertyStatementAction whatToAuth) { AbstractObjectPropertyStatementAction whatToAuth) {
if (whatToAuth.getUriOfPredicate() if (whatToAuth.getPredicateUri()
.equals(DisplayVocabulary.HAS_ELEMENT) .equals(DisplayVocabulary.HAS_ELEMENT)
&& whatToAuth.getUriOfObject().equals( && whatToAuth.getObjectUri().equals(
DisplayVocabulary.HOME_MENU_ITEM)) { DisplayVocabulary.HOME_MENU_ITEM)) {
return notAuthorized(); return notAuthorized();
} else { } else {

6
webapp/src/edu/cornell/mannlib/vitro/webapp/auth/policy/SelfEditingPolicy.java
View file

@ -68,9 +68,9 @@ public class SelfEditingPolicy extends BaseSelfEditingPolicy implements
*/ */
private PolicyDecision isAuthorizedForObjectPropertyAction( private PolicyDecision isAuthorizedForObjectPropertyAction(
List<String> userUris, AbstractObjectPropertyStatementAction action) { List<String> userUris, AbstractObjectPropertyStatementAction action) {
String subject = action.getUriOfSubject(); String subject = action.getSubjectUri();
String predicate = action.getUriOfPredicate(); String predicate = action.getPredicateUri();
String object = action.getUriOfObject(); String object = action.getObjectUri();
if (!canModifyResource(subject)) { if (!canModifyResource(subject)) {
return cantModifyResource(subject); return cantModifyResource(subject);

32
webapp/src/edu/cornell/mannlib/vitro/webapp/auth/requestedAction/propstmt/AbstractObjectPropertyStatementAction.java
View file

@ -9,32 +9,32 @@ import edu.cornell.mannlib.vitro.webapp.auth.requestedAction.ifaces.RequestedAct
* property. * property.
*/ */
public abstract class AbstractObjectPropertyStatementAction extends RequestedAction { public abstract class AbstractObjectPropertyStatementAction extends RequestedAction {
private final String uriOfSubject; private final String subjectUri;
private final String uriOfPredicate; private final String predicateUri;
private final String uriOfObject; private final String objectUri;
public AbstractObjectPropertyStatementAction(String uriOfSubject, String uriOfPredicate, public AbstractObjectPropertyStatementAction(String subjectUri, String predicateUri,
String uriOfObject) { String objectUri) {
this.uriOfSubject = uriOfSubject; this.subjectUri = subjectUri;
this.uriOfPredicate = uriOfPredicate; this.predicateUri = predicateUri;
this.uriOfObject = uriOfObject; this.objectUri = objectUri;
} }
public String getUriOfSubject() { public String getSubjectUri() {
return uriOfSubject; return subjectUri;
} }
public String getUriOfPredicate() { public String getPredicateUri() {
return uriOfPredicate; return predicateUri;
} }
public String getUriOfObject() { public String getObjectUri() {
return uriOfObject; return objectUri;
} }
@Override @Override
public String toString() { public String toString() {
return this.getClass().getSimpleName() + ": <" + uriOfSubject + "> <" return this.getClass().getSimpleName() + ": <" + subjectUri + "> <"
+ uriOfPredicate + "> <" + uriOfObject + ">"; + predicateUri + "> <" + objectUri + ">";
} }
} }

6
webapp/test/edu/cornell/mannlib/vitro/webapp/auth/policy/PolicyHelper_StatementsTest.java
View file

@ -257,10 +257,10 @@ public class PolicyHelper_StatementsTest extends AbstractTestClass {
private PolicyDecision isAuthorized( private PolicyDecision isAuthorized(
AbstractObjectPropertyStatementAction whatToAuth) { AbstractObjectPropertyStatementAction whatToAuth) {
if ((APPROVED_SUBJECT_URI.equals(whatToAuth.getUriOfSubject())) if ((APPROVED_SUBJECT_URI.equals(whatToAuth.getSubjectUri()))
&& (APPROVED_PREDICATE_URI && (APPROVED_PREDICATE_URI
.equals(whatToAuth.getUriOfPredicate())) .equals(whatToAuth.getPredicateUri()))
&& (APPROVED_OBJECT_URI.equals(whatToAuth.getUriOfObject()))) { && (APPROVED_OBJECT_URI.equals(whatToAuth.getObjectUri()))) {
return authorized(); return authorized();
} else { } else {
return inconclusive(); return inconclusive();