diff --git a/productMods/templates/freemarker/edit/forms/organizationHasPositionHistory.ftl b/productMods/templates/freemarker/edit/forms/organizationHasPositionHistory.ftl index 1294d902..e7fce0eb 100644 --- a/productMods/templates/freemarker/edit/forms/organizationHasPositionHistory.ftl +++ b/productMods/templates/freemarker/edit/forms/organizationHasPositionHistory.ftl @@ -16,7 +16,7 @@ <#assign disabledVal="disabled"> <#else> <#assign titleVerb="Create"> - <#assign submitButtonText="Create Position"> + <#assign submitButtonText="Position"> <#assign disabledVal=""/> @@ -39,13 +39,13 @@

<#if lvf.submissionErrorExists(editSubmission, "positionTitle")> - Please enter a value in the Position Title field. + Please enter a value in the Position Title field.
<#if lvf.submissionErrorExists(editSubmission, "positionType")> - Please select a value in the Position Type field. + Please select a value in the Position Type field.
<#if lvf.submissionErrorExists(editSubmission, "personLabel")> - Please enter a value in the Person field. + Please select an existing value or enter a new value in the Person field. <#list submissionErrors?keys as errorFieldName> @@ -55,14 +55,14 @@ <#else> ${submissionErrors[errorFieldName]} -
+ <#elseif errorFieldName == "endField"> <#if submissionErrors[errorFieldName]?contains("after")> The End Year must be later than the Start Year. <#else> ${submissionErrors[errorFieldName]} - +

@@ -92,9 +92,9 @@ - +

- + <#if editMode == "edit"> diff --git a/productMods/templates/freemarker/edit/forms/personHasPositionHistory.ftl b/productMods/templates/freemarker/edit/forms/personHasPositionHistory.ftl index bd4c6d57..2a92ba4e 100644 --- a/productMods/templates/freemarker/edit/forms/personHasPositionHistory.ftl +++ b/productMods/templates/freemarker/edit/forms/personHasPositionHistory.ftl @@ -26,7 +26,7 @@ <#assign disabledVal="disabled"> <#else> <#assign formAction="Create"> - <#assign submitButtonText="Create Position"> + <#assign submitButtonText="Position"> <#assign disabledVal=""> diff --git a/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/OrganizationHasPositionHistoryGenerator.java b/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/OrganizationHasPositionHistoryGenerator.java index f18eeace..75e00d02 100644 --- a/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/OrganizationHasPositionHistoryGenerator.java +++ b/src/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/OrganizationHasPositionHistoryGenerator.java @@ -8,6 +8,7 @@ import javax.servlet.http.HttpSession; import com.hp.hpl.jena.vocabulary.XSD; import edu.cornell.mannlib.vitro.webapp.controller.VitroRequest; +import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary; import edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary.Precision; import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.DateTimeIntervalValidationVTwo; import edu.cornell.mannlib.vitro.webapp.edit.n3editing.VTwo.DateTimeWithPrecisionVTwo; @@ -30,8 +31,9 @@ public class OrganizationHasPositionHistoryGenerator extends VivoBaseGenerator + " ?position rdfs:label ?existingPositionTitle . }"; private static final String QUERY_EXISTING_POSITION_TYPE = "" + + "PREFIX vitro: <" + VitroVocabulary.vitroURI + "> \n" + "SELECT ?existingPositionType WHERE { \n" - + " ?position a ?existingPositionType . }"; + + " ?position vitro:mostSpecificType ?existingPositionType . }"; private static final String QUERY_EXISTING_PERSON = "" + "PREFIX core: \n"