litvinovg/vivo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NIHVIVO-738 Call reorder after removing an author from the list, to eliminate gaps in ranking

Browse source
This commit is contained in:
rjy7 2010-08-09 19:30:38 +00:00
parent a4d0015cff
commit 6184900c85
1 changed files with 14 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

33
productMods/edit/forms/js/addAuthorsToInformationResource.js
View file

@ -562,22 +562,6 @@ var addAuthorForm = {
// authorName = authorLink.html(); // authorName = authorLink.html();
if (status === 'success') { if (status === 'success') {
// Both these cases can be replaced by calling a reorder:
// positions are not needed if we always eliminate gaps in rank
// (what about an error on the reorder call, though?)
// The reset of the rank hidden form field is done in the
// reorder callback.
if (nextAuthorships.length) {
// Reset the position value of each succeeding authorship
nextAuthorships.each(function() {
var pos = addAuthorForm.getPosition(this);
addAuthorForm.setPosition(this, pos-1);
});
} else {
// Removed author was last in rank: reset the rank hidden form field
rank = addAuthorForm.getRankIntVal(authorship);
$('input#rank').val(rank);
}
// In future, do this selectively by only clearing terms that match the // In future, do this selectively by only clearing terms that match the
// deleted author's name // deleted author's name
@ -588,11 +572,22 @@ var addAuthorForm = {
addAuthorForm.removeAuthorFromAcFilter(author); addAuthorForm.removeAuthorFromAcFilter(author);
authorship.fadeOut(400, function() { authorship.fadeOut(400, function() {
var numAuthors;
$(this).remove(); $(this).remove();
// Actions that depend on the author having been removed from the DOM: // Actions that depend on the author having been removed from the DOM:
// If there's just one author remaining, disable drag-drop numAuthors = $('.authorship').length;
if ($('.authorship').length == 1) { if (numAuthors > 0) {
addAuthorForm.disableAuthorDD(); // Reorder to remove any gaps
// RY if we do this based on js objects rather than rank stored in the DOM,
// this wouldn't depend on removing the author from the DOM.
addAuthorForm.reorderAuthors();
// If just one author remaining, disable drag-drop
if (numAuthors == 1) {
addAuthorForm.disableAuthorDD();
}
} }
}); });