diff --git a/productMods/templates/freemarker/body/foaf-person--exportQrCode.ftl b/productMods/templates/freemarker/body/foaf-person--exportQrCode.ftl
index 565fbb66..4f79856e 100644
--- a/productMods/templates/freemarker/body/foaf-person--exportQrCode.ftl
+++ b/productMods/templates/freemarker/body/foaf-person--exportQrCode.ftl
@@ -6,7 +6,7 @@
<#assign qrCodeWidth = "150">
-
diff --git a/productMods/templates/freemarker/body/partials/individual/individual-visualizationMapOfScience.ftl b/productMods/templates/freemarker/body/partials/individual/individual-visualizationMapOfScience.ftl
index 3198681e..821b2b56 100644
--- a/productMods/templates/freemarker/body/partials/individual/individual-visualizationMapOfScience.ftl
+++ b/productMods/templates/freemarker/body/partials/individual/individual-visualizationMapOfScience.ftl
@@ -3,5 +3,5 @@
<#-- Map Of Science visualization -->
\ No newline at end of file
diff --git a/productMods/templates/freemarker/body/partials/individual/individual-visualizationTemporalGraph.ftl b/productMods/templates/freemarker/body/partials/individual/individual-visualizationTemporalGraph.ftl
index 65c73052..8f2f773f 100644
--- a/productMods/templates/freemarker/body/partials/individual/individual-visualizationTemporalGraph.ftl
+++ b/productMods/templates/freemarker/body/partials/individual/individual-visualizationTemporalGraph.ftl
@@ -3,5 +3,5 @@
<#-- Temporal graph visualization -->
\ No newline at end of file
diff --git a/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/IndividualTemplateModel.java b/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/IndividualTemplateModel.java
index 24eed500..e3707eaa 100644
--- a/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/IndividualTemplateModel.java
+++ b/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individual/IndividualTemplateModel.java
@@ -31,17 +31,15 @@ public class IndividualTemplateModel extends BaseIndividualTemplateModel {
private static final String CORE = "http://vivoweb.org/ontology/core#";
private static final String PERSON_CLASS = FOAF + "Person";
private static final String ORGANIZATION_CLASS = FOAF + "Organization";
+ private static final String BASE_VISUALIZATION_URL =
+ UrlBuilder.getUrl(Route.VISUALIZATION_SHORT.path());
private Map
qrData = null;
public IndividualTemplateModel(Individual individual, VitroRequest vreq) {
super(individual, vreq);
}
-
- private String getBaseVisUrl() {
- return getUrl(Route.VISUALIZATION_SHORT.path());
- }
-
+
private Map generateQrData() {
Map qrData = new HashMap();
@@ -81,62 +79,60 @@ public class IndividualTemplateModel extends BaseIndividualTemplateModel {
return qrData;
}
+ private String getVisUrl(String visPath) {
+ String visUrl;
+ boolean isUsingDefaultNameSpace = UrlBuilder.isUriInDefaultNamespace(
+ getUri(),
+ vreq);
+
+ if (isUsingDefaultNameSpace) {
+ visUrl = visPath + getLocalName();
+ } else {
+ visUrl = UrlBuilder.addParams(
+ visPath,
+ new ParamMap(VisualizationFrameworkConstants.INDIVIDUAL_URI_KEY, getUri()));
+ }
+
+ return visUrl;
+ }
- /* Template properties */
+ /* Template methods (for efficiency, not pre-computed) */
- public boolean isPerson() {
+ public boolean person() {
return isVClass(PERSON_CLASS);
}
- public boolean isOrganization() {
+ public boolean organization() {
return isVClass(ORGANIZATION_CLASS);
}
- public String getCoAuthorVisUrl() {
- String coauthorVisURL = getBaseVisUrl() + "/" + VisualizationFrameworkConstants.COAUTHORSHIP_VIS_SHORT_URL + "/";
- return getVisUrl(coauthorVisURL);
+ public String coAuthorVisUrl() {
+ String url = BASE_VISUALIZATION_URL + "/" + VisualizationFrameworkConstants.COAUTHORSHIP_VIS_SHORT_URL + "/";
+ return getVisUrl(url);
}
- public String getCoInvestigatorVisUrl() {
- String coinvestigatorVisURL = getBaseVisUrl() + "/" + VisualizationFrameworkConstants.COINVESTIGATOR_VIS_SHORT_URL + "/";
- return getVisUrl(coinvestigatorVisURL);
+ public String coInvestigatorVisUrl() {
+ String url =
+ BASE_VISUALIZATION_URL + "/" + VisualizationFrameworkConstants.COINVESTIGATOR_VIS_SHORT_URL + "/";
+ return getVisUrl(url);
}
- private String getVisUrl(String coinvestigatorVisURL) {
- boolean isUsingDefaultNameSpace = UrlBuilder.isUriInDefaultNamespace(
- getUri(),
- vreq);
-
- if (isUsingDefaultNameSpace) {
- return coinvestigatorVisURL + getLocalName();
- } else {
- return UrlBuilder.addParams(
- coinvestigatorVisURL,
- new ParamMap(VisualizationFrameworkConstants.INDIVIDUAL_URI_KEY, getUri()));
- }
- }
-
- public String getTemporalGraphUrl() {
- if (!isOrganization()) {
- return null;
- }
- String temporalVisURL = getBaseVisUrl() + "/" + VisualizationFrameworkConstants.PUBLICATION_TEMPORAL_VIS_SHORT_URL + "/";
- return getVisUrl(temporalVisURL);
+ public String temporalGraphUrl() {
+ String url =
+ BASE_VISUALIZATION_URL + "/" + VisualizationFrameworkConstants.PUBLICATION_TEMPORAL_VIS_SHORT_URL + "/";
+ return getVisUrl(url);
}
- public String getMapOfScienceUrl() {
- String mapOfScienceVisURL = getBaseVisUrl() + "/" + VisualizationFrameworkConstants.MAP_OF_SCIENCE_VIS_SHORT_URL + "/";
- return getVisUrl(mapOfScienceVisURL);
+ public String mapOfScienceUrl() {
+ String url =
+ BASE_VISUALIZATION_URL + "/" + VisualizationFrameworkConstants.MAP_OF_SCIENCE_VIS_SHORT_URL + "/";
+ return getVisUrl(url);
}
-
- /* Template methods */
-
- public Map doQrData() {
+ public Map qrData() {
if(qrData == null)
qrData = generateQrData();
return qrData;
}
-
}
diff --git a/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individuallist/ListedIndividual.java b/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individuallist/ListedIndividual.java
index 4a16e1fd..ce9e7899 100644
--- a/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individuallist/ListedIndividual.java
+++ b/src/edu/cornell/mannlib/vitro/webapp/web/templatemodels/individuallist/ListedIndividual.java
@@ -20,12 +20,10 @@ public class ListedIndividual extends BaseListedIndividual {
super(individual, vreq);
}
- /* Access methods for templates */
+ /* Template properties */
public String getPreferredTitle() {
return cleanTextForDisplay( individual.getDataValue(CORE + "preferredTitle") );
}
- // Add method to get core:webpages
-
}