diff --git a/productMods/templates/entity/activityShortView.jsp b/productMods/templates/entity/activityShortView.jsp index 2e9b7728..2e28e0a9 100644 --- a/productMods/templates/entity/activityShortView.jsp +++ b/productMods/templates/entity/activityShortView.jsp @@ -5,12 +5,11 @@ SUBJECT - entity PREDICATE - predicateUri OBJECT - individual - - Predicates: on Person page: Person professionalServiceActivity ServiceActivity - + --%> -<%@ page import="edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary"%> +<%@ page import="edu.cornell.mannlib.vitro.webapp.dao.VitroVocabulary" %> +<%@ page import="edu.cornell.mannlib.vitro.webapp.utils.DisplayUtils" %> <%@ taglib uri="http://java.sun.com/jstl/core" prefix="c" %> <%@ taglib uri="http://java.sun.com/jsp/jstl/functions" prefix="fn" %> @@ -29,45 +28,59 @@ predicateUri == teachingActivityUri || predicateUri == serviceActivityUri || predicateUri == outreachActivityUri}" /> + <%-- individual is the OBJECT of the property referenced - in this case, the Activity object --%> - <%-- RY may need another branch in here; predicateIsActivity vs predicate is something else... - depends if this would display on something other than a person page. --%> + - <%-- Get the Activity label --%> - - <%-- Get the role of the person in the activity --%> - - - <%-- Get the time span of the service activity --%> - - - - <%-- RY Don't know whether we should display just the year, or month and year. - Latter looks like too much info, but why collect it if we aren't going to display it? - Needs reformatting, otherwise we get e.g., "2008-10 - 2009-12" - --%> - - - - - <%-- --%> - - - - - - <%-- Create an html link element to the activity --%> ${activityLabel} + + + - <%-- Final output --%> - ${activityLink} ${role} ${timeSpan} + + <%-- Get the role of the person in the activity --%> + + + <%-- Get the time span of the service activity --%> + + + + + + + + + + + + + + + + + + <%-- Construct the final output --%> + ${activityLink} + + <%-- We need a join but we have to keep getting variables in and out of JSTL/EL/Java. Do this for now even though it's ugly. --%> + + + ${role}, ${timeSpan} + + + ${role} + + + ${timeSpan} + + <%-- no predicate --%>