From a173e5a711ea404895fceff5d9f753ee046b5368 Mon Sep 17 00:00:00 2001
From: rjy7 <rjy7@43c2fc9b-1942-4403-87b2-35b4218f7473>
Date: Mon, 16 Aug 2010 20:06:44 +0000
Subject: [PATCH] NIHVIVO-741 Refactor addAuthorForm javascript to use data
 attached to objects rather than DOM elements and spans to store authorship
 data. Small tweaks; removed unnecessary comments.

---
 .../js/addAuthorsToInformationResource.js     | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/productMods/edit/forms/js/addAuthorsToInformationResource.js b/productMods/edit/forms/js/addAuthorsToInformationResource.js
index d7689f33..82b246a0 100644
--- a/productMods/edit/forms/js/addAuthorsToInformationResource.js
+++ b/productMods/edit/forms/js/addAuthorsToInformationResource.js
@@ -318,7 +318,6 @@ var addAuthorForm = {
             authorships = [];
         
         $('li.authorship').each(function(index) {
-            //var uri = $(this).attr('id'),
             var uri = $(this).data('authorshipUri'),
                 subjectUri = '<' + uri + '>',
                 oldRankVal = addAuthorForm.getRankStrVal(this),
@@ -394,9 +393,8 @@ var addAuthorForm = {
                         nextpos = pos + 1, 
                         authorships = $('#authorships'), 
                         next = addAuthorForm.findAuthorship('position', nextpos);
-                        //authorships.find('.position[id=' + nextpos + ']').parent();
                     
-                    if (next) {
+                    if (next.length) {
                         ui.item.insertBefore(next);
                     }
                     else {
@@ -460,14 +458,16 @@ var addAuthorForm = {
     },
     
     findAuthorship: function(key, value) {
-        var matchingAuthorship = null;
+        var matchingAuthorship = $(); // if we don't find one, return an empty jQuery set
+        
         $('.authorship').each(function() {
             var authorship = $(this);
             if ( authorship.data(key) === value ) {
-                matchingAuthorship = authorship; // **** return authorship or this (this = DOM element; authorship = jquery object) ??
+                matchingAuthorship = authorship; 
                 return false; // stop the loop
             }
-        }); 
+        });
+         
         return matchingAuthorship;       
     },
     
@@ -588,13 +588,6 @@ var addAuthorForm = {
             complete: function(request, status) {
                 var authorship,
                     authorUri;
-                    
-//                var authorship = $(this).parents('.authorship'),
-//                    author = authorship.find('.authorName').attr('id'),
-//                    rank;
-//                  author = $(this).siblings('span.author'),
-//                  authorLink = author.children('a.authorLink'),
-//                  authorName = authorLink.html();
             
                 if (status === 'success') {