From a35e3fb4f55dea067dd88e88ebd44f82fa7a1eb0 Mon Sep 17 00:00:00 2001 From: j2blake Date: Thu, 16 Oct 2014 12:31:42 -0400 Subject: [PATCH] VIVO-873 Simplify and document the DocumentModifier interface. allUris parameter on modifyDocument() was not documented and not used. There is no logical reason for modifyDocument to throw a SkipIndividualException. --- .../webapp/search/documentBuilding/CalculateParameters.java | 2 +- .../webapp/search/documentBuilding/VIVOValuesFromVcards.java | 3 +-- .../VivoInformationResourceContextNodeFieldsTest.java | 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/CalculateParameters.java b/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/CalculateParameters.java index 4e0542e8..d8870508 100644 --- a/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/CalculateParameters.java +++ b/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/CalculateParameters.java @@ -241,7 +241,7 @@ public class CalculateParameters implements DocumentModifier { } @Override - public void modifyDocument(Individual individual, SearchInputDocument doc, StringBuffer addUri) { + public void modifyDocument(Individual individual, SearchInputDocument doc) { // TODO Auto-generated method stub // calculate beta value. log.debug("Parameter calculation starts.."); diff --git a/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VIVOValuesFromVcards.java b/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VIVOValuesFromVcards.java index 27fa9411..9d97de26 100644 --- a/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VIVOValuesFromVcards.java +++ b/src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VIVOValuesFromVcards.java @@ -85,8 +85,7 @@ public class VIVOValuesFromVcards implements DocumentModifier { } @Override - public void modifyDocument(Individual individual, SearchInputDocument doc, - StringBuffer addUri) { + public void modifyDocument(Individual individual, SearchInputDocument doc) { if (individual == null) return; diff --git a/test/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VivoInformationResourceContextNodeFieldsTest.java b/test/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VivoInformationResourceContextNodeFieldsTest.java index c95c0c6d..9deefcfd 100644 --- a/test/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VivoInformationResourceContextNodeFieldsTest.java +++ b/test/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VivoInformationResourceContextNodeFieldsTest.java @@ -61,7 +61,7 @@ public class VivoInformationResourceContextNodeFieldsTest extends AbstractTestCl doc.addField("ALLTEXT", ""); VivoInformationResourceContextNodeFields vircnf = new VivoInformationResourceContextNodeFields(rdfServiceFactory); - vircnf.modifyDocument(ind, doc, new StringBuffer()); + vircnf.modifyDocument(ind, doc); Collection values = doc.getField("ALLTEXT").getValues(); for( Object value : values){ @@ -69,7 +69,7 @@ public class VivoInformationResourceContextNodeFieldsTest extends AbstractTestCl } VivoAgentContextNodeFields vacnf = new VivoAgentContextNodeFields(rdfServiceFactory); - vacnf.modifyDocument(ind, doc, new StringBuffer()); + vacnf.modifyDocument(ind, doc); }