From bf55aaf7d58da0efe0aa46a64da3927e64ac401f Mon Sep 17 00:00:00 2001 From: Graham Triggs Date: Mon, 18 Sep 2017 13:47:18 +0100 Subject: [PATCH] Minor code improvements --- .../AddAssociatedConceptGenerator.java | 2 +- .../ManageLabelsForPersonGenerator.java | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/AddAssociatedConceptGenerator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/AddAssociatedConceptGenerator.java index b6ce7099..aca5545c 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/AddAssociatedConceptGenerator.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/AddAssociatedConceptGenerator.java @@ -411,7 +411,7 @@ public class AddAssociatedConceptGenerator extends VivoBaseGenerator implements private void sortConcepts(List concepts) { - Collections.sort(concepts, new AssociatedConceptInfoComparator()); + concepts.sort(new AssociatedConceptInfoComparator()); log.debug("Concepts should be sorted now" + concepts.toString()); } diff --git a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/ManageLabelsForPersonGenerator.java b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/ManageLabelsForPersonGenerator.java index 955164b5..41675678 100644 --- a/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/ManageLabelsForPersonGenerator.java +++ b/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/ManageLabelsForPersonGenerator.java @@ -301,13 +301,13 @@ public class ManageLabelsForPersonGenerator extends BaseEditConfigurationGenerat } } //Sort list by language label and return - Collections.sort(availableLocales, new Comparator>() { - public int compare(HashMap h1, HashMap h2) { - String languageName1 = (String) h1.get("label"); - String languageName2 = (String) h2.get("label"); - return languageName1.compareTo(languageName2); - } - }); + availableLocales.sort(new Comparator>() { + public int compare(HashMap h1, HashMap h2) { + String languageName1 = (String) h1.get("label"); + String languageName2 = (String) h2.get("label"); + return languageName1.compareTo(languageName2); + } + }); return availableLocales; } @@ -397,7 +397,7 @@ public class ManageLabelsForPersonGenerator extends BaseEditConfigurationGenerat LabelInformationComparator lic = new LabelInformationComparator(); for(String languageName: labelsHash.keySet()) { List labelInfo = labelsHash.get(languageName); - Collections.sort(labelInfo, lic); + labelInfo.sort(lic); } return labelsHash;