litvinovg/vivo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NIHVIVO-801 Don't call reorder method on page load if there are no authors.

Browse source
This commit is contained in:
rjy7 2010-07-14 14:31:00 +00:00
parent c7b4cf7e75
commit c5d4e70273
1 changed files with 19 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

27
productMods/edit/forms/js/addAuthorsToInformationResource.js
View file

@ -61,22 +61,30 @@ var addAuthorForm = {
if (this.findValidationErrors()) { if (this.findValidationErrors()) {
this.initFormAfterInvalidSubmission(); this.initFormAfterInvalidSubmission();
} else { } else {
this.initAuthorListOnlyView(); this.initAuthorListOnlyView();
} }
}, },
/* *** Set up the various page views *** */ /* *** Set up the various page views *** */
// This view shows the list of existing authors and hides the form. initAuthorListOnlyView: function() {
// There is a button to show the form. // Reorder authors on page load so that previously unranked authors get a rank. Otherwise,
initAuthorListOnlyView: function() {
this.hideForm();
this.showFormButtonWrapper.show();
// We reorder authors on page load so that previously unranked authors get a rank. Otherwise,
// when we add a new author, it will get put ahead of any previously unranked authors, instead // when we add a new author, it will get put ahead of any previously unranked authors, instead
// of at the end of the list. (It is also helpful to normalize the data before we get started.) // of at the end of the list. (It is also helpful to normalize the data before we get started.)
this.reorderAuthors(); // This is done only on page load, not when returning to author list only view after hitting 'cancel.'
if ($('.authorship').length) { // make sure we have at least one author
this.reorderAuthors();
}
this.showAuthorListOnlyView();
},
// This view shows the list of existing authors and hides the form.
// There is a button to show the form. We do this on page load, and after
// hitting 'cancel' from full view.
showAuthorListOnlyView: function() {
this.hideForm();
this.showFormButtonWrapper.show();
}, },
// View of form after returning from an invalid submission. On this form, // View of form after returning from an invalid submission. On this form,
@ -116,7 +124,7 @@ var addAuthorForm = {
this.cancel.unbind('click'); this.cancel.unbind('click');
this.cancel.bind('click', function() { this.cancel.bind('click', function() {
addAuthorForm.initAuthorListOnlyView(); addAuthorForm.showAuthorListOnlyView();
return false; return false;
}); });
@ -293,6 +301,7 @@ var addAuthorForm = {
retractions = '', retractions = '',
authorships = []; authorships = [];
$('li.authorship').each(function(index) { $('li.authorship').each(function(index) {
var uri = $(this).attr('id'), var uri = $(this).attr('id'),
subjectUri = '<' + uri + '>', subjectUri = '<' + uri + '>',