From ee44d76e9bd38f94293aef7080efcd739ebfee94 Mon Sep 17 00:00:00 2001
From: jeb228 <jeb228@43c2fc9b-1942-4403-87b2-35b4218f7473>
Date: Wed, 17 Mar 2010 14:03:15 +0000
Subject: [PATCH] NIHVIVO-76 output_summary_formatter should list the names of
 failing tests to the console, so they can be seen in the build log.
 output_manager should return an error code on failure status, so it counts as
 a broken build.

---
 utilities/acceptance-tests/script/output_manager.rb        | 7 ++++++-
 .../acceptance-tests/script/output_summary_formatter.rb    | 4 ++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/utilities/acceptance-tests/script/output_manager.rb b/utilities/acceptance-tests/script/output_manager.rb
index 8ad8c5d2..461dd8b4 100644
--- a/utilities/acceptance-tests/script/output_manager.rb
+++ b/utilities/acceptance-tests/script/output_manager.rb
@@ -211,6 +211,11 @@ class OutputManager
     end
 
     log("INFO ", "Summary complete")
+
+    if @osp.overall_status == Status::BAD
+      log("ERROR", "Tests failed.")
+      raise("Tests failed.")
+    end
   end
 end
 
@@ -235,5 +240,5 @@ if File.expand_path($0) == File.expand_path(__FILE__)
   properties = PropertyFileReader.read(ARGV[0])
 
   om = OutputManager.new(properties)
-  om.summarize()
+  success = om.summarize()
 end
diff --git a/utilities/acceptance-tests/script/output_summary_formatter.rb b/utilities/acceptance-tests/script/output_summary_formatter.rb
index 8ad6ecc0..8a630ce8 100644
--- a/utilities/acceptance-tests/script/output_summary_formatter.rb
+++ b/utilities/acceptance-tests/script/output_summary_formatter.rb
@@ -127,6 +127,8 @@ END_STATS
   # Write a table of failed tests to the summary file, with links
   # to the detailed output for each test.
   #
+  # While we're at it, write the list of failed tests to the console.
+  #
   # f -- a file, already open for output.
   #
   def write_summary_failure_section(f)
@@ -148,6 +150,8 @@ END_STATS
         f.print "      <td>#{t.suite_name}</td>\n"
         f.print "      <td><a href=\"#{t.output_link}\">#{t.test_name}</a></td>\n"
         f.print "    </tr>\n"
+        
+        puts "Test failed: #{t.suite_name}, #{t.test_name}"
       end
     end