Skip to content

[VIVO-1436] Address code review comments on PR #85

backups requested to merge github/fork/awoods/vivo-1436 into wip-vivo-1436

Created by: awoods

From:

Resolves: https://github.com/vivo-project/Vitro/pull/80/files#r227428235 https://github.com/vivo-project/Vitro/pull/80/files#r227892906 https://github.com/vivo-project/Vitro/pull/80/files#r227905400 https://github.com/vivo-project/Vitro/pull/80/files#r227907884 https://github.com/vivo-project/Vitro/pull/80/files#r227909775 https://github.com/vivo-project/Vitro/pull/80/files#r227913953 https://github.com/vivo-project/Vitro/pull/80/files#r227913145 https://github.com/vivo-project/Vitro/pull/80/files#r227913209 https://github.com/vivo-project/Vitro/pull/80/files#r227914673 https://github.com/vivo-project/Vitro/pull/80/files#r227915444 https://github.com/vivo-project/Vitro/pull/80/files#r227960329

Not addresses: https://github.com/vivo-project/Vitro/pull/80/files#r227429141 https://github.com/vivo-project/Vitro/pull/80/files#r227434076

Thank you for submitting a pull request! Title this pull request with a brief description of what the pull request fixes/improves/changes. Please describe the pull request in detail using the template below.

JIRA Issue: (please link to issue)

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

A brief description of what the intended result of the PR will be and/or what problem it solves.

What's new?

An in-depth description of the changes made by this PR. Technical details and possible side effects. Include screenshots if appropriate.

Example:

  • Changes x feature to such that y
  • Added x
  • Removed y

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the pull request does what is intended.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Example:

  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository?
  • Could this change impact execution of existing code?

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

Merge request reports