Skip to content

[DRAFT] Replacing singles quotes with double quotes in FreeMarker files

backups requested to merge github/fork/nicalico/VIVO1842 into sprint-i18n

Created by: nicalico

Related to : https://github.com/vivo-project/Vitro/pull/172 https://github.com/vivo-project/Vitro-languages/pull/25 https://github.com/vivo-project/VIVO-languages/pull/60

Resolves : https://jira.lyrasis.org/browse/VIVO-1842

What is the bug?

  1. In the fr_CA properties files, some strings contain single quotes.
  2. When a FreeMarker file declares a variable with such a string, it cannot escape the single quotes.
  3. Hence, when JavaScript further declares such a variable by using singles quotes, this might cause an unbalanced quotation error.

What does this pull request do?

  1. Whenever a fr_CA custom FreeMarker file substituted single quotes to double quotes, that sustitution was reported in the equivalent core FreeMarker file (see also https://github.com/vivo-project/Vitro/pull/172)
  2. If there was no further customization in the fr_CA FreeMarker file, it was deleted (see https://github.com/vivo-project/Vitro-languages/pull/25 and https://github.com/vivo-project/VIVO-languages/pull/60).

Note: https://jira.lyrasis.org/browse/VIVO-1842 called for an exhaustive replacement of all the single quote to double quotes in the core FreeMarker files. This PR fixes only the one that would cause a bug.

How should this be tested?

Those modifications affect a great number of files, and a general checkup should be performed.

Interested parties

@MichelHeon

Merge request reports