Changed hardcoded strings 'advisor' and 'Subject Area' to language-neutral variables in personHasAdviseeRelationship.ftl
Created by: tawahle
What does this pull request do?
Changes hardcoded strings 'advisor' and 'Subject Area' to language-neutral variables in the entry form for Advisee Relationship (Create advisee relationship entry for)
Example:
- Changes defaultTypeName: 'advisor' to defaultTypeName: '${i18n().advisor?js_string}'
- Changes multipleTypeNames: {advisor: 'advisor', SubjectArea: 'Subject Area'} to multipleTypeNames: {advisor: '
{i18n().advisor?js_string}', SubjectArea: '{i18n().subject_Area?js_string}'}
How should this be tested?
- advisor and Subject Area should be first added to https://github.com/vivo-project/VIVO-languages i18n property files.
- Test in the entry form ### Create advisee relationship entry for
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Example:
- Does this change require documentation to be updated?
- Does this change add any new dependencies?
- Does this change require any other modifications to be made to the repository?
- Could this change impact execution of existing code?
- Large pull requests should be avoided. If this PR is large (more than 1,000 lines of codes), please provide short explanation why your contribution can't be decoupled in smaller PRs.
Interested parties
@VIVO-project/vivo-committers