litvinovg/vivo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

VIVO-873 Simplify and document the DocumentModifier interface.

Browse source 
allUris parameter on modifyDocument() was not documented and not used.
There is no logical reason for modifyDocument to throw a SkipIndividualException.
This commit is contained in:
j2blake 2014-10-16 12:31:42 -04:00
parent 087fafcd7a
commit a35e3fb4f5
3 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/CalculateParameters.java
View file

@ -241,7 +241,7 @@ public class CalculateParameters implements DocumentModifier {
} }
@Override @Override
public void modifyDocument(Individual individual, SearchInputDocument doc, StringBuffer addUri) { public void modifyDocument(Individual individual, SearchInputDocument doc) {
// TODO Auto-generated method stub // TODO Auto-generated method stub
// calculate beta value. // calculate beta value.
log.debug("Parameter calculation starts.."); log.debug("Parameter calculation starts..");

3
src/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VIVOValuesFromVcards.java
View file

@ -85,8 +85,7 @@ public class VIVOValuesFromVcards implements DocumentModifier {
} }
@Override @Override
public void modifyDocument(Individual individual, SearchInputDocument doc, public void modifyDocument(Individual individual, SearchInputDocument doc) {
StringBuffer addUri) {
if (individual == null) if (individual == null)
return; return;

4
test/edu/cornell/mannlib/vitro/webapp/search/documentBuilding/VivoInformationResourceContextNodeFieldsTest.java
View file

@ -61,7 +61,7 @@ public class VivoInformationResourceContextNodeFieldsTest extends AbstractTestCl
doc.addField("ALLTEXT", ""); doc.addField("ALLTEXT", "");
VivoInformationResourceContextNodeFields vircnf = new VivoInformationResourceContextNodeFields(rdfServiceFactory); VivoInformationResourceContextNodeFields vircnf = new VivoInformationResourceContextNodeFields(rdfServiceFactory);
vircnf.modifyDocument(ind, doc, new StringBuffer()); vircnf.modifyDocument(ind, doc);
Collection<Object> values = doc.getField("ALLTEXT").getValues(); Collection<Object> values = doc.getField("ALLTEXT").getValues();
for( Object value : values){ for( Object value : values){
@ -69,7 +69,7 @@ public class VivoInformationResourceContextNodeFieldsTest extends AbstractTestCl
} }
VivoAgentContextNodeFields vacnf = new VivoAgentContextNodeFields(rdfServiceFactory); VivoAgentContextNodeFields vacnf = new VivoAgentContextNodeFields(rdfServiceFactory);
vacnf.modifyDocument(ind, doc, new StringBuffer()); vacnf.modifyDocument(ind, doc);
} }